From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753878AbcHRHSS (ORCPT ); Thu, 18 Aug 2016 03:18:18 -0400 Received: from mga03.intel.com ([134.134.136.65]:8491 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753749AbcHRHSQ (ORCPT ); Thu, 18 Aug 2016 03:18:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,537,1464678000"; d="asc'?scan'208";a="750304184" From: Felipe Balbi To: Baolin Wang , gregkh@linuxfoundation.org Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, broonie@kernel.org, baolin.wang@linaro.org Subject: Re: [PATCH 2/4] usb: host: xhci: Introduce one new 'usb3_slow_suspend' member for xhci private data In-Reply-To: References: User-Agent: Notmuch/0.22.1+63~g994277e (https://notmuchmail.org) Emacs/25.1.1 (x86_64-pc-linux-gnu) Date: Thu, 18 Aug 2016 10:18:00 +0300 Message-ID: <87inuy5yvr.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Baolin Wang writes: > Now some usb controllers (such as dwc3 controller) need 'XHCI_SLOW_SUSPEN= D' > quirk when suspending the xhci, thus we need to add 'usb3_slow_suspend' m= ember > in xhci platform data to support this. > > Signed-off-by: Baolin Wang > --- > drivers/usb/host/xhci-plat.c | 3 +++ > include/linux/usb/xhci_pdriver.h | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c > index e2e2487..162f17c 100644 > --- a/drivers/usb/host/xhci-plat.c > +++ b/drivers/usb/host/xhci-plat.c > @@ -250,6 +250,9 @@ static int xhci_plat_probe(struct platform_device *pd= ev) > (pdata && pdata->usb3_lpm_capable)) > xhci->quirks |=3D XHCI_LPM_SUPPORT; >=20=20 > + if (pdata && pdata->usb3_slow_suspend) > + xhci->quirks |=3D XHCI_SLOW_SUSPEND; I remember having a discussion about this with Paul Z and it turned out that we really didn't need SLOW_SUSPEND. Can you describe further in what situation you need this quirk? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJXtWEoAAoJEIaOsuA1yqREMDYP/AsVBNuGpE6JDWINySWrT9Ji E0N3CStPogT89n5r0oiGgjQtGpGJJD3Gx1Y1Rr2p2RGhqglcPTFZu5j9RIc0omr5 s1QRPtUOhQTfFEgLH6grIWX2UajL5YERnCcYElupJyPpJ1NAf1xm9iUBYfoqjumC 9d4kd768M0Tv71n7B1r+NoyHA/qHrfnlZCyGsr4mfTJzuuS/2sFAytERyWDcwwhY 9PGtGupAsxUhQe0s7JhydTLSdCQNtswS+lKh4V3MrRrJV//r+P3Yqvd4mKai/ZE1 0Ds4RZcSEcxbaCGhVD7sKFPCYhgs3aDesP63E6unZgNcdbSzO4CUmFqelplrvMUD YQOsYOSiY2sIjoWOgxkfEXV55cOxC7epJrE09jE2PNdfQfeFG50WT5ySkXWE05RM SjK5onQZ/z2GJ1A0gGAOGC5UJk+8AdmzzJ0ODWqHWXeZfkFqs7oNagw5hT7Ypeye NUslS2tJAWi1bEEdGiwhmvjTjEc8EJrJZrJAI398ngjYHHbYzcTszUhoWqG5o6S9 MP14j7zaLGDZdsQW/zA3SPsoTZyhBxt6FXJHXDdSH9eIRJ1qg29vfW1Co+KoRBRH Vd+XywOHLPR0dhgIS8lbEp1ato1OOChDMuhOqSLQdmq0TaOUW+hBRMln2FMsXfUj nye0ZaBIEKMWqLcBDQtQ =P1Fh -----END PGP SIGNATURE----- --=-=-=--