From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:60543 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753859AbcDVSJT (ORCPT ); Fri, 22 Apr 2016 14:09:19 -0400 From: Kalle Valo To: Johannes Berg Cc: Arnd Bergmann , Tina Ruchandani , y2038@lists.linaro.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, "Luis R. Rodriguez" Subject: Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval' References: <20160413060916.GA21184@localhost> <5521267.mr5HLCdTY6@wuerfel> <1460896953.15362.2.camel@sipsolutions.net> <4679823.7bDEQhE9qO@wuerfel> <1461056272.2766.8.camel@sipsolutions.net> Date: Fri, 22 Apr 2016 21:09:11 +0300 In-Reply-To: <1461056272.2766.8.camel@sipsolutions.net> (Johannes Berg's message of "Tue, 19 Apr 2016 10:57:52 +0200") Message-ID: <87inz9y0qg.fsf@purkki.adurom.net> (sfid-20160422_200941_796893_CCE88B8D) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Johannes Berg writes: > On Mon, 2016-04-18 at 00:10 +0200, Arnd Bergmann wrote: >> On Sunday 17 April 2016 14:42:33 Johannes Berg wrote: >> > >> > I was thinking more restrictively of just the stuff that can't even >> > be built without modifying the sources - like the "#if VERBOSE" >> > thing. >> >> All the DEBUG() statements are inside of this kind of check, so if we >> remove the #ifdefs, it would be logical to remove the rest of the >> debugging infrastructure (DEBUG() macros, SHOW_*, pc_debug, maybe >> more) as well. > > Seems reasonable. > > Maybe we should Cc the maintainer, but I suspect that since the driver > is marked Obsolete anyway Luis won't care either :) I'm planning to apply this patch anyway, the debugging infrastructure removal can be a followup patch. But please let me know if I should drop this instead. -- Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval' Date: Fri, 22 Apr 2016 21:09:11 +0300 Message-ID: <87inz9y0qg.fsf@purkki.adurom.net> References: <20160413060916.GA21184@localhost> <5521267.mr5HLCdTY6@wuerfel> <1460896953.15362.2.camel@sipsolutions.net> <4679823.7bDEQhE9qO@wuerfel> <1461056272.2766.8.camel@sipsolutions.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "Luis R. Rodriguez" , Arnd Bergmann , y2038@lists.linaro.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Tina Ruchandani , linux-kernel@vger.kernel.org To: Johannes Berg Return-path: In-Reply-To: <1461056272.2766.8.camel@sipsolutions.net> (Johannes Berg's message of "Tue, 19 Apr 2016 10:57:52 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" List-Id: netdev.vger.kernel.org Sm9oYW5uZXMgQmVyZyA8am9oYW5uZXNAc2lwc29sdXRpb25zLm5ldD4gd3JpdGVzOgoKPiBPbiBN b24sIDIwMTYtMDQtMTggYXQgMDA6MTAgKzAyMDAsIEFybmQgQmVyZ21hbm4gd3JvdGU6Cj4+IE9u IFN1bmRheSAxNyBBcHJpbCAyMDE2IDE0OjQyOjMzIEpvaGFubmVzIEJlcmcgd3JvdGU6Cj4+ID4g Cj4+ID4gSSB3YXMgdGhpbmtpbmcgbW9yZSByZXN0cmljdGl2ZWx5IG9mIGp1c3QgdGhlIHN0dWZm IHRoYXQgY2FuJ3QgZXZlbgo+PiA+IGJlIGJ1aWx0IHdpdGhvdXQgbW9kaWZ5aW5nIHRoZSBzb3Vy Y2VzIC0gbGlrZSB0aGUgIiNpZiBWRVJCT1NFIgo+PiA+IHRoaW5nLgo+Pgo+PiBBbGwgdGhlIERF QlVHKCkgc3RhdGVtZW50cyBhcmUgaW5zaWRlIG9mIHRoaXMga2luZCBvZiBjaGVjaywgc28gaWYg d2UKPj4gcmVtb3ZlIHRoZSAjaWZkZWZzLCBpdCB3b3VsZCBiZSBsb2dpY2FsIHRvIHJlbW92ZSB0 aGUgcmVzdCBvZiB0aGUKPj4gZGVidWdnaW5nIGluZnJhc3RydWN0dXJlIChERUJVRygpIG1hY3Jv cywgU0hPV18qLCBwY19kZWJ1ZywgbWF5YmUKPj4gbW9yZSkgYXMgd2VsbC4KPgo+IFNlZW1zIHJl YXNvbmFibGUuCj4KPiBNYXliZSB3ZSBzaG91bGQgQ2MgdGhlIG1haW50YWluZXIsIGJ1dCBJIHN1 c3BlY3QgdGhhdCBzaW5jZSB0aGUgZHJpdmVyCj4gaXMgbWFya2VkIE9ic29sZXRlIGFueXdheSBM dWlzIHdvbid0IGNhcmUgZWl0aGVyIDopCgpJJ20gcGxhbm5pbmcgdG8gYXBwbHkgdGhpcyBwYXRj aCBhbnl3YXksIHRoZSBkZWJ1Z2dpbmcgaW5mcmFzdHJ1Y3R1cmUKcmVtb3ZhbCBjYW4gYmUgYSBm b2xsb3d1cCBwYXRjaC4gQnV0IHBsZWFzZSBsZXQgbWUga25vdyBpZiBJIHNob3VsZCBkcm9wCnRo aXMgaW5zdGVhZC4KCi0tIApLYWxsZSBWYWxvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fClkyMDM4IG1haWxpbmcgbGlzdApZMjAzOEBsaXN0cy5saW5hcm8u b3JnCmh0dHBzOi8vbGlzdHMubGluYXJvLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3kyMDM4Cg==