From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37355)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZmM1c-0002rC-T2
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 09:23:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZmM1W-0006e5-UF
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 09:23:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51551)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZmM1W-0006dq-GG
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 09:23:18 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1444710158-8723-1-git-send-email-eblake@redhat.com>
	<1444710158-8723-16-git-send-email-eblake@redhat.com>
	<87zizm6c67.fsf@blackfin.pond.sub.org> <561D24CA.7030804@redhat.com>
	<87mvvmvghf.fsf@blackfin.pond.sub.org> <561D42C3.1050207@redhat.com>
	<87wpuqmxex.fsf@blackfin.pond.sub.org>
	<87io697vmm.fsf@blackfin.pond.sub.org> <561E51A9.9060307@redhat.com>
Date: Wed, 14 Oct 2015 15:23:15 +0200
In-Reply-To: <561E51A9.9060307@redhat.com> (Eric Blake's message of "Wed, 14
	Oct 2015 06:59:21 -0600")
Message-ID: <87io69zirg.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member
	checks to schema check()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>

Eric Blake <eblake@redhat.com> writes:

> On 10/14/2015 01:32 AM, Markus Armbruster wrote:
>
>>> Done & pushed to http://repo.or.cz/qemu/armbru.git branch qapi-next.
>> 
>> Redone & pushed.
>> 
>> Summary of tweaks:
>> * PATCH 01-06.5: unchanged
>> * PATCH 07: your fixup to drop is_implicit() squashed in
>> * PATCH 08: array info plumbing moved to PATCH 12
>> * PATCH 09: trivially rebased
>> * PATCH 12: revert your fixup, so we get the move we want, adjust commit
>>   message accordingly, supply missing QAPISchemaArrayType.is_implicit()
>
> You may also want to squash this into 12:
>
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index fd95864..1e01714 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -792,10 +792,9 @@ class QAPISchemaEntity(object):
>          self.name = name
>          # For explicitly defined entities, info points to the (explicit)
>          # definition.  For builtins (and their arrays), info is None.
> -        # For other arrays, info points to an explicit place that uses
> -        # the array (there may be more than one such place).  For other
> -        # implicitly defined entities, it points to the place that
> -        # triggered the implicit definition.
> +        # For implicitly defined entities, info points to a place that
> +        # triggered the implicit definition (there may be more than one
> +        # such place).
>          self.info = info
>
>      def c_name(self):

Done.  Thanks!