From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTQbi-0002Vd-Pu for qemu-devel@nongnu.org; Mon, 15 Sep 2014 03:22:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTQbc-0003lH-Kn for qemu-devel@nongnu.org; Mon, 15 Sep 2014 03:21:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTQbc-0003l3-D5 for qemu-devel@nongnu.org; Mon, 15 Sep 2014 03:21:48 -0400 From: Markus Armbruster References: <1410620427-20089-1-git-send-email-armbru@redhat.com> <1410620427-20089-11-git-send-email-armbru@redhat.com> <20140915065827.GB29999@fam-t430.nay.redhat.com> Date: Mon, 15 Sep 2014 09:21:43 +0200 In-Reply-To: <20140915065827.GB29999@fam-t430.nay.redhat.com> (Fam Zheng's message of "Mon, 15 Sep 2014 14:58:27 +0800") Message-ID: <87iokppcvs.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, benoit.canet@nodalink.com Fam Zheng writes: > On Sat, 09/13 17:00, Markus Armbruster wrote: >> The patch is big, but all it really does is replacing >> >> dinfo->bdrv >> >> by >> >> blk_bs(blk_legacy_dinfo(dinfo)) > > s/blk_legacy_dinfo/blk_by_legacy_dinfo/ > > Otherwise looks good, > > Reviewed-by: Fam Zheng Fixed & thanks!