From: Petr Rockai <prockai@redhat.com>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW ./WHATS_NEW_DM libdm/libdm-de ...
Date: Thu, 08 Apr 2010 00:31:44 +0200 [thread overview]
Message-ID: <87iq826gj3.fsf@twilight.int.mornfall.net.> (raw)
In-Reply-To: <20100407200443.26841.qmail@sourceware.org> (agk@sourceware.org's message of "7 Apr 2010 20:04:43 -0000")
Hi,
agk at sourceware.org writes:
> --- LVM2/libdm/libdm-deptree.c 2010/03/25 18:22:04 1.72
> +++ LVM2/libdm/libdm-deptree.c 2010/04/07 20:04:42 1.73
> @@ -1047,9 +1047,14 @@
>
> /* Refresh open_count */
> if (!_info_by_dev(dinfo->major, dinfo->minor, 1, &info) ||
> - !info.exists || info.open_count)
> + !info.exists)
> continue;
>
> + if (info.open_count) {
> + r = 0;
> + continue;
> + }
As far as I can tell, this r = 0 is new behaviour that breaks a number
of tests and may break user scripts. Is it necessary?
Yours,
Petr.
next prev parent reply other threads:[~2010-04-07 22:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 20:04 LVM2 ./WHATS_NEW ./WHATS_NEW_DM libdm/libdm-de agk
2010-04-07 22:31 ` Petr Rockai [this message]
2010-04-07 23:00 ` Alasdair G Kergon
2010-04-19 22:38 ` Mike Snitzer
2010-04-19 23:25 ` Alasdair G Kergon
2010-04-21 6:35 ` Mike Snitzer
2010-04-21 17:59 ` [PATCH] conditionally avoid preloading the origin in vg_remove_snapshot Mike Snitzer
2010-04-23 0:11 ` Alasdair G Kergon
2010-04-21 19:38 ` Allowing an actively merging snapshot to be removed? Mike Snitzer
2010-04-22 0:01 ` Mikulas Patocka
2010-04-22 23:36 ` Alasdair G Kergon
2010-04-23 14:48 ` Mike Snitzer
-- strict thread matches above, loose matches on Subject: below --
2009-09-25 18:30 LVM2 ./WHATS_NEW ./WHATS_NEW_DM libdm/libdm-de agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iq826gj3.fsf@twilight.int.mornfall.net. \
--to=prockai@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.