From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A608C3DA6E for ; Sun, 31 Dec 2023 09:10:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 346D910E044; Sun, 31 Dec 2023 09:10:55 +0000 (UTC) Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0683E10E044 for ; Sun, 31 Dec 2023 09:10:52 +0000 (UTC) Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4T2td25K4fz9sc6; Sun, 31 Dec 2023 10:10:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oltmanns.dev; s=MBO0001; t=1704013846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hlVujKA1PeQa8EJSC4InM714qJCCxj/rjMUfrSS3bfw=; b=r1cTud9M3wVC9jFHCOg36Lt+//kfqLq90rmJ/bB54sN/mMd80lSOW/e5APEc8e/w0SQHOA W0XVmqtTOgXzFhNW+LB6KpSTy7ap6356EBmoXrVWGux9v5vjEG2RoJ/hu2YGK3E77g6u5H hDWGnAi69NcrqulMRrynDdB8jYN/OI8FBxgoIIGHHxGdY7hGIaLihyJjlBxqhHIaHpKmXd 9pRylo1kYGLy8et8nYpNN99xwKMpnaBllrmeZPUtQ3MDwi4dgrAzoIxCzTBSqia78qTUUM pPZSq2e2oYF0XhqMZAXNx60BHaU7OXdUljURCJUxhSHtGQM0Y4zjXUR+E3tNrw== References: <20231218-pinephone-pll-fixes-v1-0-e238b6ed6dc1@oltmanns.dev> <20231218-pinephone-pll-fixes-v1-4-e238b6ed6dc1@oltmanns.dev> <13411739.uLZWGnKmhe@jernej-laptop> From: Frank Oltmanns To: Jernej =?utf-8?Q?=C5=A0krabec?= Subject: Re: [PATCH 4/5] clk: sunxi-ng: a64: Add constraints on PLL-VIDEO0's n/m ratio In-reply-to: <13411739.uLZWGnKmhe@jernej-laptop> Date: Sun, 31 Dec 2023 10:10:40 +0100 Message-ID: <87jzoug2jz.fsf@oltmanns.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Purism Kernel Team , Samuel Holland , Stephen Boyd , David Airlie , Michael Turquette , linux-kernel@vger.kernel.org, Maxime Ripard , linux-clk@vger.kernel.org, linux-sunxi@lists.linux.dev, Chen-Yu Tsai , Ondrej Jirman , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Jessica Zhang , Sam Ravnborg , Guido =?utf-8?Q?G=C3=BCnther?= , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2023-12-19 at 17:54:19 +0100, Jernej =C5=A0krabec wrote: > Dne ponedeljek, 18. december 2023 ob 14:35:22 CET je Frank Oltmanns napis= al(a): >> The Allwinner A64 manual lists the following constraint for the >> PLL-VIDEO0 clock: 8 <=3D N/M <=3D 25 >> >> Use this constraint. >> >> Signed-off-by: Frank Oltmanns >> --- >> drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c b/drivers/clk/sunxi-n= g/ccu-sun50i-a64.c >> index c034ac027d1c..75d839da446c 100644 >> --- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> @@ -68,7 +68,8 @@ static SUNXI_CCU_NM_WITH_SDM_GATE_LOCK(pll_audio_base_= clk, "pll-audio-base", >> BIT(28), /* lock */ >> CLK_SET_RATE_UNGATE); >> >> -static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST(pll_video0_clk,= "pll-video0", >> +static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_FEAT_NM_RATIO(pll_video= 0_clk, >> + "pll-video0", >> "osc24M", 0x010, >> 192000000, /* Minimum rate */ >> 1008000000, /* Maximum rate */ I just realized that adding the whole ratio limits for ccu_nm is superfluous as you could just as well express them in for of a minimum and maximum range: Since 8 <=3D N/M <=3D 25 and parent_rate =3D 24 MHz, therefore 192 MHz <=3D rate <=3D 600 MHz. These absolute limits are also listed in Allwinner's A64 manual. BUT, here the upper limit was raised to 1008 MHz: 5de39acaf34604bd04834f092479cf4dcc946dd "clk: sunxi-ng: a64: Add max. rate constraint to video PLL" With this upper limit the ratio limitation is effectively: 8 <=3D N/M <=3D 42 Icenowy Zheng (added to CC) had the reasonable explanation that this was used in the BSP kernel, so we should probably stick to that and ditch the two PLL-VIDEO0 related patches. What are your thoughts on that? >> @@ -80,7 +81,10 @@ static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSE= ST(pll_video0_clk, "pll-vid >> 297000000, /* frac rate 1 */ >> BIT(31), /* gate */ >> BIT(28), /* lock */ >> - CLK_SET_RATE_UNGATE); >> + CLK_SET_RATE_UNGATE, >> + CCU_FEATURE_FRACTIONAL | >> + CCU_FEATURE_CLOSEST_RATE, > > Above flags are unrelated change, put them in new patch if needed. > > Best regards, > Jernej > >> + 8, 25); /* min/max nm ratio */ >> >> static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK(pll_ve_clk, "pll-ve", >> "osc24M", 0x018, >> >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18EC5C3DA6E for ; Sun, 31 Dec 2023 09:11:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:Cc:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=KU0WyrTinM+zFVPWTo87Fbh/9MeL+dNQIfF5iG9wcUU=; b=h8lsR/6hXgeGoFN+77MP55BLYJ P3cxQbYASl/q8gy/Gvj3QKl3ew7sf2Cg/xAZbRnxpWbhfz/nqGRQlxUskVYeI7C3AzND5CkpdU2rP Nt9vnAosQUu7sKt7dxZ+iAW/0a1qcklrBW/xy13DCUYD/zO26JIGieCZO5WDWTyO6xqe5pkZ/m46i 1yYPMFID7MxxFRXQrKEn+Hi1aR0n4NlPtFW7GpLzC9yUYsahkMvRJlIOOb6R1xMPof2C8J3zc6FIj srtu5/D+p91RwV0vRJKqNxjp8jcJf0KVbmF0pe9WCa5SbvgReGWViMwrZBYV3MVpQVJ8PeFArHxSw XbzabmsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rJrqX-004Guo-0Q; Sun, 31 Dec 2023 09:11:01 +0000 Received: from mout-p-102.mailbox.org ([80.241.56.152]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rJrqT-004Gty-1P for linux-arm-kernel@lists.infradead.org; Sun, 31 Dec 2023 09:10:59 +0000 Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4T2td25K4fz9sc6; Sun, 31 Dec 2023 10:10:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oltmanns.dev; s=MBO0001; t=1704013846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hlVujKA1PeQa8EJSC4InM714qJCCxj/rjMUfrSS3bfw=; b=r1cTud9M3wVC9jFHCOg36Lt+//kfqLq90rmJ/bB54sN/mMd80lSOW/e5APEc8e/w0SQHOA W0XVmqtTOgXzFhNW+LB6KpSTy7ap6356EBmoXrVWGux9v5vjEG2RoJ/hu2YGK3E77g6u5H hDWGnAi69NcrqulMRrynDdB8jYN/OI8FBxgoIIGHHxGdY7hGIaLihyJjlBxqhHIaHpKmXd 9pRylo1kYGLy8et8nYpNN99xwKMpnaBllrmeZPUtQ3MDwi4dgrAzoIxCzTBSqia78qTUUM pPZSq2e2oYF0XhqMZAXNx60BHaU7OXdUljURCJUxhSHtGQM0Y4zjXUR+E3tNrw== References: <20231218-pinephone-pll-fixes-v1-0-e238b6ed6dc1@oltmanns.dev> <20231218-pinephone-pll-fixes-v1-4-e238b6ed6dc1@oltmanns.dev> <13411739.uLZWGnKmhe@jernej-laptop> From: Frank Oltmanns To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Michael Turquette , Stephen Boyd , Chen-Yu Tsai , Samuel Holland , Guido =?utf-8?Q?G=C3=BCnther?= , Purism Kernel Team , Ondrej Jirman , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 4/5] clk: sunxi-ng: a64: Add constraints on PLL-VIDEO0's n/m ratio In-reply-to: <13411739.uLZWGnKmhe@jernej-laptop> Date: Sun, 31 Dec 2023 10:10:40 +0100 Message-ID: <87jzoug2jz.fsf@oltmanns.dev> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231231_011057_727252_A99D2F59 X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDIwMjMtMTItMTkgYXQgMTc6NTQ6MTkgKzAxMDAsIEplcm5laiDFoGtyYWJlYyA8amVybmVq LnNrcmFiZWNAZ21haWwuY29tPiB3cm90ZToKPiBEbmUgcG9uZWRlbGplaywgMTguIGRlY2VtYmVy IDIwMjMgb2IgMTQ6MzU6MjIgQ0VUIGplIEZyYW5rIE9sdG1hbm5zIG5hcGlzYWwoYSk6Cj4+IFRo ZSBBbGx3aW5uZXIgQTY0IG1hbnVhbCBsaXN0cyB0aGUgZm9sbG93aW5nIGNvbnN0cmFpbnQgZm9y IHRoZQo+PiBQTEwtVklERU8wIGNsb2NrOiA4IDw9IE4vTSA8PSAyNQo+Pgo+PiBVc2UgdGhpcyBj b25zdHJhaW50Lgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBGcmFuayBPbHRtYW5ucyA8ZnJhbmtAb2x0 bWFubnMuZGV2Pgo+PiAtLS0KPj4gIGRyaXZlcnMvY2xrL3N1bnhpLW5nL2NjdS1zdW41MGktYTY0 LmMgfCA4ICsrKysrKy0tCj4+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAyIGRl bGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9jbGsvc3VueGktbmcvY2N1LXN1 bjUwaS1hNjQuYyBiL2RyaXZlcnMvY2xrL3N1bnhpLW5nL2NjdS1zdW41MGktYTY0LmMKPj4gaW5k ZXggYzAzNGFjMDI3ZDFjLi43NWQ4MzlkYTQ0NmMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvY2xr L3N1bnhpLW5nL2NjdS1zdW41MGktYTY0LmMKPj4gKysrIGIvZHJpdmVycy9jbGsvc3VueGktbmcv Y2N1LXN1bjUwaS1hNjQuYwo+PiBAQCAtNjgsNyArNjgsOCBAQCBzdGF0aWMgU1VOWElfQ0NVX05N X1dJVEhfU0RNX0dBVEVfTE9DSyhwbGxfYXVkaW9fYmFzZV9jbGssICJwbGwtYXVkaW8tYmFzZSIs Cj4+ICAJCQkJICAgICAgIEJJVCgyOCksCS8qIGxvY2sgKi8KPj4gIAkJCQkgICAgICAgQ0xLX1NF VF9SQVRFX1VOR0FURSk7Cj4+Cj4+IC1zdGF0aWMgU1VOWElfQ0NVX05NX1dJVEhfRlJBQ19HQVRF X0xPQ0tfTUlOX01BWF9DTE9TRVNUKHBsbF92aWRlbzBfY2xrLCAicGxsLXZpZGVvMCIsCj4+ICtz dGF0aWMgU1VOWElfQ0NVX05NX1dJVEhfRlJBQ19HQVRFX0xPQ0tfTUlOX01BWF9GRUFUX05NX1JB VElPKHBsbF92aWRlbzBfY2xrLAo+PiArCQkJCQkJInBsbC12aWRlbzAiLAo+PiAgCQkJCQkJIm9z YzI0TSIsIDB4MDEwLAo+PiAgCQkJCQkJMTkyMDAwMDAwLAkvKiBNaW5pbXVtIHJhdGUgKi8KPj4g IAkJCQkJCTEwMDgwMDAwMDAsCS8qIE1heGltdW0gcmF0ZSAqLwoKSSBqdXN0IHJlYWxpemVkIHRo YXQgYWRkaW5nIHRoZSB3aG9sZSByYXRpbyBsaW1pdHMgZm9yIGNjdV9ubSBpcwpzdXBlcmZsdW91 cyBhcyB5b3UgY291bGQganVzdCBhcyB3ZWxsIGV4cHJlc3MgdGhlbSBpbiBmb3Igb2YgYSBtaW5p bXVtCmFuZCBtYXhpbXVtIHJhbmdlOgpTaW5jZSA4IDw9IE4vTSA8PSAyNSBhbmQgcGFyZW50X3Jh dGUgPSAyNCBNSHosIHRoZXJlZm9yZQogIDE5MiBNSHogPD0gcmF0ZSA8PSA2MDAgTUh6LgoKVGhl c2UgYWJzb2x1dGUgbGltaXRzIGFyZSBhbHNvIGxpc3RlZCBpbiBBbGx3aW5uZXIncyBBNjQgbWFu dWFsLgoKQlVULCBoZXJlIHRoZSB1cHBlciBsaW1pdCB3YXMgcmFpc2VkIHRvIDEwMDggTUh6Ogo1 ZGUzOWFjYWYzNDYwNGJkMDQ4MzRmMDkyNDc5Y2Y0ZGNjOTQ2ZGQgImNsazogc3VueGktbmc6IGE2 NDogQWRkIG1heC4KcmF0ZSBjb25zdHJhaW50IHRvIHZpZGVvIFBMTCIKCldpdGggdGhpcyB1cHBl ciBsaW1pdCB0aGUgcmF0aW8gbGltaXRhdGlvbiBpcyBlZmZlY3RpdmVseToKOCA8PSBOL00gPD0g NDIKCkljZW5vd3kgWmhlbmcgKGFkZGVkIHRvIENDKSBoYWQgdGhlIHJlYXNvbmFibGUgZXhwbGFu YXRpb24gdGhhdCB0aGlzIHdhcwp1c2VkIGluIHRoZSBCU1Aga2VybmVsLCBzbyB3ZSBzaG91bGQg cHJvYmFibHkgc3RpY2sgdG8gdGhhdCBhbmQgZGl0Y2gKdGhlIHR3byBQTEwtVklERU8wIHJlbGF0 ZWQgcGF0Y2hlcy4gV2hhdCBhcmUgeW91ciB0aG91Z2h0cyBvbiB0aGF0PwoKPj4gQEAgLTgwLDcg KzgxLDEwIEBAIHN0YXRpYyBTVU5YSV9DQ1VfTk1fV0lUSF9GUkFDX0dBVEVfTE9DS19NSU5fTUFY X0NMT1NFU1QocGxsX3ZpZGVvMF9jbGssICJwbGwtdmlkCj4+ICAJCQkJCQkyOTcwMDAwMDAsCS8q IGZyYWMgcmF0ZSAxICovCj4+ICAJCQkJCQlCSVQoMzEpLAkvKiBnYXRlICovCj4+ICAJCQkJCQlC SVQoMjgpLAkvKiBsb2NrICovCj4+IC0JCQkJCQlDTEtfU0VUX1JBVEVfVU5HQVRFKTsKPj4gKwkJ CQkJCUNMS19TRVRfUkFURV9VTkdBVEUsCj4+ICsJCQkJCQlDQ1VfRkVBVFVSRV9GUkFDVElPTkFM IHwKPj4gKwkJCQkJCUNDVV9GRUFUVVJFX0NMT1NFU1RfUkFURSwKPgo+IEFib3ZlIGZsYWdzIGFy ZSB1bnJlbGF0ZWQgY2hhbmdlLCBwdXQgdGhlbSBpbiBuZXcgcGF0Y2ggaWYgbmVlZGVkLgo+Cj4g QmVzdCByZWdhcmRzLAo+IEplcm5lago+Cj4+ICsJCQkJCQk4LCAyNSk7CQkvKiBtaW4vbWF4IG5t IHJhdGlvICovCj4+Cj4+ICBzdGF0aWMgU1VOWElfQ0NVX05NX1dJVEhfRlJBQ19HQVRFX0xPQ0so cGxsX3ZlX2NsaywgInBsbC12ZSIsCj4+ICAJCQkJCSJvc2MyNE0iLCAweDAxOCwKPj4KPj4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 302BD320E for ; Sun, 31 Dec 2023 09:17:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oltmanns.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oltmanns.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oltmanns.dev header.i=@oltmanns.dev header.b="r1cTud9M" Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4T2td25K4fz9sc6; Sun, 31 Dec 2023 10:10:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oltmanns.dev; s=MBO0001; t=1704013846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hlVujKA1PeQa8EJSC4InM714qJCCxj/rjMUfrSS3bfw=; b=r1cTud9M3wVC9jFHCOg36Lt+//kfqLq90rmJ/bB54sN/mMd80lSOW/e5APEc8e/w0SQHOA W0XVmqtTOgXzFhNW+LB6KpSTy7ap6356EBmoXrVWGux9v5vjEG2RoJ/hu2YGK3E77g6u5H hDWGnAi69NcrqulMRrynDdB8jYN/OI8FBxgoIIGHHxGdY7hGIaLihyJjlBxqhHIaHpKmXd 9pRylo1kYGLy8et8nYpNN99xwKMpnaBllrmeZPUtQ3MDwi4dgrAzoIxCzTBSqia78qTUUM pPZSq2e2oYF0XhqMZAXNx60BHaU7OXdUljURCJUxhSHtGQM0Y4zjXUR+E3tNrw== References: <20231218-pinephone-pll-fixes-v1-0-e238b6ed6dc1@oltmanns.dev> <20231218-pinephone-pll-fixes-v1-4-e238b6ed6dc1@oltmanns.dev> <13411739.uLZWGnKmhe@jernej-laptop> From: Frank Oltmanns To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Michael Turquette , Stephen Boyd , Chen-Yu Tsai , Samuel Holland , Guido =?utf-8?Q?G=C3=BCnther?= , Purism Kernel Team , Ondrej Jirman , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 4/5] clk: sunxi-ng: a64: Add constraints on PLL-VIDEO0's n/m ratio In-reply-to: <13411739.uLZWGnKmhe@jernej-laptop> Date: Sun, 31 Dec 2023 10:10:40 +0100 Message-ID: <87jzoug2jz.fsf@oltmanns.dev> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2023-12-19 at 17:54:19 +0100, Jernej =C5=A0krabec wrote: > Dne ponedeljek, 18. december 2023 ob 14:35:22 CET je Frank Oltmanns napis= al(a): >> The Allwinner A64 manual lists the following constraint for the >> PLL-VIDEO0 clock: 8 <=3D N/M <=3D 25 >> >> Use this constraint. >> >> Signed-off-by: Frank Oltmanns >> --- >> drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c b/drivers/clk/sunxi-n= g/ccu-sun50i-a64.c >> index c034ac027d1c..75d839da446c 100644 >> --- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> @@ -68,7 +68,8 @@ static SUNXI_CCU_NM_WITH_SDM_GATE_LOCK(pll_audio_base_= clk, "pll-audio-base", >> BIT(28), /* lock */ >> CLK_SET_RATE_UNGATE); >> >> -static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST(pll_video0_clk,= "pll-video0", >> +static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_FEAT_NM_RATIO(pll_video= 0_clk, >> + "pll-video0", >> "osc24M", 0x010, >> 192000000, /* Minimum rate */ >> 1008000000, /* Maximum rate */ I just realized that adding the whole ratio limits for ccu_nm is superfluous as you could just as well express them in for of a minimum and maximum range: Since 8 <=3D N/M <=3D 25 and parent_rate =3D 24 MHz, therefore 192 MHz <=3D rate <=3D 600 MHz. These absolute limits are also listed in Allwinner's A64 manual. BUT, here the upper limit was raised to 1008 MHz: 5de39acaf34604bd04834f092479cf4dcc946dd "clk: sunxi-ng: a64: Add max. rate constraint to video PLL" With this upper limit the ratio limitation is effectively: 8 <=3D N/M <=3D 42 Icenowy Zheng (added to CC) had the reasonable explanation that this was used in the BSP kernel, so we should probably stick to that and ditch the two PLL-VIDEO0 related patches. What are your thoughts on that? >> @@ -80,7 +81,10 @@ static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSE= ST(pll_video0_clk, "pll-vid >> 297000000, /* frac rate 1 */ >> BIT(31), /* gate */ >> BIT(28), /* lock */ >> - CLK_SET_RATE_UNGATE); >> + CLK_SET_RATE_UNGATE, >> + CCU_FEATURE_FRACTIONAL | >> + CCU_FEATURE_CLOSEST_RATE, > > Above flags are unrelated change, put them in new patch if needed. > > Best regards, > Jernej > >> + 8, 25); /* min/max nm ratio */ >> >> static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK(pll_ve_clk, "pll-ve", >> "osc24M", 0x018, >> >>