From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8946C433F5 for ; Tue, 5 Apr 2022 21:40:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243024AbiDEVlk (ORCPT ); Tue, 5 Apr 2022 17:41:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1457612AbiDEQRJ (ORCPT ); Tue, 5 Apr 2022 12:17:09 -0400 Received: from ms.lwn.net (ms.lwn.net [IPv6:2600:3c01:e000:3a1::42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96CBB192B9; Tue, 5 Apr 2022 09:15:11 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:281:8300:35:2589:2a93:190d:b787]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id CDADA30D; Tue, 5 Apr 2022 16:15:10 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net CDADA30D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1649175311; bh=rE6rzCNpDJ68w+IwBoDN9Cf1DCDHPiYHstqLXZaFU7k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=J2Ns1jRSjvyM1mYJSL3V7kG1cTsmgZwyNrjCkiP+k84kUWO3JPqurBKy7zBAjPMyJ Ott5DZyA+QJyeTCEwJKDoMCcshoGoh8CwR/L1ba8KNK4xcW/aA6rXiBpefXdAMte3C PjftgljOkwDF4D29WR8nfffJwfRMAX70J4wLBLgJCLGM+1pb0HUTarmpcgm7YpWYgg Qw3nh1LZ831VdmtW6NcllXeV8I2RpC0CSezs5Hg20lPSITd6kIt6hVyMJ83Q7/8z+m h15UmZZLua6OFynX3VKxyUD5pRB4baQ3+uOlokTwt8cEc0XAdIs24491ouc5FZPpLR 1LExVsq2eG6ew== From: Jonathan Corbet To: Bagas Sanjaya , linux-doc@vger.kernel.org Cc: Bagas Sanjaya , "David S. Miller" , Andrew Morton , Greg Kroah-Hartman , Jens Axboe , "Rafael J. Wysocki" , Anshuman Khandual , Pasha Tatashin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Documentation: arch_pgtable_helpers: demote pgtable list headings In-Reply-To: <20220326131313.691027-1-bagasdotme@gmail.com> References: <20220326131313.691027-1-bagasdotme@gmail.com> Date: Tue, 05 Apr 2022 10:15:10 -0600 Message-ID: <87k0c3ecc1.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bagas Sanjaya writes: > Demote pgtable list headings from title heading to chapter heading. This is a classic example of the sort of changelog that says *what* the patch does (which we can also see from the patch itself) but not *why*. Why do these headings need to be changed? Thanks, jon > Cc: Jonathan Corbet > Cc: "David S. Miller" > Cc: Andrew Morton > Cc: Greg Kroah-Hartman > Cc: Jens Axboe > Cc: "Rafael J. Wysocki" > Cc: Anshuman Khandual > Cc: Pasha Tatashin > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Bagas Sanjaya > --- > Documentation/vm/arch_pgtable_helpers.rst | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Documentation/vm/arch_pgtable_helpers.rst b/Documentation/vm/arch_pgtable_helpers.rst > index f8b225fc919047..cbaee9e592410f 100644 > --- a/Documentation/vm/arch_pgtable_helpers.rst > +++ b/Documentation/vm/arch_pgtable_helpers.rst > @@ -13,7 +13,7 @@ Following tables describe the expected semantics which can also be tested during > boot via CONFIG_DEBUG_VM_PGTABLE option. All future changes in here or the debug > test need to be in sync. > > -====================== > + > PTE Page Table Helpers > ====================== > > @@ -79,7 +79,7 @@ PTE Page Table Helpers > | ptep_set_access_flags | Converts into a more permissive PTE | > +---------------------------+--------------------------------------------------+ > > -====================== > + > PMD Page Table Helpers > ====================== > > @@ -153,7 +153,7 @@ PMD Page Table Helpers > | pmdp_set_access_flags | Converts into a more permissive PMD | > +---------------------------+--------------------------------------------------+ > > -====================== > + > PUD Page Table Helpers > ====================== > > @@ -209,7 +209,7 @@ PUD Page Table Helpers > | pudp_set_access_flags | Converts into a more permissive PUD | > +---------------------------+--------------------------------------------------+ > > -========================== > + > HugeTLB Page Table Helpers > ========================== > > @@ -235,7 +235,7 @@ HugeTLB Page Table Helpers > | huge_ptep_set_access_flags | Converts into a more permissive HugeTLB | > +---------------------------+--------------------------------------------------+ > > -======================== > + > SWAP Page Table Helpers > ======================== > > > base-commit: f443e374ae131c168a065ea1748feac6b2e76613 > -- > An old man doll... just what I always wanted! - Clara