All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Huang, Ying" <ying.huang@intel.com>
To: cgel.zte@gmail.com
Cc: akpm@linux-foundation.org, yang.shi@linux.alibaba.com,
	dave.hansen@linux.intel.com, yang.yang29@zte.com.cn,
	minchan@kernel.org, saravanand@fb.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/vmstat: add events for THP max_ptes_* exceeds
Date: Mon, 27 Dec 2021 11:19:32 +0800	[thread overview]
Message-ID: <87k0fq7n0b.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <20211225094036.574157-1-yang.yang29@zte.com.cn> (cgel zte's message of "Sat, 25 Dec 2021 09:40:37 +0000")

cgel.zte@gmail.com writes:

> From: Yang Yang <yang.yang29@zte.com.cn>
>
> There are interfaces to adjust max_ptes_none, max_ptes_swap,
> max_ptes_shared values, see
> /sys/kernel/mm/transparent_hugepage/khugepaged/.
>
> But system administrator maynot know which value is the best. So
> Add those events to support adjusting max_ptes_* to suitable values.
>
> For example, if default max_ptes_swap value causes too much failures,
> and system uses zram whose IO is fast, administrator could increase
> max_ptes_swap until THP_SCAN_EXCEED_SWAP_PTE not increase anymore.
>
> Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
> ---
>  include/linux/vm_event_item.h | 3 +++
>  mm/khugepaged.c               | 7 +++++++
>  mm/vmstat.c                   | 3 +++
>  3 files changed, 13 insertions(+)
>
> diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h
> index a185cc75ff52..7b2363388bfa 100644
> --- a/include/linux/vm_event_item.h
> +++ b/include/linux/vm_event_item.h
> @@ -98,6 +98,9 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT,
>  		THP_SPLIT_PAGE_FAILED,
>  		THP_DEFERRED_SPLIT_PAGE,
>  		THP_SPLIT_PMD,
> +		THP_SCAN_EXCEED_NONE_PTE,
> +		THP_SCAN_EXCEED_SWAP_PTE,
> +		THP_SCAN_EXCEED_SHARED_PTE,

"SCAN" appears too general, how about

  THP_COLLAPSE_EXCEED_SWAP_PTE

?

Best Regards,
Huang, Ying

[snip]

  reply	other threads:[~2021-12-27  3:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-25  9:40 [PATCH] mm/vmstat: add events for THP max_ptes_* exceeds cgel.zte
2021-12-27  3:19 ` Huang, Ying [this message]
2021-12-27  3:59   ` CGEL

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0fq7n0b.fsf@yhuang6-desk2.ccr.corp.intel.com \
    --to=ying.huang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgel.zte@gmail.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=saravanand@fb.com \
    --cc=yang.shi@linux.alibaba.com \
    --cc=yang.yang29@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.