From: Richard Palethorpe <rpalethorpe@suse.de>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 5/7] docparse: Add type normalization
Date: Tue, 02 Nov 2021 11:52:34 +0000 [thread overview]
Message-ID: <87k0hqojm3.fsf@suse.de> (raw)
In-Reply-To: <20211101145342.7166-6-chrubis@suse.cz>
Hello,
Cyril Hrubis <chrubis@suse.cz> writes:
> For now just for .test_variants.
>
> There are two reasons for this:
>
> - This code makes sure that we get right value parsed and aborts the
> compilation if the parser got confused. This part is important since
> if the testrunners are going to use the metadata the data in there
> must be correct.
I can't resist saying this would likely be solved by Sparse and its
understanding of C types. However in the present context it makes
perfect sense.
>
> - And much less important it makes the resulting json nicer to read
>
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
Reviewed-by: rpalethorpe@suse.com
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-11-02 11:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 14:53 [LTP] [PATCH v2 0/7] docparse improvements Cyril Hrubis
2021-11-01 14:53 ` [LTP] [PATCH v2 1/7] docparse: Implement #define and #include Cyril Hrubis
2021-11-02 10:05 ` Richard Palethorpe
2021-11-02 11:21 ` Cyril Hrubis
2021-11-02 14:54 ` Petr Vorel
2021-11-02 15:10 ` Cyril Hrubis
2021-11-02 15:38 ` Petr Vorel
2021-11-03 9:08 ` Richard Palethorpe
2021-11-01 14:53 ` [LTP] [PATCH v2 2/7] docparse: Add tests Cyril Hrubis
2021-11-02 11:09 ` Richard Palethorpe
2021-11-01 14:53 ` [LTP] [PATCH v2 3/7] docparse: data_storage: Add integer type node Cyril Hrubis
2021-11-02 11:14 ` Richard Palethorpe
2021-11-01 14:53 ` [LTP] [PATCH v2 4/7] docparse: Implement ARRAY_SIZE() Cyril Hrubis
2021-11-02 11:39 ` Richard Palethorpe
2021-11-02 12:07 ` Cyril Hrubis
2021-11-01 14:53 ` [LTP] [PATCH v2 5/7] docparse: Add type normalization Cyril Hrubis
2021-11-02 11:52 ` Richard Palethorpe [this message]
2021-11-02 12:06 ` Cyril Hrubis
2021-11-01 14:53 ` [LTP] [PATCH v2 6/7] docparse: Group data to 'testsuite' and 'defaults' Cyril Hrubis
2021-11-01 14:53 ` [LTP] [PATCH v2 7/7] docparse: Split into metadata and docparse Cyril Hrubis
2021-11-01 15:14 ` Cyril Hrubis
2021-11-02 15:22 ` Petr Vorel
2021-11-02 15:28 ` Cyril Hrubis
2021-11-02 15:39 ` Petr Vorel
2021-11-02 16:04 ` Cyril Hrubis
2021-11-03 11:39 ` Cyril Hrubis
2021-11-01 14:55 ` [LTP] [PATCH v2 0/7] docparse improvements Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0hqojm3.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.