From: Jani Nikula <jani.nikula@intel.com>
To: Dave Airlie <airlied@gmail.com>, intel-gfx@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com, Dave Airlie <airlied@redhat.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix regression with uncore refactoring.
Date: Mon, 04 Oct 2021 10:44:57 +0300 [thread overview]
Message-ID: <87k0it2pza.fsf@intel.com> (raw)
In-Reply-To: <20211004003133.2279446-1-airlied@gmail.com>
On Mon, 04 Oct 2021, Dave Airlie <airlied@gmail.com> wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> This was causing infinite recursion on snb/ivb.
>
> Fixes: 5716c8c6f4b6 ("drm/i915/uncore: split the fw get function into separate vfunc")
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> ---
> drivers/gpu/drm/i915/intel_uncore.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index 2dac69d92c1b..f1b816ebcdf6 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -346,7 +346,7 @@ static void __gen6_gt_wait_for_thread_c0(struct intel_uncore *uncore)
> static void fw_domains_get_with_thread_status(struct intel_uncore *uncore,
> enum forcewake_domains fw_domains)
> {
> - fw_domains_get(uncore, fw_domains);
> + fw_domains_get_normal(uncore, fw_domains);
Pushed, thanks for the patch.
BR,
Jani.
>
> /* WaRsForcewakeWaitTC0:snb,ivb,hsw,bdw,vlv */
> __gen6_gt_wait_for_thread_c0(uncore);
--
Jani Nikula, Intel Open Source Graphics Center
prev parent reply other threads:[~2021-10-04 7:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 0:31 [Intel-gfx] [PATCH] drm/i915: fix regression with uncore refactoring Dave Airlie
2021-10-04 1:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-10-04 2:23 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-04 7:44 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0it2pza.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.