From: Felipe Balbi <balbi@kernel.org>
To: Li Jun <jun.li@nxp.com>
Cc: gregkh@linuxfoundation.org, Thinh.Nguyen@synopsys.com,
chenyu56@huawei.com, john.stultz@linaro.org,
linux-usb@vger.kernel.org, faqiang.zhu@nxp.com,
linux-imx@nxp.com, kishon@ti.com
Subject: Re: [PATCH] usb: dwc3: core: balance phy init and exit
Date: Thu, 09 Sep 2021 08:12:35 +0300 [thread overview]
Message-ID: <87k0jqba8s.fsf@kernel.org> (raw)
In-Reply-To: <1631068099-13559-1-git-send-email-jun.li@nxp.com>
Hi,
Li Jun <jun.li@nxp.com> writes:
> After we start to do core soft reset while usb role switch,
> the phy init is invoked at every switch to device mode, but
> its counter part de-init is missing, this causes the actual
> phy init can not be done when we really want to re-init phy
> like system resume, because the counter maintained by phy
> core is not 0. considering phy init is actually redundant for
> role switch, so move out the phy init from core soft reset to
> dwc3 core init where is the only place required.
>
> Fixes: f88359e1588b ("usb: dwc3: core: Do core softreset when switch mode")
> Cc: <stable@vger.kernel.org>
> Tested-by: faqiang.zhu <faqiang.zhu@nxp.com>
> Signed-off-by: Li Jun <jun.li@nxp.com>
we need a few more Tested-bys, but patch looks good:
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
prev parent reply other threads:[~2021-09-09 5:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 2:28 [PATCH] usb: dwc3: core: balance phy init and exit Li Jun
2021-09-09 2:08 ` John Stultz
2021-09-09 5:12 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0jqba8s.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=chenyu56@huawei.com \
--cc=faqiang.zhu@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=jun.li@nxp.com \
--cc=kishon@ti.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.