From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43679C63799 for ; Thu, 22 Jul 2021 10:09:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 296D261241 for ; Thu, 22 Jul 2021 10:09:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230479AbhGVJ2V convert rfc822-to-8bit (ORCPT ); Thu, 22 Jul 2021 05:28:21 -0400 Received: from guitar.tcltek.co.il ([192.115.133.116]:39339 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230365AbhGVJ2U (ORCPT ); Thu, 22 Jul 2021 05:28:20 -0400 Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 5C872440E85; Thu, 22 Jul 2021 13:08:38 +0300 (IDT) References: <1173e7b0b58730fd187871d9e14a02cab85158cc.1626176145.git.baruch@tkos.co.il> <20210714201839.kfyqcyvowekc4ejs@pengutronix.de> <87eebyst5z.fsf@tarshish> <20210716070427.kv7w6imp2zoxhyz5@pengutronix.de> User-agent: mu4e 1.4.15; emacs 27.1 From: Baruch Siach To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Rob Herring , Bjorn Andersson , Kathiravan T , Thierry Reding , kernel@pengutronix.de, Robert Marko , Lee Jones , linux-arm-kernel@lists.infradead.org, Balaji Prakash J Subject: Re: [PATCH v5 2/4] pwm: driver for qualcomm ipq6018 pwm block In-reply-to: <20210716070427.kv7w6imp2zoxhyz5@pengutronix.de> Date: Thu, 22 Jul 2021 13:08:47 +0300 Message-ID: <87k0lizmmo.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Uwe, On Fri, Jul 16 2021, Uwe Kleine-König wrote: > On Fri, Jul 16, 2021 at 08:51:20AM +0300, Baruch Siach wrote: >> On Wed, Jul 14 2021, Uwe Kleine-König wrote: >> > On Tue, Jul 13, 2021 at 02:35:43PM +0300, Baruch Siach wrote: >> >> + val = FIELD_PREP(IPQ_PWM_REG0_HI_DURATION, hi_dur) | >> >> + FIELD_PREP(IPQ_PWM_REG0_PWM_DIV, pwm_div); >> >> + ipq_pwm_reg_write(pwm, IPQ_PWM_CFG_REG0, val); >> >> + >> >> + val = FIELD_PREP(IPQ_PWM_REG1_PRE_DIV, pre_div); >> >> + ipq_pwm_reg_write(pwm, IPQ_PWM_CFG_REG1, val); >> >> + >> >> + /* Enable needs a separate write to REG1 */ >> >> + val |= IPQ_PWM_REG1_UPDATE; >> > >> > Setting this bit results in the two writes above being configured >> > atomically so that no mixed settings happen to the output, right? >> >> I guess so. I have no access to hardware documentation, mind you. I >> first tried to do only one write to REG1, but it had no effect. The >> existence of the UPDATE bit also indicates that hardware works as you >> suggest. > > I wouldn't trust HW documentation here. If you have some means to > inspect the waveform this is easy to test. Depending on how long you can > make the periods an LED is enough. If you start with a slower parent > clk, a big pre_div and hi_dur = 0 the LED is supposed to be off. Then > set hi_dur = pwm_div/2 which either make the LED blink slowly or keeps > off. Then setting pre_div = 2 either increased the blink frequency or it > doesn't. ... I currently have only access to DVM to measure the PWM effect. I'll try to do more measures when I have access to better equipment. baruch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17BDCC6377D for ; Thu, 22 Jul 2021 10:14:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D36306023D for ; Thu, 22 Jul 2021 10:14:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D36306023D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tkos.co.il Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:Cc:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=H1Yq65bdUey+05nTfvoUbZqcf4DK71RdoyNgQprK2pw=; b=qG2GtGI6SpXfdba9bUnf5GBkf8 4RKcmTlSZUdzYVUW8SN47zbIJpKU+tP0idZU6Ab244GGs3ogvpi+VlNTzOxAPloTat3Q3Ca5uVKqu e9dvPCSyAPgs/UL5SRzEueoZECFNhNMDCBYO2W0r1lOGJFWMPK0+ar/GKM9jPAWuosMe4Bxor5IZ9 +951fxnVTQHO5Pjra4bx333z30HK5ELh4m8GmKwIeVV8NZ2w7jIW1EYD5NckxCbCKOUsQQUEyX2D+ R094h2oRoDgiAzabgLrTKP3YLLADpRDHk8F/K+RsnrddtQLhRGFDAk6u+2VN+V4FZ2cgGlVKcWy0t 1DVgdEHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6Vgi-0019K2-1y; Thu, 22 Jul 2021 10:12:20 +0000 Received: from guitar.tcltek.co.il ([192.115.133.116] helo=mx.tkos.co.il) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6VdK-0017zO-5V for linux-arm-kernel@lists.infradead.org; Thu, 22 Jul 2021 10:08:51 +0000 Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 5C872440E85; Thu, 22 Jul 2021 13:08:38 +0300 (IDT) References: <1173e7b0b58730fd187871d9e14a02cab85158cc.1626176145.git.baruch@tkos.co.il> <20210714201839.kfyqcyvowekc4ejs@pengutronix.de> <87eebyst5z.fsf@tarshish> <20210716070427.kv7w6imp2zoxhyz5@pengutronix.de> User-agent: mu4e 1.4.15; emacs 27.1 From: Baruch Siach To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Rob Herring , Bjorn Andersson , Kathiravan T , Thierry Reding , kernel@pengutronix.de, Robert Marko , Lee Jones , linux-arm-kernel@lists.infradead.org, Balaji Prakash J Subject: Re: [PATCH v5 2/4] pwm: driver for qualcomm ipq6018 pwm block In-reply-to: <20210716070427.kv7w6imp2zoxhyz5@pengutronix.de> Date: Thu, 22 Jul 2021 13:08:47 +0300 Message-ID: <87k0lizmmo.fsf@tarshish> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210722_030850_535158_CB81FD3D X-CRM114-Status: GOOD ( 20.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVXdlLAoKT24gRnJpLCBKdWwgMTYgMjAyMSwgVXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6Cj4g T24gRnJpLCBKdWwgMTYsIDIwMjEgYXQgMDg6NTE6MjBBTSArMDMwMCwgQmFydWNoIFNpYWNoIHdy b3RlOgo+PiBPbiBXZWQsIEp1bCAxNCAyMDIxLCBVd2UgS2xlaW5lLUvDtm5pZyB3cm90ZToKPj4g PiBPbiBUdWUsIEp1bCAxMywgMjAyMSBhdCAwMjozNTo0M1BNICswMzAwLCBCYXJ1Y2ggU2lhY2gg d3JvdGU6Cj4+ID4+ICsJdmFsID0gRklFTERfUFJFUChJUFFfUFdNX1JFRzBfSElfRFVSQVRJT04s IGhpX2R1cikgfAo+PiA+PiArCQlGSUVMRF9QUkVQKElQUV9QV01fUkVHMF9QV01fRElWLCBwd21f ZGl2KTsKPj4gPj4gKwlpcHFfcHdtX3JlZ193cml0ZShwd20sIElQUV9QV01fQ0ZHX1JFRzAsIHZh bCk7Cj4+ID4+ICsKPj4gPj4gKwl2YWwgPSBGSUVMRF9QUkVQKElQUV9QV01fUkVHMV9QUkVfRElW LCBwcmVfZGl2KTsKPj4gPj4gKwlpcHFfcHdtX3JlZ193cml0ZShwd20sIElQUV9QV01fQ0ZHX1JF RzEsIHZhbCk7Cj4+ID4+ICsKPj4gPj4gKwkvKiBFbmFibGUgbmVlZHMgYSBzZXBhcmF0ZSB3cml0 ZSB0byBSRUcxICovCj4+ID4+ICsJdmFsIHw9IElQUV9QV01fUkVHMV9VUERBVEU7Cj4+ID4KPj4g PiBTZXR0aW5nIHRoaXMgYml0IHJlc3VsdHMgaW4gdGhlIHR3byB3cml0ZXMgYWJvdmUgYmVpbmcg Y29uZmlndXJlZAo+PiA+IGF0b21pY2FsbHkgc28gdGhhdCBubyBtaXhlZCBzZXR0aW5ncyBoYXBw ZW4gdG8gdGhlIG91dHB1dCwgcmlnaHQ/Cj4+IAo+PiBJIGd1ZXNzIHNvLiBJIGhhdmUgbm8gYWNj ZXNzIHRvIGhhcmR3YXJlIGRvY3VtZW50YXRpb24sIG1pbmQgeW91LiBJCj4+IGZpcnN0IHRyaWVk IHRvIGRvIG9ubHkgb25lIHdyaXRlIHRvIFJFRzEsIGJ1dCBpdCBoYWQgbm8gZWZmZWN0LiBUaGUK Pj4gZXhpc3RlbmNlIG9mIHRoZSBVUERBVEUgYml0IGFsc28gaW5kaWNhdGVzIHRoYXQgaGFyZHdh cmUgd29ya3MgYXMgeW91Cj4+IHN1Z2dlc3QuCj4KPiBJIHdvdWxkbid0IHRydXN0IEhXIGRvY3Vt ZW50YXRpb24gaGVyZS4gSWYgeW91IGhhdmUgc29tZSBtZWFucyB0bwo+IGluc3BlY3QgdGhlIHdh dmVmb3JtIHRoaXMgaXMgZWFzeSB0byB0ZXN0LiBEZXBlbmRpbmcgb24gaG93IGxvbmcgeW91IGNh bgo+IG1ha2UgdGhlIHBlcmlvZHMgYW4gTEVEIGlzIGVub3VnaC4gSWYgeW91IHN0YXJ0IHdpdGgg YSBzbG93ZXIgcGFyZW50Cj4gY2xrLCBhIGJpZyBwcmVfZGl2IGFuZCBoaV9kdXIgPSAwIHRoZSBM RUQgaXMgc3VwcG9zZWQgdG8gYmUgb2ZmLiBUaGVuCj4gc2V0IGhpX2R1ciA9IHB3bV9kaXYvMiB3 aGljaCBlaXRoZXIgbWFrZSB0aGUgTEVEIGJsaW5rIHNsb3dseSBvciBrZWVwcwo+IG9mZi4gVGhl biBzZXR0aW5nIHByZV9kaXYgPSAyIGVpdGhlciBpbmNyZWFzZWQgdGhlIGJsaW5rIGZyZXF1ZW5j eSBvciBpdAo+IGRvZXNuJ3QuIC4uLgoKSSBjdXJyZW50bHkgaGF2ZSBvbmx5IGFjY2VzcyB0byBE Vk0gdG8gbWVhc3VyZSB0aGUgUFdNIGVmZmVjdC4gSSdsbCB0cnkKdG8gZG8gbW9yZSBtZWFzdXJl cyB3aGVuIEkgaGF2ZSBhY2Nlc3MgdG8gYmV0dGVyIGVxdWlwbWVudC4KCmJhcnVjaAoKLS0gCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfi4gLn4g ICBUayBPcGVuIFN5c3RlbXMKPX0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS1vb08tLVUtLU9vby0tLS0tLS0tLS0tLXs9CiAgIC0gYmFydWNoQHRrb3MuY28u aWwgLSB0ZWw6ICs5NzIuNTIuMzY4LjQ2NTYsIGh0dHA6Ly93d3cudGtvcy5jby5pbCAtCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==