All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: 414777006@qq.com
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
	Mengguang Peng <pengmengguang@phytium.com.cn>
Subject: Re: [PATCH] irqchip: fixed S3 could not resume after suspend
Date: Fri, 09 Apr 2021 11:38:11 +0100	[thread overview]
Message-ID: <87k0pboi98.wl-maz@kernel.org> (raw)
In-Reply-To: <tencent_7DFDDF87297476D86084241FE91E1E9D950A@qq.com>

On Fri, 09 Apr 2021 11:10:09 +0100,
414777006@qq.com wrote:
> 
> From: Mengguang Peng <pengmengguang@phytium.com.cn>
> 
> On arm64 platform, found that the machine could not wake up after suspend,
> this patch updates the its suspend and resume handling code.
> 
> - Add a variable named ctlr_save in struct rdists.
> - When suspend, save the value of GICR_CTLR to memmory
> 	in its_save_disable().
> - When resume, write the value of memory saved to GICR_CTLR
> 	in its_restore_enable().

This really is the kind of things that must be handled by firmware.
How comes yours doesn't handle it?

That is what you should be fixing. See the ATF code for a (working)
reference implementation

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

           reply	other threads:[~2021-04-09 10:38 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <tencent_7DFDDF87297476D86084241FE91E1E9D950A@qq.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0pboi98.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=414777006@qq.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pengmengguang@phytium.com.cn \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.