From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB2EEC2BA2B for ; Mon, 6 Apr 2020 23:28:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A41720753 for ; Mon, 6 Apr 2020 23:28:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726420AbgDFX2d (ORCPT ); Mon, 6 Apr 2020 19:28:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:38892 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726254AbgDFX2d (ORCPT ); Mon, 6 Apr 2020 19:28:33 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 7F455ABEA; Mon, 6 Apr 2020 23:28:30 +0000 (UTC) From: NeilBrown To: Jan Kara Date: Tue, 07 Apr 2020 09:28:19 +1000 Cc: Christoph Hellwig , Trond Myklebust , "Anna.Schumaker\@Netapp.com" , Andrew Morton , Jan Kara , linux-mm@kvack.org, linux-nfs@vger.kernel.org, LKML Subject: Re: [PATCH 2/2 - v2] MM: Discard NR_UNSTABLE_NFS, use NR_WRITEBACK instead. In-Reply-To: <20200403094220.GA29920@quack2.suse.cz> References: <87tv2b7q72.fsf@notabene.neil.brown.name> <87v9miydai.fsf@notabene.neil.brown.name> <87sghmyd8v.fsf@notabene.neil.brown.name> <87pncqyd7k.fsf@notabene.neil.brown.name> <20200402151009.GA14130@infradead.org> <87h7y1y0ra.fsf@notabene.neil.brown.name> <20200403094220.GA29920@quack2.suse.cz> Message-ID: <87k12sw5ws.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain On Fri, Apr 03 2020, Jan Kara wrote: > > So I don't think we can just remove lines from procfs files like this. That > has a high potential of breaking some userspace app that is not careful > enough when parsing the file. So I think that we need to leave there the > format string and just replace K(node_page_state(pgdat, NR_UNSTABLE_NFS)) > with 0. OK. I assume changing the static trace points isn't a problem though? Thanks, NeilBrown --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEG8Yp69OQ2HB7X0l6Oeye3VZigbkFAl6LuxQACgkQOeye3VZi gbnfBQ//YmR4QcCtxB8I35791ntzSvFx751DsikAAi8zGSqNKdH1bEf5602n4pAE b4aMLG9qPDPGYpAYwae65k2Rg+JHbiPJC8gzpcisA9BMQnmH1Yj3z4t0tYoxR+7z 1t/KpJftRVscqSsYhWkzG0Qmo7zveFKcuKh238HAIGC6afP05ZS16SDAcg6O4D7S EntFueWyu4kKBgnwPvciVoMTHHEpijIOX84eRB1sz6I33e1/TuX88y+uTdKNGjzZ rBdNxX5J0GMdARgKKCdkg4wunAqordQOZGkAM0cGCeTxR0IEuyWbIK4DT03jzrTQ asy/NjfBCMXQEpbeBMZncT3Mtd1m1rfOt3CnrnwmvCjIuJPdcFQvUeQirOYepwm5 r3qd/rYzdFqqlijeYNNEuwaJZb7+jK5HVcPXkxwJ5meSb03S2zKeI2j5I44AmDXd TNOqZzRzp1WAeQrE7RhN1zMez2mBwV6TK426bPe50wTsXdj4pBfJhGNUiCcdbrkl 7+zJb+HW5LP6QFl+QYfxUtqWhIKduwIvQsuqmu7UCHegHclqeYSPxEdI8ai1atHQ lpFBcVZv3rNkS/pEC6CJ6Aig9hObJpR0A29xSvD1IOlIRuwDwfzKYwA7+HfF16ci VjtstzOpFoAdyHp1fttsztwQiYl3GtTrcSTVXjVFv45AlA9e1Pg= =qYtq -----END PGP SIGNATURE----- --=-=-=--