From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BFE1CA9ED0 for ; Tue, 5 Nov 2019 05:36:49 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7BDF206BA for ; Tue, 5 Nov 2019 05:36:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="YFJJZjfp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7BDF206BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E77CD170A; Tue, 5 Nov 2019 06:35:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E77CD170A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572932207; bh=7Kx0hjoFBh/umBEwtpqdsD1QLXE9KGMQ/KR2awGBHp0=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YFJJZjfpuw/TeD8jJzgLdko/GzxTuEl4TV+1EmcavVNuqqUwwZ5IIcCkBxY8rsNFM WVgCTl3jRDqRrsri5QlHWuo97cTF4jsCSUUDtx/ZjrA3MZORljHW/KjwCV9vIKbASw 85vWKOI2hLjP8re8vdi5gfCeEnzW2YU+SxERoATw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 56A97F80446; Tue, 5 Nov 2019 06:35:56 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 15940F8049B; Tue, 5 Nov 2019 06:35:54 +0100 (CET) Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by alsa1.perex.cz (Postfix) with ESMTP id 931B0F8015B for ; Tue, 5 Nov 2019 06:35:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 931B0F8015B Date: 05 Nov 2019 14:35:44 +0900 X-IronPort-AV: E=Sophos;i="5.68,270,1569250800"; d="scan'208";a="30850045" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie5.idc.renesas.com with ESMTP; 05 Nov 2019 14:35:44 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id DF28B4185573; Tue, 5 Nov 2019 14:35:44 +0900 (JST) Message-ID: <87k18e3mxb.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: "Sridharan, Ranjani" In-Reply-To: References: <874kzrdo1x.wl-kuninori.morimoto.gx@renesas.com> <87zhhjc9bw.wl-kuninori.morimoto.gx@renesas.com> <9aacec2b81bbe51992da63ea33ab653019011371.camel@linux.intel.com> <87o8xr2bwc.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Cc: Linux-ALSA , Mark Brown , Ranjani Sridharan Subject: Re: [alsa-devel] [PATCH v2 resend 03/18] ASoC: soc-core: tidyup soc_init_dai_link() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Sridharan Thank you for your review > > > +static int soc_dai_link_sanity_check(struct snd_soc_card *card, > > > + struct snd_soc_dai_link *link) > > > { > > > int i; > > > struct snd_soc_dai_link_component *codec, *platform; > > > @@ -1043,11 +1043,15 @@ static int soc_bind_dai_link(struct > > > snd_soc_card *card, > > > struct snd_soc_pcm_runtime *rtd; > > > struct snd_soc_dai_link_component *codec, *platform; > > > struct snd_soc_component *component; > > > - int i; > > > + int i, ret; > > > > > > if (dai_link->ignore) > > > return 0; > > > > > > + ret = soc_dai_link_sanity_check(card, dai_link); > > > + if (ret < 0) > > > + return ret; > > Morimoto-san, > > > > Should this be done after checking if soc_is_dai_link_bound() maybe? > > Morimoto-san, > > I thought about this a bit more. With you changes in the series to move bind_dai_link() to snd_soc_add_dai(), is the check > for soc_is_dai_link_bound() needed at all? soc_is_dai_link_bound() is no longer needed. It will be removed in my *next* patch-set. Is this clear answer for you ? Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel