From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D231C31E5B for ; Mon, 17 Jun 2019 18:02:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 403AC20863 for ; Mon, 17 Jun 2019 18:02:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727990AbfFQSCx (ORCPT ); Mon, 17 Jun 2019 14:02:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50144 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726047AbfFQSCw (ORCPT ); Mon, 17 Jun 2019 14:02:52 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CC29781DFE; Mon, 17 Jun 2019 18:02:46 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-116-59.ams2.redhat.com [10.36.116.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D96978401; Mon, 17 Jun 2019 18:02:41 +0000 (UTC) From: Florian Weimer To: Linus Torvalds Cc: Joseph Myers , Arnd Bergmann , Linux API , linux-arch , Netdev , Laura Abbott , Paul Burton , Deepa Dinamani , Linux List Kernel Mailing Subject: Re: [PATCH] uapi: avoid namespace conflict in linux/posix_types.h References: <20190319165123.3967889-1-arnd@arndb.de> <87tvd2j9ye.fsf@oldenburg2.str.redhat.com> <871s05fd8o.fsf@oldenburg2.str.redhat.com> <87sgs8igfj.fsf@oldenburg2.str.redhat.com> Date: Mon, 17 Jun 2019 20:02:39 +0200 In-Reply-To: (Linus Torvalds's message of "Mon, 17 Jun 2019 10:49:44 -0700") Message-ID: <87k1dkdr9c.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 17 Jun 2019 18:02:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Linus Torvalds: >> A different approach would rename to something more >> basic, exclude the two structs, and move all internal #includes which do >> need the structs to the new header. > > In fact, I wouldn't even rename at all, I'd just make > sure it's namespace-clean. > > I _think_ the only thing causing problems is '__kernel_fsid_t' due to > that "val[]" thing, so just remove ity entirely, and add it to > instead. There's also __kernel_fd_set in . I may have lumped this up with , but it has the same problem. If it's okay to move them both to more natural places (maybe and ), I think that should work well for glibc. However, application code may have to include additional header files. I think the GCC/LLVM sanitizers currently get __kernel_fd_set from (but I think we discussed it before, they really shouldn't use this type because it's misleading). Thanks, Florian