From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D72B0C43381 for ; Thu, 14 Mar 2019 18:48:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA9E6217F5 for ; Thu, 14 Mar 2019 18:48:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727323AbfCNSr7 (ORCPT ); Thu, 14 Mar 2019 14:47:59 -0400 Received: from albireo.enyo.de ([5.158.152.32]:45402 "EHLO albireo.enyo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727034AbfCNSr6 (ORCPT ); Thu, 14 Mar 2019 14:47:58 -0400 X-Greylist: delayed 389 seconds by postgrey-1.27 at vger.kernel.org; Thu, 14 Mar 2019 14:47:56 EDT Received: from [172.17.203.2] (helo=deneb.enyo.de) by albireo.enyo.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1h4VIA-0001U3-5A; Thu, 14 Mar 2019 18:41:22 +0000 Received: from fw by deneb.enyo.de with local (Exim 4.89) (envelope-from ) id 1h4VEB-0006rP-Rh; Thu, 14 Mar 2019 19:37:15 +0100 From: Florian Weimer To: Arnd Bergmann Cc: "David S . Miller" , Deepa Dinamani , Willem de Bruijn , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, Laura Abbott , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH] y2038: fix socket.h header inclusion References: <20190311153857.563743-1-arnd@arndb.de> Date: Thu, 14 Mar 2019 19:37:15 +0100 In-Reply-To: <20190311153857.563743-1-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 11 Mar 2019 16:38:17 +0100") Message-ID: <87k1h1fgkk.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org * Arnd Bergmann: > diff --git a/arch/alpha/include/uapi/asm/socket.h b/arch/alpha/include/uapi/asm/socket.h > index 0d0fddb7e738..976e89b116e5 100644 > --- a/arch/alpha/include/uapi/asm/socket.h > +++ b/arch/alpha/include/uapi/asm/socket.h > @@ -2,8 +2,8 @@ > #ifndef _UAPI_ASM_SOCKET_H > #define _UAPI_ASM_SOCKET_H > > +#include > #include > -#include This breaks POSIX conformance in glibc because the header is not namespace clean. It contains the identifiers fds_bits and val: unsigned long fds_bits[__FD_SETSIZE / (8 * sizeof(long))]; int val[2]; We could duplicate some of the SO_* constants for POSIX mode in glibc, but it would be nice to avoid that. Is there a different way of fixing this on the kernel side that avoids including ? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Weimer Date: Thu, 14 Mar 2019 18:37:15 +0000 Subject: Re: [PATCH] y2038: fix socket.h header inclusion Message-Id: <87k1h1fgkk.fsf@mid.deneb.enyo.de> List-Id: References: <20190311153857.563743-1-arnd@arndb.de> In-Reply-To: <20190311153857.563743-1-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 11 Mar 2019 16:38:17 +0100") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnd Bergmann Cc: "David S . Miller" , Deepa Dinamani , Willem de Bruijn , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, Laura Abbott , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org * Arnd Bergmann: > diff --git a/arch/alpha/include/uapi/asm/socket.h b/arch/alpha/include/uapi/asm/socket.h > index 0d0fddb7e738..976e89b116e5 100644 > --- a/arch/alpha/include/uapi/asm/socket.h > +++ b/arch/alpha/include/uapi/asm/socket.h > @@ -2,8 +2,8 @@ > #ifndef _UAPI_ASM_SOCKET_H > #define _UAPI_ASM_SOCKET_H > > +#include > #include > -#include This breaks POSIX conformance in glibc because the header is not namespace clean. It contains the identifiers fds_bits and val: unsigned long fds_bits[__FD_SETSIZE / (8 * sizeof(long))]; int val[2]; We could duplicate some of the SO_* constants for POSIX mode in glibc, but it would be nice to avoid that. Is there a different way of fixing this on the kernel side that avoids including ?