From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E97C07E85 for ; Tue, 11 Dec 2018 11:47:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D90120849 for ; Tue, 11 Dec 2018 11:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544528827; bh=gRRgU6Gx26vikAqPrYNblP4KVbfUpbyiIegByNAXiUs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-ID:From; b=upWfJmkyxUaigHjbK9izbcGksjKt9WY6sdaPvhhb5b8wl1Z1oHxOyeH4AB7B+rZgc KVQ0YRSNXXXcnT8AxaXAMnF7/7PF2cFXpXWko7xyoPUu9EoUVzGoYRGJ0SvYuCnuUh cbK7ZvzIjEepgSfxgpCbeSDknR/wSTfwXIQcSTgA= DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D90120849 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726298AbeLKLrF (ORCPT ); Tue, 11 Dec 2018 06:47:05 -0500 Received: from mga07.intel.com ([134.134.136.100]:45156 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726114AbeLKLrF (ORCPT ); Tue, 11 Dec 2018 06:47:05 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2018 03:47:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,342,1539673200"; d="asc'?scan'208";a="302866348" Received: from pipin.fi.intel.com (HELO localhost) ([10.237.72.175]) by fmsmga005.fm.intel.com with ESMTP; 11 Dec 2018 03:47:00 -0800 From: Felipe Balbi To: Roger Quadros , Pawel Laszczak , devicetree@vger.kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, adouglas@cadence.com, jbergsagel@ti.com, nsekhar@ti.com, nm@ti.com, sureshp@cadence.com, peter.chen@nxp.com, pjez@cadence.com, kurahul@cadence.com Subject: Re: [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver In-Reply-To: <5C0F85E4.10609@ti.com> References: <1544445555-17325-1-git-send-email-pawell@cadence.com> <1544445555-17325-3-git-send-email-pawell@cadence.com> <5C0F85E4.10609@ti.com> Date: Tue, 11 Dec 2018 13:46:51 +0200 Message-ID: <87k1kgmgk4.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Roger Quadros writes: >> This patch introduce new Cadence USBSS DRD driver >> to linux kernel. >>=20 >> The Cadence USBSS DRD Driver is a highly >> configurable IP Core which can be >> instantiated as Dual-Role Device (DRD), >> Peripheral Only and Host Only (XHCI) >> configurations. >>=20 >> The current driver has been validated with >> FPGA burned. We have support for PCIe >> bus, which is used on FPGA prototyping. >>=20 >> The host side of USBSS-DRD controller is compliance >> with XHCI specification, so it works with >> standard XHCI linux driver. >>=20 >> Signed-off-by: Pawel Laszczak >> --- >> drivers/usb/Kconfig | 2 + >> drivers/usb/Makefile | 2 + >> drivers/usb/cdns3/Kconfig | 44 + >> drivers/usb/cdns3/Makefile | 16 + >> drivers/usb/cdns3/cdns3-pci-wrap.c | 157 +++ >> drivers/usb/cdns3/core.c | 451 +++++++ >> drivers/usb/cdns3/core.h | 108 ++ >> drivers/usb/cdns3/debug.h | 346 ++++++ >> drivers/usb/cdns3/debugfs.c | 168 +++ >> drivers/usb/cdns3/drd.c | 315 +++++ >> drivers/usb/cdns3/drd.h | 129 ++ >> drivers/usb/cdns3/ep0.c | 864 +++++++++++++ >> drivers/usb/cdns3/gadget-export.h | 28 + >> drivers/usb/cdns3/gadget.c | 1802 ++++++++++++++++++++++++++++ >> drivers/usb/cdns3/gadget.h | 1177 ++++++++++++++++++ >> drivers/usb/cdns3/host-export.h | 28 + >> drivers/usb/cdns3/host.c | 74 ++ >> drivers/usb/cdns3/trace.c | 11 + >> drivers/usb/cdns3/trace.h | 343 ++++++ > > You went to the other extreme of combining everything (host/gadget/drd) t= ogether > which again makes this very hard to review. > > I think what Felipe meant was to only combine the gadget driver code > into one patch. > > The series could be split into 6 patches like so. > -dt binding > -pci glue > -core driver > -host driver > -gadget driver > -drd driver no, no. This is fine. We _could_ split out PCI glue to its own patch, but it's rather pointless seing as it's so small. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlwPo60ACgkQzL64meEa mQYVaQ//SWD7ik1bFKOvm13A8mLphPuwef4FHi75UJ26VKbdTqfoUwMyYzxH1Qn/ nIePbHRunPNhonrNGpzKM0t6qfd5h9DYhGp2t6Vp0rQxacHHhFPG5GXlYTXbbeqW y7A2A+PMmDhfmgU1+4ywVUC3dyFTGVeETu9WDa+oemw5LMlMDSgr/5518lzE9zqW oxqRqNe1ucXwGoYLN5MjCsco+ojL3Km/FWBsrbXQfg1DSNLXXLW6FJu+8uMsunMC EvCTKk9VxUtgtrQoIbkTo1+DBfK26tfvKN2v01Yi8xrxMrvMc8JHtYBpis4O+jcw By8flXBvvI3tYJ/fFgqJlkRFdmu8UXyyi59oEyEj7QEklBwVg3ePtsDkJwBNWhS4 cAyySDe2MZB922fP3lA2s0AQxq5Sgc9DvA0zskqax1eqHC2AJpjvhxvbf8utnl+Q LZdXBjNaJ7uQEtQEd8e4R8cZSeQmmKDOuy3+4e6ZV4jbR95Xz1CGEJaK+2bvRj/x odAULfkl93p+oGjwYAEEOCptkaCH6aMv9bUt7eaX9hMMgkY3Mg46KIjmg4WoPtq3 DqTgr3ajXzUyL5OxsowBqzc5s7dZoi60PJcSoeeU7NUFqkqyEH7w89iiMbxuDdtv z3bB+r5rWd8I9Vq7vyLibnBioa/7rq6KE+VKiKfZQnRmf9RRhwc= =qvrM -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,2/2] usb:cdns3 Add Cadence USB3 DRD Driver From: Felipe Balbi Message-Id: <87k1kgmgk4.fsf@linux.intel.com> Date: Tue, 11 Dec 2018 13:46:51 +0200 To: Roger Quadros , Pawel Laszczak , devicetree@vger.kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, adouglas@cadence.com, jbergsagel@ti.com, nsekhar@ti.com, nm@ti.com, sureshp@cadence.com, peter.chen@nxp.com, pjez@cadence.com, kurahul@cadence.com List-ID: SGksCgpSb2dlciBRdWFkcm9zIDxyb2dlcnFAdGkuY29tPiB3cml0ZXM6Cj4+IFRoaXMgcGF0Y2gg aW50cm9kdWNlIG5ldyBDYWRlbmNlIFVTQlNTIERSRCBkcml2ZXIKPj4gdG8gbGludXgga2VybmVs Lgo+PiAKPj4gVGhlIENhZGVuY2UgVVNCU1MgRFJEIERyaXZlciBpcyBhIGhpZ2hseQo+PiBjb25m aWd1cmFibGUgSVAgQ29yZSB3aGljaCBjYW4gYmUKPj4gaW5zdGFudGlhdGVkIGFzIER1YWwtUm9s ZSBEZXZpY2UgKERSRCksCj4+IFBlcmlwaGVyYWwgT25seSBhbmQgSG9zdCBPbmx5IChYSENJKQo+ PiBjb25maWd1cmF0aW9ucy4KPj4gCj4+IFRoZSBjdXJyZW50IGRyaXZlciBoYXMgYmVlbiB2YWxp ZGF0ZWQgd2l0aAo+PiBGUEdBIGJ1cm5lZC4gV2UgaGF2ZSBzdXBwb3J0IGZvciBQQ0llCj4+IGJ1 cywgd2hpY2ggaXMgdXNlZCBvbiBGUEdBIHByb3RvdHlwaW5nLgo+PiAKPj4gVGhlIGhvc3Qgc2lk ZSBvZiBVU0JTUy1EUkQgY29udHJvbGxlciBpcyBjb21wbGlhbmNlCj4+IHdpdGggWEhDSSBzcGVj aWZpY2F0aW9uLCBzbyBpdCB3b3JrcyB3aXRoCj4+IHN0YW5kYXJkIFhIQ0kgbGludXggZHJpdmVy Lgo+PiAKPj4gU2lnbmVkLW9mZi1ieTogUGF3ZWwgTGFzemN6YWsgPHBhd2VsbEBjYWRlbmNlLmNv bT4KPj4gLS0tCj4+ICBkcml2ZXJzL3VzYi9LY29uZmlnICAgICAgICAgICAgICAgIHwgICAgMiAr Cj4+ICBkcml2ZXJzL3VzYi9NYWtlZmlsZSAgICAgICAgICAgICAgIHwgICAgMiArCj4+ICBkcml2 ZXJzL3VzYi9jZG5zMy9LY29uZmlnICAgICAgICAgIHwgICA0NCArCj4+ICBkcml2ZXJzL3VzYi9j ZG5zMy9NYWtlZmlsZSAgICAgICAgIHwgICAxNiArCj4+ICBkcml2ZXJzL3VzYi9jZG5zMy9jZG5z My1wY2ktd3JhcC5jIHwgIDE1NyArKysKPj4gIGRyaXZlcnMvdXNiL2NkbnMzL2NvcmUuYyAgICAg ICAgICAgfCAgNDUxICsrKysrKysKPj4gIGRyaXZlcnMvdXNiL2NkbnMzL2NvcmUuaCAgICAgICAg ICAgfCAgMTA4ICsrCj4+ICBkcml2ZXJzL3VzYi9jZG5zMy9kZWJ1Zy5oICAgICAgICAgIHwgIDM0 NiArKysrKysKPj4gIGRyaXZlcnMvdXNiL2NkbnMzL2RlYnVnZnMuYyAgICAgICAgfCAgMTY4ICsr Kwo+PiAgZHJpdmVycy91c2IvY2RuczMvZHJkLmMgICAgICAgICAgICB8ICAzMTUgKysrKysKPj4g IGRyaXZlcnMvdXNiL2NkbnMzL2RyZC5oICAgICAgICAgICAgfCAgMTI5ICsrCj4+ICBkcml2ZXJz L3VzYi9jZG5zMy9lcDAuYyAgICAgICAgICAgIHwgIDg2NCArKysrKysrKysrKysrCj4+ICBkcml2 ZXJzL3VzYi9jZG5zMy9nYWRnZXQtZXhwb3J0LmggIHwgICAyOCArCj4+ICBkcml2ZXJzL3VzYi9j ZG5zMy9nYWRnZXQuYyAgICAgICAgIHwgMTgwMiArKysrKysrKysrKysrKysrKysrKysrKysrKysr Cj4+ICBkcml2ZXJzL3VzYi9jZG5zMy9nYWRnZXQuaCAgICAgICAgIHwgMTE3NyArKysrKysrKysr KysrKysrKysKPj4gIGRyaXZlcnMvdXNiL2NkbnMzL2hvc3QtZXhwb3J0LmggICAgfCAgIDI4ICsK Pj4gIGRyaXZlcnMvdXNiL2NkbnMzL2hvc3QuYyAgICAgICAgICAgfCAgIDc0ICsrCj4+ICBkcml2 ZXJzL3VzYi9jZG5zMy90cmFjZS5jICAgICAgICAgIHwgICAxMSArCj4+ICBkcml2ZXJzL3VzYi9j ZG5zMy90cmFjZS5oICAgICAgICAgIHwgIDM0MyArKysrKysKPgo+IFlvdSB3ZW50IHRvIHRoZSBv dGhlciBleHRyZW1lIG9mIGNvbWJpbmluZyBldmVyeXRoaW5nIChob3N0L2dhZGdldC9kcmQpIHRv Z2V0aGVyCj4gd2hpY2ggYWdhaW4gbWFrZXMgdGhpcyB2ZXJ5IGhhcmQgdG8gcmV2aWV3Lgo+Cj4g SSB0aGluayB3aGF0IEZlbGlwZSBtZWFudCB3YXMgdG8gb25seSBjb21iaW5lIHRoZSBnYWRnZXQg ZHJpdmVyIGNvZGUKPiBpbnRvIG9uZSBwYXRjaC4KPgo+IFRoZSBzZXJpZXMgY291bGQgYmUgc3Bs aXQgaW50byA2IHBhdGNoZXMgbGlrZSBzby4KPiAtZHQgYmluZGluZwo+IC1wY2kgZ2x1ZQo+IC1j b3JlIGRyaXZlcgo+IC1ob3N0IGRyaXZlcgo+IC1nYWRnZXQgZHJpdmVyCj4gLWRyZCBkcml2ZXIK Cm5vLCBuby4gVGhpcyBpcyBmaW5lLiBXZSBfY291bGRfIHNwbGl0IG91dCBQQ0kgZ2x1ZSB0byBp dHMgb3duIHBhdGNoLApidXQgaXQncyByYXRoZXIgcG9pbnRsZXNzIHNlaW5nIGFzIGl0J3Mgc28g c21hbGwuCg==