From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-renesas-soc-owner@vger.kernel.org>
Received: from mail-ty1jpn01on0111.outbound.protection.outlook.com ([104.47.93.111]:15163
        "EHLO JPN01-TY1-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1727861AbeKHJt2 (ORCPT
        <rfc822;linux-renesas-soc@vger.kernel.org>);
        Thu, 8 Nov 2018 04:49:28 -0500
Message-ID: <87k1loe8j4.wl-kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Simon <horms@verge.net.au>,
        Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>,
        Magnus <magnus.damm@gmail.com>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: HDMI doesn't work on ULCB board
In-Reply-To: <11422106.UDNRqNEHC1@avalon>
References: <87bm7svwmp.wl-kuninori.morimoto.gx@renesas.com>
        <2572640.8aYrqOtQfk@avalon>
        <11422106.UDNRqNEHC1@avalon>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Date: Thu, 8 Nov 2018 00:16:35 +0000
Sender: linux-renesas-soc-owner@vger.kernel.org
List-ID: <linux-renesas-soc.vger.kernel.org>


Hi Laurent

Thank you for your help

> > I tried to reproduce the problem, starting with drm-next which seems to work
> > fine, moving to renesas-drivers-2018-10-09-v4.19-rc7 which also didn't
> > exhibit any issue. I then used your kernel configuration, and got a WARN_ON
> > \o/
> 
> Investigations revealed that you're missing the CONFIG_COMMON_CLK_VC5=y option 
> in your kernel configuration. It also revealed a bug in the error handling 
> code of the DU driver, for which I have just sent "[PATCH] drm: rcar-du: Fix 
> external clock error checks".

Thanks !!
I tried your posted patch, and it solved Oops issue,
and CONFIG_COMMON_CLK_VC5 solved HDMI outputs !!

Best regards
---
Kuninori Morimoto