From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3,2/2] librsvg: bump to version 2.42.5
Date: Tue, 12 Jun 2018 22:18:50 +0200 [thread overview]
Message-ID: <87k1r369n9.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <CAPi7W82Dpby1yZCmpzG7_MXm=c3xeowOt3tHyW_gPYbnTA2NXA@mail.gmail.com> (Fabrice Fontaine's message of "Tue, 12 Jun 2018 21:47:51 +0200")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
Hi,
>> This also causes a number of issues for host-librsvg (which is a
>> dependency of libgtk3 and midori) when building for architectures not
>> supported by rust:
>>
> The issue isn't related to libgtk3 and midori as this build fails (
> http://autobuild.buildroot.net/results/f33/f335ed517b402c094ed3b10a3da4cdc23620dbd6/defconfig)
> even if these packages are not selected.
It is a bit more tricky than that because it can also be about
host-libgtk3. For this configuration it is adwaita-icon-theme which
pulls in host-libgtk3 -> host-librsvg -> host-cargo -> host-rustc
> I'm not an expert in virtual package but it seems we try to build
> host-rustc even if BR2_PACKAGE_HOST_RUSTC is not selected by the user
> (which is allowed).
Indeed.
> The issue is that BR2_PACKAGE_PROVIDES_HOST_RUSTC is not defined if
> BR2_PACKAGE_HOST_RUSTC is not set (see rustc/Config.in.host).
> Moreover, we define it like this:
> config BR2_PACKAGE_PROVIDES_HOST_RUSTC
> string
> default "host-rust" if BR2_PACKAGE_HOST_RUST
> default "host-rust-bin" if BR2_PACKAGE_HOST_RUST_BIN
> As a result, if the user does not select host-rust or host-rust-bin, then
> there is no provider for host-rustc.
But that is expected. host-rustc is a mix of a host utility and data
specific to a target, so we really cannot use it if we are not on a
supported host system AND building for a supported target.
> config BR2_PACKAGE_PROVIDES_HOST_RUSTC
> string
> default "host-rust" if BR2_PACKAGE_HOST_RUST
> default "host-rust-bin" if BR2_PACKAGE_HOST_RUST_BIN
> default "host-rust-bin" if !BR2_PACKAGE_HOST_RUST ||
> !BR2_PACKAGE_HOST_RUST
> Indeed, HOST_RUST_BIN doesn't have any dependencies
It does, in the sense that it downloads the following files:
HOST_RUST_BIN_EXTRA_DOWNLOADS = \
rust-std-$(RUST_BIN_VERSION)-$(RUSTC_HOST_NAME).tar.xz \
rust-std-$(RUST_BIN_VERSION)-$(RUSTC_TARGET_NAME).tar.xz
And those files are only available for specific RUSTC_HOST_NAME and
RUSTC_TARGET_NAME values.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2018-06-12 20:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-10 13:38 [Buildroot] [PATCH v3,1/2] host-cargo: select host-rustc Fabrice Fontaine
2018-06-10 13:38 ` [Buildroot] [PATCH v3,2/2] librsvg: bump to version 2.42.5 Fabrice Fontaine
2018-06-10 14:25 ` Thomas Petazzoni
2018-06-12 6:58 ` Peter Korsgaard
2018-06-12 19:47 ` Fabrice Fontaine
2018-06-12 20:18 ` Peter Korsgaard [this message]
2018-06-12 20:42 ` Thomas Petazzoni
2018-07-16 11:19 ` Thomas Petazzoni
2018-06-10 14:18 ` [Buildroot] [PATCH v3,1/2] host-cargo: select host-rustc Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1r369n9.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.