From: Kalle Valo <kvalo@codeaurora.org>
To: Luca Coelho <luca@coelho.fi>
Cc: Alexander Wetzel <alexander.wetzel@web.de>,
linux-wireless@vger.kernel.org,
Golan Ben Ami <golan.ben.ami@intel.com>
Subject: Re: iwlwifi: regression due to: allow different csr flags for different device families
Date: Thu, 31 May 2018 11:44:46 +0300 [thread overview]
Message-ID: <87k1rk1af5.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <3a0d36e025325f873f6db2651c6d576b3b14c36d.camel@coelho.fi> (Luca Coelho's message of "Thu, 31 May 2018 09:30:48 +0300")
Luca Coelho <luca@coelho.fi> writes:
> On Sun, 2018-05-27 at 14:08 +0200, Alexander Wetzel wrote:
>> > From: Golan Ben Ami <golan.ben.ami@intel.com>
>> >
>> > Different device families may have different flag values
>> > for passing a message to the fw (i.e. SW_RESET).
>> > In order to keep the code readable, and avoid conditioning
>> > upon the family, store a value for each flag, which indicates
>> > the bit that needs to be enabled.
>> >
>> > Signed-off-by: Golan Ben Ami <golan.ben.ami@intel.com>
>> > Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
>>
>> This patch generates a Null pointer exception for my Ultimate-N 6300
>> card when loading the driver, making the card unusable.
>> (Bisecting linked it to commit
>> a8cbb46f831d2c101feccdd0e0daf3627b8c1dca.)
>>
>> Sine the commit could not be simply reverted I applied this commit to
>> my
>> distribution kernel - basically 4.16.12 - and can confirm it is
>> indeed
>> causing the issue.
>
> It seems that I forgot to reply to this, even though we looked into it
> and provided a fix[1]. This fix will hopefully be included in 4.17
> final.
>
> Thanks a lot for reporting and bisecting!
>
> [1] https://patchwork.kernel.org/patch/10437773/
Something is not right, commit 0513c083d1f4 is in wireless-drivers-next
so it will be in 4.18. Are we mixing commits or releases or did I pull
it to wrong tree?
0513c083d1f4 iwlwifi: add csr configuration for 6300 devices
--
Kalle Valo
next prev parent reply other threads:[~2018-05-31 8:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-22 8:27 [PATCH 00/12] iwlwifi: updates intended for v4.18 2018-04-22 Luca Coelho
2018-04-22 8:27 ` [PATCH 01/12] iwlwifi: allow different csr flags for different device families Luca Coelho
2018-05-27 12:08 ` iwlwifi: regression due to: " Alexander Wetzel
2018-05-31 6:30 ` Luca Coelho
2018-05-31 8:44 ` Kalle Valo [this message]
2018-05-31 9:17 ` Luca Coelho
2018-04-22 8:27 ` [PATCH 02/12] iwlwifi: introduce Image Loader (IML) - new firmware image Luca Coelho
2018-04-22 8:27 ` [PATCH 03/12] iwlwifi: cfg: remove unnecessary cfg data in non-dvm devices Luca Coelho
2018-04-22 8:27 ` [PATCH 04/12] iwlwifi: pcie: allow sending pre-built A-MSDUs Luca Coelho
2018-04-22 8:27 ` [PATCH 05/12] iwlwifi: support new csr addresses for hw address Luca Coelho
2018-04-22 8:27 ` [PATCH 06/12] iwlwifi: mvm: move skb padding reservation earlier Luca Coelho
2018-04-22 8:27 ` [PATCH 07/12] iwlwifi: fw: harden page loading code Luca Coelho
2018-04-22 8:27 ` [PATCH 08/12] iwlwifi: fw: combine loading of last page block into main copy loop Luca Coelho
2018-04-22 8:27 ` [PATCH 09/12] iwlwifi: pcie: remove non-responsive device Luca Coelho
2018-04-24 9:44 ` Kalle Valo
2018-04-24 10:56 ` Luca Coelho
2018-04-25 8:01 ` Kalle Valo
2018-04-26 7:46 ` Luca Coelho
2018-04-26 7:53 ` [PATCH v2 12/12] " Luca Coelho
2018-04-26 7:55 ` Luciano Coelho
2018-04-22 8:27 ` [PATCH 10/12] iwlwifi: make bitfield a u32 instead of u16 Luca Coelho
2018-04-22 8:27 ` [PATCH 11/12] iwlwifi: mvm: remove check for non low latency TIDs Luca Coelho
2018-04-22 8:27 ` [PATCH 12/12] iwlwifi: mvm: set wakeup filters for wowlan "any" configuration Luca Coelho
2018-04-24 9:45 ` Kalle Valo
2018-04-24 10:56 ` Luca Coelho
2018-04-26 7:52 ` [PATCH v2 " Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1rk1af5.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=alexander.wetzel@web.de \
--cc=golan.ben.ami@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.