From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: Michael Ellerman To: Bjorn Helgaas , Alexey Kardashevskiy Cc: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Bjorn Helgaas , Rob Herring , linux-pci@vger.kernel.org Subject: Re: [PATCH kernel v3] powerpc/pci: Fix broken INTx configuration via OF In-Reply-To: <20180210205118.GG206223@bhelgaas-glaptop.roam.corp.google.com> References: <20180209062358.33457-1-aik@ozlabs.ru> <20180209180741.GB206223@bhelgaas-glaptop.roam.corp.google.com> <20180210205118.GG206223@bhelgaas-glaptop.roam.corp.google.com> Date: Mon, 12 Feb 2018 14:49:32 +1100 Message-ID: <87k1vix3xv.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain List-ID: Bjorn Helgaas writes: > On Fri, Feb 09, 2018 at 12:07:41PM -0600, Bjorn Helgaas wrote: >> On Fri, Feb 09, 2018 at 05:23:58PM +1100, Alexey Kardashevskiy wrote: >> > Commit 59f47eff03a0 ("powerpc/pci: Use of_irq_parse_and_map_pci() helper") >> > replaced of_irq_parse_pci() + irq_create_of_mapping() with >> > of_irq_parse_and_map_pci() but this change lost virq returned by >> > irq_create_of_mapping() so virq remained zero causing INTx >> > misconfiguration. >> > >> > This fixes pci_read_irq_line() not to loose a virq returned by >> > of_irq_parse_and_map_pci(). >> >> s/not to loose a/to not lose the/ >> >> > Fixes: 59f47eff03a0 "powerpc/pci: Use of_irq_parse_and_map_pci() helper" >> > Signed-off-by: Alexey Kardashevskiy >> >> I'm fine with this version. >> >> Since you started applying a previous version, Michael, I'll assume >> you will handle this unless you tell me otherwise. One way or another >> it would be good to get this in before -rc1. > > I went ahead and applied this and asked Linus to pull it. Thanks. cheers