From: Markus Armbruster <armbru@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] scripts: use build_ prefix for string not piped through cgen()
Date: Thu, 06 Jul 2017 10:23:05 +0200 [thread overview]
Message-ID: <87k23m6kk6.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170601124143.10915-1-marcandre.lureau@redhat.com> (=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Thu, 1 Jun 2017 16:41:41 +0400")
Marc-André Lureau <marcandre.lureau@redhat.com> writes:
> Suggested by Markus Armbruster:
Replacing the line above with ...
> The gen_ prefix is awkward. Generated C should go through cgen()
> exactly once (see commit 1f9a7a1). The common way to get this wrong is
> passing a foo=gen_foo() keyword argument to mcgen(). I'd like us to
> adopt a naming convention where gen_ means "something that's been piped
> through cgen(), and thus must not be passed to cgen() or mcgen()".
> Requires renaming gen_params(), gen_marshal_proto() and
> gen_event_send_proto().
Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Applied, thanks!
prev parent reply other threads:[~2017-07-06 8:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 12:41 [Qemu-devel] [PATCH v2 1/2] scripts: use build_ prefix for string not piped through cgen() Marc-André Lureau
2017-06-01 12:41 ` [Qemu-devel] [PATCH v2 2/2] qapi: add location comment for generated types Marc-André Lureau
2017-06-01 14:15 ` Eric Blake
2017-07-06 8:43 ` Markus Armbruster
2017-07-06 12:11 ` Marc-André Lureau
2017-07-06 15:15 ` Markus Armbruster
2017-06-01 14:11 ` [Qemu-devel] [PATCH v2 1/2] scripts: use build_ prefix for string not piped through cgen() Eric Blake
2017-07-06 8:23 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k23m6kk6.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.