From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754043AbdBPIzL (ORCPT ); Thu, 16 Feb 2017 03:55:11 -0500 Received: from mga04.intel.com ([192.55.52.120]:10245 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753792AbdBPIzK (ORCPT ); Thu, 16 Feb 2017 03:55:10 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,168,1484035200"; d="asc'?scan'208";a="59113509" From: Felipe Balbi To: Roger Quadros Cc: Peter.Chen@nxp.com, gregkh@linuxfoundation.org, garsilva@embeddedor.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] usb: dwc3: use BIT() macro where possible In-Reply-To: References: <1487158704-9006-1-git-send-email-rogerq@ti.com> <1487158704-9006-3-git-send-email-rogerq@ti.com> <87poijoez9.fsf@linux.intel.com> Date: Thu, 16 Feb 2017 10:54:33 +0200 Message-ID: <87k28qo6ra.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Roger Quadros writes: > On 15/02/17 13:44, Felipe Balbi wrote: >>=20 >> Hi, >>=20 >> Roger Quadros writes: >>> To avoid checkpatch warnings with new patches let's >>> start using the BIT() macro wherever possible. >>> >>> Signed-off-by: Roger Quadros >>> --- >>> drivers/usb/dwc3/core.h | 192 +++++++++++++++++++++--------------= -------- >>> drivers/usb/dwc3/dwc3-omap.c | 48 +++++------ >>> drivers/usb/dwc3/gadget.h | 20 ++--- >>> 3 files changed, 130 insertions(+), 130 deletions(-) >>> >>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h >>> index 14b7602..d514dca 100644 >>> --- a/drivers/usb/dwc3/core.h >>> +++ b/drivers/usb/dwc3/core.h >>> @@ -65,7 +65,7 @@ >>> #define DWC3_DEVICE_EVENT_OVERFLOW 11 >>>=20=20 >>> #define DWC3_GEVNTCOUNT_MASK 0xfffc >>> -#define DWC3_GEVNTCOUNT_EHB (1 << 31) >>> +#define DWC3_GEVNTCOUNT_EHB BIT(31) >>=20 >> don't you need to include for this? >>=20 > > I didn't get any build errors though. indirect inclusion. Problems will show up only when headers are moved around ;-) =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlilaMkACgkQzL64meEa mQbJVw/8CmNYeavvj8KQyx8ry+Jv4kEI/aYkGbVl4lvygpF8mLCnhDY9nPS2+/Qk DOYuDue/Um0DZGlh1pY2v1uPW6TE8t46UJvNt/fm1Tu3GB9ciDvp2nApnGYl3VJq qnemq2hfxCYQ0kKgaME5n8lBQSRqMi6coFeP46EGJUi0m+a5qZatw7wui9wXhaLw 2XfThcNzgrAoPfCKWhfFSePY/gyM3DOSHXOs7UFcSbwDH10tW5s+igc6wteuSv9X oM3ELCzh5vuzsaoJeYr4T140B+ZXRRtTOL7TQP9XQ+MkIYhFymnm8FzS7dW471M/ Zefz9hsD7W6Z102NYtZkds7Uhu8ZT8VtSZKlG/D3kREqBZZjURRrOBoJ2MiqzCN/ rkUA5dH5NUGtQDllPtSgyDJOp8euJ1HIv5zcJRgAD2N0cgI8WwFY68L1s43pD33g PRtlZnrtTQ0BHnNpnjUMdKSpJFg+/G2Bs2FSBMPxhlFLy8ItL2SchvnV+G4V4WNO RAdQIdnVL13AycAof23HruX7Vv8Juz1wd1oybVBlrCdCsG/eSDAZVBxRlz34nWu4 A7D2keR/kMbRDMqw7sj92tNPIZO9iJYvSZj+A+5Nhso3SKm9Hj2jjajL6aBH6iD2 1vyiDvWbIBVyhdadsZvwWyhKruoh+Ocs66406UH6bIQeY+b5K2Y= =Kso0 -----END PGP SIGNATURE----- --=-=-=--