From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 08/17] drm/i915: Drop spinlocks around adding to the client request list Date: Wed, 24 Aug 2016 16:16:55 +0300 Message-ID: <87k2f6mhmg.fsf@gaia.fi.intel.com> References: <20160822080350.4964-1-chris@chris-wilson.co.uk> <20160822080350.4964-9-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id BAB386E8A0 for ; Wed, 24 Aug 2016 13:17:52 +0000 (UTC) In-Reply-To: <20160822080350.4964-9-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gQWRkaW5n IHRvIHRoZSB0YWlsIG9mIHRoZSBjbGllbnQgcmVxdWVzdCBsaXN0IGFzIHRoZSBvbmx5IG90aGVy IHVzZXIgaXMKPiBpbiB0aGUgdGhyb3R0bGUgaW9jdGwgdGhhdCBpdGVyYXRlcyBmb3J3YXJkcyBv dmVyIHRoZSBsaXN0LiBJdCBvbmx5Cj4gbmVlZHMgcHJvdGVjdGlvbiBhZ2FpbnN0IGRlbGV0aW9u IG9mIGEgcmVxdWVzdCBhcyBpdCByZWFkcyBpdCwgaXQgc2ltcGx5Cj4gd29uJ3Qgc2VlIGEgbmV3 IHJlcXVlc3QgYWRkZWQgdG8gdGhlIGVuZCBvZiB0aGUgbGlzdCwgb3IgaXQgd291bGQgYmUgdG9v Cj4gZWFybHkgYW5kIHJlamVjdGVkLiBXZSBjYW4gZnVydGhlciByZWR1Y2UgdGhlIG51bWJlciBv ZiBzcGlubG9ja3MKPiByZXF1aXJlZCB3aGVuIHRocm90dGxpbmcgYnkgcmVtb3Zpbmcgc3RhbGUg cmVxdWVzdHMgZnJvbSB0aGUgY2xpZW50X2xpc3QKPiBhcyB3ZSB0aHJvdHRsZS4KPgo+IFNpZ25l ZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyAgICAgICAgfCAgMiArLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICAgICAgICAgfCAxNCArKysrKystLS0t LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jIHwgMTQgKysr KysrKy0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYyAgICB8 IDM0ICsrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2dlbV9yZXF1ZXN0LmggICAgfCAgNCArLS0tCj4gIDUgZmlsZXMgY2hhbmdlZCwgMjMg aW5zZXJ0aW9ucygrKSwgNDUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rl YnVnZnMuYwo+IGluZGV4IDA4NjA1M2ZhMjgyMC4uOTk2NzQ0NzA4ZjMxIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiBAQCAtNDgwLDcgKzQ4MCw3IEBAIHN0YXRpYyBpbnQg aTkxNV9nZW1fb2JqZWN0X2luZm8oc3RydWN0IHNlcV9maWxlICptLCB2b2lkKiBkYXRhKQo+ICAJ CW11dGV4X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiAgCQlyZXF1ZXN0ID0gbGlzdF9maXJz dF9lbnRyeV9vcl9udWxsKCZmaWxlX3ByaXYtPm1tLnJlcXVlc3RfbGlzdCwKPiAgCQkJCQkJICAg c3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0LAo+IC0JCQkJCQkgICBjbGllbnRfbGlzdCk7Cj4g KwkJCQkJCSAgIGNsaWVudF9saW5rKTsKPiAgCQlyY3VfcmVhZF9sb2NrKCk7Cj4gIAkJdGFzayA9 IHBpZF90YXNrKHJlcXVlc3QgJiYgcmVxdWVzdC0+Y3R4LT5waWQgPwo+ICAJCQkJcmVxdWVzdC0+ Y3R4LT5waWQgOiBmaWxlLT5waWQsCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXggN2I4 YWJkYTU0MWU2Li5lNDMyMjExZThiMjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBA QCAtMzY3MywxNiArMzY3MywxNCBAQCBpOTE1X2dlbV9yaW5nX3Rocm90dGxlKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSkKPiAgCQlyZXR1cm4gLUVJTzsKPiAg Cj4gIAlzcGluX2xvY2soJmZpbGVfcHJpdi0+bW0ubG9jayk7Cj4gLQlsaXN0X2Zvcl9lYWNoX2Vu dHJ5KHJlcXVlc3QsICZmaWxlX3ByaXYtPm1tLnJlcXVlc3RfbGlzdCwgY2xpZW50X2xpc3QpIHsK PiArCWxpc3RfZm9yX2VhY2hfZW50cnkocmVxdWVzdCwgJmZpbGVfcHJpdi0+bW0ucmVxdWVzdF9s aXN0LCBjbGllbnRfbGluaykgewo+ICAJCWlmICh0aW1lX2FmdGVyX2VxKHJlcXVlc3QtPmVtaXR0 ZWRfamlmZmllcywgcmVjZW50X2Vub3VnaCkpCj4gIAkJCWJyZWFrOwo+ICAKPiAtCQkvKgo+IC0J CSAqIE5vdGUgdGhhdCB0aGUgcmVxdWVzdCBtaWdodCBub3QgaGF2ZSBiZWVuIHN1Ym1pdHRlZCB5 ZXQuCj4gLQkJICogSW4gd2hpY2ggY2FzZSBlbWl0dGVkX2ppZmZpZXMgd2lsbCBiZSB6ZXJvLgo+ IC0JCSAqLwo+IC0JCWlmICghcmVxdWVzdC0+ZW1pdHRlZF9qaWZmaWVzKQo+IC0JCQljb250aW51 ZTsKPiArCQlpZiAodGFyZ2V0KSB7Cj4gKwkJCWxpc3RfZGVsKCZ0YXJnZXQtPmNsaWVudF9saW5r KTsKPiArCQkJdGFyZ2V0LT5maWxlX3ByaXYgPSBOVUxMOwoKTm8gbmVlZCBmb3IgbGlzdF9mb3Jf ZWFjaF9lbnRyeV9zYWZlIGFzIHdlIGFyZSB0aHJvd2luZyBvdXQgc3R1ZmYgYmVmb3JlCnRoZSBw b2ludCBvZiB0cmF2ZXJzYWw/CgpNaWthCgo+ICsJCX0KPiAgCj4gIAkJdGFyZ2V0ID0gcmVxdWVz dDsKPiAgCX0KPiBAQCAtNDYzOSw3ICs0NjM3LDcgQEAgdm9pZCBpOTE1X2dlbV9yZWxlYXNlKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSkKPiAgCSAqIGZpbGVf cHJpdi4KPiAgCSAqLwo+ICAJc3Bpbl9sb2NrKCZmaWxlX3ByaXYtPm1tLmxvY2spOwo+IC0JbGlz dF9mb3JfZWFjaF9lbnRyeShyZXF1ZXN0LCAmZmlsZV9wcml2LT5tbS5yZXF1ZXN0X2xpc3QsIGNs aWVudF9saXN0KQo+ICsJbGlzdF9mb3JfZWFjaF9lbnRyeShyZXF1ZXN0LCAmZmlsZV9wcml2LT5t bS5yZXF1ZXN0X2xpc3QsIGNsaWVudF9saW5rKQo+ICAJCXJlcXVlc3QtPmZpbGVfcHJpdiA9IE5V TEw7Cj4gIAlzcGluX3VubG9jaygmZmlsZV9wcml2LT5tbS5sb2NrKTsKPiAgCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYwo+IGluZGV4IDEyNWZiMzhlZmY0MC4u NTY4OTQ0NWIxY2QzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt X2V4ZWNidWZmZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNi dWZmZXIuYwo+IEBAIC0xNDIxLDYgKzE0MjEsMTQgQEAgb3V0Ogo+ICAJcmV0dXJuIHZtYTsKPiAg fQo+ICAKPiArc3RhdGljIHZvaWQKPiArYWRkX3RvX2NsaWVudChzdHJ1Y3QgZHJtX2k5MTVfZ2Vt X3JlcXVlc3QgKnJlcSwKPiArCSAgICAgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSkKPiArewo+ICsJ cmVxLT5maWxlX3ByaXYgPSBmaWxlLT5kcml2ZXJfcHJpdjsKPiArCWxpc3RfYWRkX3RhaWwoJnJl cS0+Y2xpZW50X2xpbmssICZyZXEtPmZpbGVfcHJpdi0+bW0ucmVxdWVzdF9saXN0KTsKPiArfQo+ ICsKPiAgc3RhdGljIGludAo+ICBleGVjYnVmX3N1Ym1pdChzdHJ1Y3QgaTkxNV9leGVjYnVmZmVy X3BhcmFtcyAqcGFyYW1zLAo+ICAJICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fZXhlY2J1ZmZl cjIgKmFyZ3MsCj4gQEAgLTE1MTIsNiArMTUyMCw3IEBAIGV4ZWNidWZfc3VibWl0KHN0cnVjdCBp OTE1X2V4ZWNidWZmZXJfcGFyYW1zICpwYXJhbXMsCj4gIAl0cmFjZV9pOTE1X2dlbV9yaW5nX2Rp c3BhdGNoKHBhcmFtcy0+cmVxdWVzdCwgcGFyYW1zLT5kaXNwYXRjaF9mbGFncyk7Cj4gIAo+ICAJ aTkxNV9nZW1fZXhlY2J1ZmZlcl9tb3ZlX3RvX2FjdGl2ZSh2bWFzLCBwYXJhbXMtPnJlcXVlc3Qp Owo+ICsJYWRkX3RvX2NsaWVudChwYXJhbXMtPnJlcXVlc3QsIHBhcmFtcy0+ZmlsZSk7Cj4gIAo+ ICAJcmV0dXJuIDA7Cj4gIH0KPiBAQCAtMTgwOCwxMCArMTgxNyw2IEBAIGk5MTVfZ2VtX2RvX2V4 ZWNidWZmZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCSAqLwo+ICAJ cGFyYW1zLT5yZXF1ZXN0LT5iYXRjaCA9IHBhcmFtcy0+YmF0Y2g7Cj4gIAo+IC0JcmV0ID0gaTkx NV9nZW1fcmVxdWVzdF9hZGRfdG9fY2xpZW50KHBhcmFtcy0+cmVxdWVzdCwgZmlsZSk7Cj4gLQlp ZiAocmV0KQo+IC0JCWdvdG8gZXJyX3JlcXVlc3Q7Cj4gLQo+ICAJLyoKPiAgCSAqIFNhdmUgYXNz b3J0ZWQgc3R1ZmYgYXdheSB0byBwYXNzIHRocm91Z2ggdG8gKl9zdWJtaXNzaW9uKCkuCj4gIAkg KiBOQjogVGhpcyBkYXRhIHNob3VsZCBiZSAncGVyc2lzdGVudCcgYW5kIG5vdCBsb2NhbCBhcyBp dCB3aWxsCj4gQEAgLTE4MjUsNyArMTgzMCw2IEBAIGk5MTVfZ2VtX2RvX2V4ZWNidWZmZXIoc3Ry dWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCXBhcmFtcy0+Y3R4ICAgICAgICAg ICAgICAgICAgICAgPSBjdHg7Cj4gIAo+ICAJcmV0ID0gZXhlY2J1Zl9zdWJtaXQocGFyYW1zLCBh cmdzLCAmZWItPnZtYXMpOwo+IC1lcnJfcmVxdWVzdDoKPiAgCV9faTkxNV9hZGRfcmVxdWVzdChw YXJhbXMtPnJlcXVlc3QsIHJldCA9PSAwKTsKPiAgCj4gIGVycl9iYXRjaF91bnBpbjoKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5jCj4gaW5kZXggMWEyMTUzMjBjZWZiLi5i ZjYyNDI3YTM1YjcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1f cmVxdWVzdC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5j Cj4gQEAgLTExNSw0MiArMTE1LDIwIEBAIGNvbnN0IHN0cnVjdCBmZW5jZV9vcHMgaTkxNV9mZW5j ZV9vcHMgPSB7Cj4gIAkudGltZWxpbmVfdmFsdWVfc3RyID0gaTkxNV9mZW5jZV90aW1lbGluZV92 YWx1ZV9zdHIsCj4gIH07Cj4gIAo+IC1pbnQgaTkxNV9nZW1fcmVxdWVzdF9hZGRfdG9fY2xpZW50 KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxLAo+IC0JCQkJICAgc3RydWN0IGRybV9m aWxlICpmaWxlKQo+IC17Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXZhdGU7 Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfZmlsZV9wcml2YXRlICpmaWxlX3ByaXY7Cj4gLQo+IC0JV0FS Tl9PTighcmVxIHx8ICFmaWxlIHx8IHJlcS0+ZmlsZV9wcml2KTsKPiAtCj4gLQlpZiAoIXJlcSB8 fCAhZmlsZSkKPiAtCQlyZXR1cm4gLUVJTlZBTDsKPiAtCj4gLQlpZiAocmVxLT5maWxlX3ByaXYp Cj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQo+IC0JZGV2X3ByaXZhdGUgPSByZXEtPmk5MTU7Cj4g LQlmaWxlX3ByaXYgPSBmaWxlLT5kcml2ZXJfcHJpdjsKPiAtCj4gLQlzcGluX2xvY2soJmZpbGVf cHJpdi0+bW0ubG9jayk7Cj4gLQlyZXEtPmZpbGVfcHJpdiA9IGZpbGVfcHJpdjsKPiAtCWxpc3Rf YWRkX3RhaWwoJnJlcS0+Y2xpZW50X2xpc3QsICZmaWxlX3ByaXYtPm1tLnJlcXVlc3RfbGlzdCk7 Cj4gLQlzcGluX3VubG9jaygmZmlsZV9wcml2LT5tbS5sb2NrKTsKPiAtCj4gLQlyZXR1cm4gMDsK PiAtfQo+IC0KPiAgc3RhdGljIGlubGluZSB2b2lkCj4gIGk5MTVfZ2VtX3JlcXVlc3RfcmVtb3Zl X2Zyb21fY2xpZW50KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCkKPiAgewo+ IC0Jc3RydWN0IGRybV9pOTE1X2ZpbGVfcHJpdmF0ZSAqZmlsZV9wcml2ID0gcmVxdWVzdC0+Zmls ZV9wcml2Owo+ICsJc3RydWN0IGRybV9pOTE1X2ZpbGVfcHJpdmF0ZSAqZmlsZV9wcml2Owo+ICAK PiArCWZpbGVfcHJpdiA9IHJlcXVlc3QtPmZpbGVfcHJpdjsKPiAgCWlmICghZmlsZV9wcml2KQo+ ICAJCXJldHVybjsKPiAgCj4gIAlzcGluX2xvY2soJmZpbGVfcHJpdi0+bW0ubG9jayk7Cj4gLQls aXN0X2RlbCgmcmVxdWVzdC0+Y2xpZW50X2xpc3QpOwo+IC0JcmVxdWVzdC0+ZmlsZV9wcml2ID0g TlVMTDsKPiArCWlmIChyZXF1ZXN0LT5maWxlX3ByaXYpIHsKPiArCQlsaXN0X2RlbCgmcmVxdWVz dC0+Y2xpZW50X2xpbmspOwo+ICsJCXJlcXVlc3QtPmZpbGVfcHJpdiA9IE5VTEw7Cj4gKwl9Cj4g IAlzcGluX3VubG9jaygmZmlsZV9wcml2LT5tbS5sb2NrKTsKPiAgfQo+ICAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5oIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5oCj4gaW5kZXggNmM3MmJkOGQ5NDIzLi45ZDVhNjZi ZmM1MDkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVz dC5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5oCj4gQEAg LTEzMiw3ICsxMzIsNyBAQCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3Qgewo+ICAKPiAgCXN0 cnVjdCBkcm1faTkxNV9maWxlX3ByaXZhdGUgKmZpbGVfcHJpdjsKPiAgCS8qKiBmaWxlX3ByaXYg bGlzdCBlbnRyeSBmb3IgdGhpcyByZXF1ZXN0ICovCj4gLQlzdHJ1Y3QgbGlzdF9oZWFkIGNsaWVu dF9saXN0Owo+ICsJc3RydWN0IGxpc3RfaGVhZCBjbGllbnRfbGluazsKPiAgCj4gIAkvKioKPiAg CSAqIFRoZSBFTFNQIG9ubHkgYWNjZXB0cyB0d28gZWxlbWVudHMgYXQgYSB0aW1lLCBzbyB3ZSBx dWV1ZQo+IEBAIC0xNjcsOCArMTY3LDYgQEAgc3RhdGljIGlubGluZSBib29sIGZlbmNlX2lzX2k5 MTUoc3RydWN0IGZlbmNlICpmZW5jZSkKPiAgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICog X19tdXN0X2NoZWNrCj4gIGk5MTVfZ2VtX3JlcXVlc3RfYWxsb2Moc3RydWN0IGludGVsX2VuZ2lu ZV9jcyAqZW5naW5lLAo+ICAJCSAgICAgICBzdHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4KTsK PiAtaW50IGk5MTVfZ2VtX3JlcXVlc3RfYWRkX3RvX2NsaWVudChzdHJ1Y3QgZHJtX2k5MTVfZ2Vt X3JlcXVlc3QgKnJlcSwKPiAtCQkJCSAgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSk7Cj4gIHZvaWQg aTkxNV9nZW1fcmVxdWVzdF9yZXRpcmVfdXB0byhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3Qg KnJlcSk7Cj4gIAo+ICBzdGF0aWMgaW5saW5lIHUzMgo+IC0tIAo+IDIuOS4zCj4KPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWls aW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==