From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) Subject: Re: [PATCH review 10/13] vfs: Generalize filesystem nodev handling. Date: Tue, 21 Jun 2016 14:09:58 -0500 Message-ID: <87k2hi1hq1.fsf@x220.int.ebiederm.org> References: <87fus77pns.fsf@x220.int.ebiederm.org> <20160620172130.15712-1-ebiederm@xmission.com> <20160620172130.15712-10-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: (Andy Lutomirski's message of "Mon, 20 Jun 2016 15:57:09 -0700") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Andy Lutomirski Cc: Miklos Szeredi , Linux Containers , James Bottomley , Seth Forshee , Linux FS Devel , Djalal Harouni List-Id: containers.vger.kernel.org Andy Lutomirski writes: > On Mon, Jun 20, 2016 at 10:21 AM, Eric W. Biederman > wrote: >> Introduce a function may_open_dev that tests MNT_NODEV and a new >> superblock flab SB_I_NODEV. Use this new function in all of the >> places where MNT_NODEV was previously tested. > > This would be nicer as two patches: one to refactor the check and the > second to change the condition. I can see where introducing may_open_dev before changing the conditions in may_open_dev might have been a a hair more readable. At the same time that approaches the ridiculously small patches, and this change is one clear focused change (introduce and test SB_I_NODEV) and the change is small enough I don't see anything getting lost in the noise. I did very deliberately separate this from "12/13 userns: Remove implicit MNT_NODEV fragility." As a combination there would have been very confusing. Which is the really interesting result as it removes that stupid unnecessary difference between mounts inside and outside of user namespaces. Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out02.mta.xmission.com ([166.70.13.232]:52618 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751590AbcFUTWT (ORCPT ); Tue, 21 Jun 2016 15:22:19 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Andy Lutomirski Cc: Linux Containers , Linux FS Devel , Miklos Szeredi , James Bottomley , Djalal Harouni , Seth Forshee , "Serge E. Hallyn" References: <87fus77pns.fsf@x220.int.ebiederm.org> <20160620172130.15712-1-ebiederm@xmission.com> <20160620172130.15712-10-ebiederm@xmission.com> Date: Tue, 21 Jun 2016 14:09:58 -0500 In-Reply-To: (Andy Lutomirski's message of "Mon, 20 Jun 2016 15:57:09 -0700") Message-ID: <87k2hi1hq1.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [PATCH review 10/13] vfs: Generalize filesystem nodev handling. Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Andy Lutomirski writes: > On Mon, Jun 20, 2016 at 10:21 AM, Eric W. Biederman > wrote: >> Introduce a function may_open_dev that tests MNT_NODEV and a new >> superblock flab SB_I_NODEV. Use this new function in all of the >> places where MNT_NODEV was previously tested. > > This would be nicer as two patches: one to refactor the check and the > second to change the condition. I can see where introducing may_open_dev before changing the conditions in may_open_dev might have been a a hair more readable. At the same time that approaches the ridiculously small patches, and this change is one clear focused change (introduce and test SB_I_NODEV) and the change is small enough I don't see anything getting lost in the noise. I did very deliberately separate this from "12/13 userns: Remove implicit MNT_NODEV fragility." As a combination there would have been very confusing. Which is the really interesting result as it removes that stupid unnecessary difference between mounts inside and outside of user namespaces. Eric