From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Date: Fri, 04 Dec 2015 07:07:54 +0000 Subject: Re: [PATCH 2/4] thermal: rcar: enable to use thermal-zone on DT Message-Id: <87k2oug0cy.wl%kuninori.morimoto.gx@renesas.com> List-Id: References: <871tb2hpn2.wl%kuninori.morimoto.gx@renesas.com> <87y4dagb0i.wl%kuninori.morimoto.gx@renesas.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Manish Badarkhe Cc: Simon , Zhang Rui , Eduardo Valentin , Magnus , linux-sh@vger.kernel.org, linux-pm@vger.kernel.org, "linux-kernel@vger.kernel.org" Hi Manish > > +static int rcar_thermal_of_get_temp(void *data, int *temp) > > +{ > > + struct rcar_thermal_priv *priv = data; > > + > > + *temp = rcar_thermal_get_current_temp(priv); > > + > > + return 0; > > +} > > + > > +static int rcar_thermal_get_temp(struct thermal_zone_device *zone, int *temp) > > +{ > > + struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone); > > + > > + *temp = rcar_thermal_get_current_temp(priv); > > + > > return 0; > > } > > > > Above two function, always returns 0. Can it possible to handle error > and log some messages. Thanks. Will try in v2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754507AbbLDHIE (ORCPT ); Fri, 4 Dec 2015 02:08:04 -0500 Received: from relmlor3.renesas.com ([210.160.252.173]:17654 "EHLO relmlie2.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750896AbbLDHIA (ORCPT ); Fri, 4 Dec 2015 02:08:00 -0500 X-IronPort-AV: E=Sophos;i="5.20,380,1444662000"; d="scan'";a="201120157" Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Message-ID: <87k2oug0cy.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Manish Badarkhe CC: Simon , Zhang Rui , Eduardo Valentin , Magnus , , , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/4] thermal: rcar: enable to use thermal-zone on DT In-Reply-To: References: <871tb2hpn2.wl%kuninori.morimoto.gx@renesas.com> <87y4dagb0i.wl%kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Date: Fri, 4 Dec 2015 07:07:54 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: OS1PR01CA0019.jpnprd01.prod.outlook.com (25.161.225.157) To SG2PR06MB1018.apcprd06.prod.outlook.com (25.161.9.26) X-Microsoft-Exchange-Diagnostics: 1;SG2PR06MB1018;2:QUVpBCAaW9S0+WT5JUiArLWw9UXH11AQYHI1SSFzl3yHM6UpRIob8ooxaQDKyUNK+h1iKFq8Sw+X7b9TPIAu3+lWlM+Mu/EBGzrVWCMizor2gmBsAxqSv6CLMBeOjobQL/fAup/sIwdBLQfBFuQ0yg==;3:vMl4CvsG7/d/2TRlo5nOkoOX+hMuIRqzt2aWASMgWnOT64oGDLDFSBBQdzWyShIao83BNBoAmPd5PT90IuSO5rN0stgjnvbyBgVUHFTCTWc1q0AzbookTMjjnFdVd8dq;25:i1I5DaXG+QcQO9AG7azlWnK3RGgFNRU+9vE4xbDWo045eFjlhVR7JGVqMP2X9DP/f7s7eozQXVS7465vP/bmamJH/YBHAyyE+mbOfg6JCqu5c9l7LokrP2SJqcyD5GYScgn46qz0FA2whV0lisJzy9vzo0q1JJ/V21O8pKv6IdiExJpSmTzG/R3Pfw7O1yDq7FkghGAVm4ZCfneAcAZCezyvnRGm87M7k15VKyMafm+w/o2m9X1XvH/3COeZ5rqU X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB1018; X-Microsoft-Exchange-Diagnostics: 1;SG2PR06MB1018;20:prdMjQAGAEB1Bcjv1SJLHEyQ1fx5zdAQgBsvJiEKv/XSzDkpfCSpfLD3DoMaqGZETrmILfI0d+/AeiksuB4EdADL9pCvvS2yhvtarGtQIcyeMusuwNsPYkxX43B0gNfvOlcKnCX5IP8mZ/rLI4TwPIhA5Qg363OFtbEE/bLSUKK+LgUDKabfccfI5XRsJLun/bNhClrKtkac/TCXU9KF6GY8bsJYc+gai2tyN5dGee7nIAQ7Gs3VcByKaxsChim15uBhODyxME8u58bSJD+38kcEitUlNE3vBT42iYpivUTg5T0+jB671aupKNbwzd5MAsi5Zfd6uu40raisPIFsGYEepJIX2CYWbJT1M4wEAahFYaeRUA7pTdF/xKNKMllMDhzl/lL+k7kuDwot7KKSxfBDZshjpnbj5QnwnUdTZIIF9z6UnhpqmbQt+M5Bb1H0Hh1bzmTWTzqJ9yBFlfZMyrby0YF7HEPXMkOi0c8eGLQrZVjMvB/q34M+m5nr3L6p;4:4GD0/7ts9aJ30z4OILWjZse8LDqzf5oQwscC4XYjjObyAZ6fIfRhg3Ff2NdO50FuPKAd0ZExVMgA/jGWkCF4hTqqguvQy9hIVnXGOC3xHF0ji7v0xQR+jZktupxKJDwtuvggKicG+8KcGk6S4Xy7eRcYi7bhWCdwkFTTUb2ecFJpat4iH65hjD0tjR5V8gZCVNCjnUlDcwIcNyuIeng1qYy1Cmbsyu6S59EHFrxwFqOSfvIMxAmoseFAms0WQxRJUDRJRYgw46gTjNcDrkNkrbj2Oe0tBAm9dMwvzn31ot6fdU15mWvFB4DW3zgnVREOV40kwIh9uYYOHQE69mLbJ45kg2nF8cyeDF/X4XbgO3iOGQ2Hf+VZ/TbN/qKFv/1i X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001);SRVR:SG2PR06MB1018;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB1018; X-Forefront-PRVS: 07807C55DC X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(199003)(47776003)(586003)(87976001)(5001960100002)(1096002)(6116002)(110136002)(5004730100002)(97736004)(189998001)(3846002)(5008740100001)(33646002)(4001350100001)(81156007)(23726003)(36756003)(92566002)(77096005)(83506001)(40100003)(76176999)(2950100001)(54356999)(42186005)(46406003)(105586002)(106356001)(53416004)(50986999)(66066001)(101416001)(122386002)(86362001)(69596002)(50466002);DIR:OUT;SFP:1102;SCL:1;SRVR:SG2PR06MB1018;H:morimoto-PC.renesas.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SG2PR06MB1018;23:kGr2lepgDH2eG8f1fHOT045rfJFVlrkNT5shdtWjB?= =?us-ascii?Q?Z7rkkSFZw7ZiEhl1digy6ZZf8vTpwzAoXbugsG7+wUgSEfMcefk0LSozy8DQ?= =?us-ascii?Q?r03dbZpFFaMg0K09hlqcAOkdoeUmxKVWRUSQla5MfxBKBSjxh/UBazb01Bss?= =?us-ascii?Q?7SM0pmcWG9mMz8FlJo8Kfz+Amsba3KQCittU8XaoUwRcqWgQXAS5MljNMQnO?= =?us-ascii?Q?XlRqKTBUHD4pT1UCfFsf0K13e5Dv13+iglXz3Gcqzu46ZZa6W0BraP67mEa3?= =?us-ascii?Q?JxrUeKMMWXdhxfzPOb97MZH7V7oxB08iYCMJCcEJmu0stFIgACvR9w0e4kk7?= =?us-ascii?Q?1DfQ4lbSqTZND0DqrbsOMsmX2KADvy8rwZpViIO6DX2K7rn40YZgiQAjoFXY?= =?us-ascii?Q?KQuuEao+4dlYzA7wz6nh3guBIwssFrOi0VutvEBAB5yuxREVW2pGrMIdtLRF?= =?us-ascii?Q?TPnR/2LOXL79q8pzliFysCd/N4J9CVA4xqubvXWE2JGw45n0XsUoP+afh60v?= =?us-ascii?Q?ZPitRxy5/iWr8pAvtXlak1/OWwFJlmpSAEmPn4uj5ng1youYXql6p+d9k032?= =?us-ascii?Q?fLDu+1fCwwJIdmryHGg6jDfeDmtlyTp0fSbqFmt1OaBJfXtWJBxc7v9HKWso?= =?us-ascii?Q?0OILOfWyKEIfQ7l+S6KNqDyn+vTfZxwOfVIDXOISRIzmKg18R/Y20TkgJY/Z?= =?us-ascii?Q?GhQJkbCtkviOtt5U6cYLbII2pVv5kVPfSbmrQPlxLIFawPw67MsnTebIXA2q?= =?us-ascii?Q?laFb5nD9EF5EFcOU3zZv+whvP/rRfuvwk2xLtzCCZ/03fgFH+J/sj0OGgDFc?= =?us-ascii?Q?NA+KVDLcaoVD91736y/Kiankf1waFH9lIDN5MK64FpqGAy+wHYZtPGfVeaH6?= =?us-ascii?Q?TEJs5Bo+t/2xZaq+MNsv46finuZmygtHqFdbSBXiPhPX3aRo0Qiz5VHM1lBU?= =?us-ascii?Q?CqvaIrrN85n4Vik8Tz92Kkm2/Fqg3QHu3v3ilarqsHg2auflas7ge3Pa2CJ9?= =?us-ascii?Q?8avp5puQttv6w2MyzbfPIvi4ddxYgV7+3r3JhZhudQhHg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;SG2PR06MB1018;5:akC3Q6/tcQb6cJeS8e53p9mwfWQR/pkigsrSL1QmcHCQj7gYn+TZlX/i/paqpMkrvtatiufPiMQI574mixRGpfXKudRmACUdt9y53U0V16Y7UbPTA39etJ2RqnFXo4vB84EVcXQGx3v7qsbYluhggA==;24:YsCmOGvaO2DYGn1BqqpyjQqRYd+zCCN2BTw7S5bHoXRQ+ZQ/IJF4+QzV+URduXw8zlj93i/oTabRHLukZW/6aiANGnysUu5tJtwhRA4K6TY=;20:SqT7ayM7EORbVcdNRdvJ9rfwP0f8wL4m6lpYhImFgj1YI50+mgF1oBa8YwD/Wa62wRazj7XM8cgvtWYZL5YJ/uqfPuKq/owoP33WGMPMrD/xXfVsOFhXX2Cf2+Yap/JwCl11UZNhW0yJ20W7H/lXMcikmTQpGygeTJyUB0ZtCT4= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2015 07:07:54.3133 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB1018 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Manish > > +static int rcar_thermal_of_get_temp(void *data, int *temp) > > +{ > > + struct rcar_thermal_priv *priv = data; > > + > > + *temp = rcar_thermal_get_current_temp(priv); > > + > > + return 0; > > +} > > + > > +static int rcar_thermal_get_temp(struct thermal_zone_device *zone, int *temp) > > +{ > > + struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone); > > + > > + *temp = rcar_thermal_get_current_temp(priv); > > + > > return 0; > > } > > > > Above two function, always returns 0. Can it possible to handle error > and log some messages. Thanks. Will try in v2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH 2/4] thermal: rcar: enable to use thermal-zone on DT Date: Fri, 4 Dec 2015 07:07:54 +0000 Message-ID: <87k2oug0cy.wl%kuninori.morimoto.gx@renesas.com> References: <871tb2hpn2.wl%kuninori.morimoto.gx@renesas.com> <87y4dagb0i.wl%kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Manish Badarkhe Cc: Simon , Zhang Rui , Eduardo Valentin , Magnus , linux-sh@vger.kernel.org, linux-pm@vger.kernel.org, "linux-kernel@vger.kernel.org" List-Id: linux-pm@vger.kernel.org Hi Manish > > +static int rcar_thermal_of_get_temp(void *data, int *temp) > > +{ > > + struct rcar_thermal_priv *priv = data; > > + > > + *temp = rcar_thermal_get_current_temp(priv); > > + > > + return 0; > > +} > > + > > +static int rcar_thermal_get_temp(struct thermal_zone_device *zone, int *temp) > > +{ > > + struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone); > > + > > + *temp = rcar_thermal_get_current_temp(priv); > > + > > return 0; > > } > > > > Above two function, always returns 0. Can it possible to handle error > and log some messages. Thanks. Will try in v2