From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 2/7] drm/i915: Replace the aux ddc name switch statement with kasprintf() Date: Thu, 12 Nov 2015 11:23:13 +0200 Message-ID: <87k2pnh8qm.fsf@intel.com> References: <1447266856-30249-1-git-send-email-ville.syrjala@linux.intel.com> <1447266856-30249-3-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 905F76EC3A for ; Thu, 12 Nov 2015 01:19:13 -0800 (PST) In-Reply-To: <1447266856-30249-3-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAxMSBOb3YgMjAxNSwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3JvdGU6 Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K Pgo+IFVzZSBrYXNwcmludGYoKSB0byBnZW5lcmF0ZSB0aGUgIkRQRERDLTxwb3J0PiIgbmFtZSBm b3IgdGhlIGF1eCBoZWxwZXIuCj4KPiBUbyBkZWFsIHdpdGggZXJyb3JzIHByb3Blcmx5IG1ha2Ug aW50ZWxfZHBfYXV4X2luaXQoKSByZXR1cm4gc29tZXRoaW5nLAo+IGFuZCBhZGp1c3QgdGhlIGNh bGxlciB0byBtYXRjaC4gSXQgc2VlbXMgd2Ugd2VyZSBhbHNvIG1pc3NpbmcgYQo+IGludGVsX2Rw X21zdF9lbmNvZGVyX2NsZWFudXAoKSBjYWxsIG9uIGVkcCAobm9uLXBvcnQgQSkgaW5pdCBmYWls dXJlcywKPiBzbyBhZGQgdGhhdCB0b28uCj4KPiBUaGUgd2hvbGUgZXJyb3IvY2xlYW51cCBvcmRl cmluZyBkb2Vzbid0IGZlZWwgZW50aXJlbHkgc2FuZSB0byBtZSwgYnV0Cj4gSSdsbCBsZWF2ZSB0 aGF0IHBhcnQgYWxvbmUgZm9yIG5vdy4KPgo+IHYyOiBVc2Uga2FzcHJpbnRmKCkgaW5zdGVhZCBv ZiBhIHRhYmxlLCByZW9yZGVyIHBhdGNoZXMgKENoaXMpCj4KPiBDYzogQ2hyaXMgV2lsc29uIDxj aHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOk IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHAuYyB8IDc1ICsrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0t LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0NiBpbnNlcnRpb25zKCspLCAyOSBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4IDg5MWE3ZjguLmRmMmEyZDIgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBAQCAtMTAwOSw2ICsxMDA5LDEzIEBAIGludGVs X2RwX2F1eF90cmFuc2ZlcihzdHJ1Y3QgZHJtX2RwX2F1eCAqYXV4LCBzdHJ1Y3QgZHJtX2RwX2F1 eF9tc2cgKm1zZykKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQKPiAraW50ZWxfZHBfYXV4X2Zpbmko c3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiArewo+ICsJZHJtX2RwX2F1eF91bnJlZ2lzdGVy KCZpbnRlbF9kcC0+YXV4KTsKPiArCWtmcmVlKGludGVsX2RwLT5hdXgubmFtZSk7Cj4gK30KPiAr Cj4gK3N0YXRpYyBpbnQKPiAgaW50ZWxfZHBfYXV4X2luaXQoc3RydWN0IGludGVsX2RwICppbnRl bF9kcCwgc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICB7Cj4gIAlzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2ID0gaW50ZWxfZHBfdG9fZGV2KGludGVsX2RwKTsKPiBAQCAtMTAxNiw3 ICsxMDIzLDYgQEAgaW50ZWxfZHBfYXV4X2luaXQoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwg c3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICAJc3RydWN0IGludGVsX2RpZ2l0 YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQgPSBkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7Cj4gIAll bnVtIHBvcnQgcG9ydCA9IGludGVsX2RpZ19wb3J0LT5wb3J0Owo+ICAJc3RydWN0IGRkaV92YnRf cG9ydF9pbmZvICppbmZvID0gJmRldl9wcml2LT52YnQuZGRpX3BvcnRfaW5mb1twb3J0XTsKPiAt CWNvbnN0IGNoYXIgKm5hbWUgPSBOVUxMOwo+ICAJdWludDMyX3QgcG9ydGVfYXV4X2N0bF9yZWcg PSBEUEFfQVVYX0NIX0NUTDsKPiAgCWludCByZXQ7Cj4gIAo+IEBAIC0xMDQzLDIzICsxMDQ5LDE4 IEBAIGludGVsX2RwX2F1eF9pbml0KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHN0cnVjdCBp bnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiAgCXN3aXRjaCAocG9ydCkgewo+ICAJY2FzZSBQ T1JUX0E6Cj4gIAkJaW50ZWxfZHAtPmF1eF9jaF9jdGxfcmVnID0gRFBBX0FVWF9DSF9DVEw7Cj4g LQkJbmFtZSA9ICJEUEREQy1BIjsKPiAgCQlicmVhazsKPiAgCWNhc2UgUE9SVF9COgo+ICAJCWlu dGVsX2RwLT5hdXhfY2hfY3RsX3JlZyA9IFBDSF9EUEJfQVVYX0NIX0NUTDsKPiAtCQluYW1lID0g IkRQRERDLUIiOwo+ICAJCWJyZWFrOwo+ICAJY2FzZSBQT1JUX0M6Cj4gIAkJaW50ZWxfZHAtPmF1 eF9jaF9jdGxfcmVnID0gUENIX0RQQ19BVVhfQ0hfQ1RMOwo+IC0JCW5hbWUgPSAiRFBEREMtQyI7 Cj4gIAkJYnJlYWs7Cj4gIAljYXNlIFBPUlRfRDoKPiAgCQlpbnRlbF9kcC0+YXV4X2NoX2N0bF9y ZWcgPSBQQ0hfRFBEX0FVWF9DSF9DVEw7Cj4gLQkJbmFtZSA9ICJEUEREQy1EIjsKPiAgCQlicmVh azsKPiAgCWNhc2UgUE9SVF9FOgo+ICAJCWludGVsX2RwLT5hdXhfY2hfY3RsX3JlZyA9IHBvcnRl X2F1eF9jdGxfcmVnOwo+IC0JCW5hbWUgPSAiRFBEREMtRSI7Cj4gIAkJYnJlYWs7Cj4gIAlkZWZh dWx0Ogo+ICAJCUJVRygpOwo+IEBAIC0xMDc3LDI3ICsxMDc4LDM2IEBAIGludGVsX2RwX2F1eF9p bml0KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNv bm5lY3RvcikKPiAgCWlmICghSVNfSEFTV0VMTChkZXYpICYmICFJU19CUk9BRFdFTEwoZGV2KSAm JiBwb3J0ICE9IFBPUlRfRSkKPiAgCQlpbnRlbF9kcC0+YXV4X2NoX2N0bF9yZWcgPSBpbnRlbF9k cC0+b3V0cHV0X3JlZyArIDB4MTA7Cj4gIAo+IC0JaW50ZWxfZHAtPmF1eC5uYW1lID0gbmFtZTsK PiArCWludGVsX2RwLT5hdXgubmFtZSA9IGthc3ByaW50ZihHRlBfS0VSTkVMLCAiRFBEREMtJWMi LCBwb3J0X25hbWUocG9ydCkpOwo+ICsJaWYgKCFpbnRlbF9kcC0+YXV4Lm5hbWUpCj4gKwkJcmV0 dXJuIC1FTk9NRU07Cj4gKwo+ICAJaW50ZWxfZHAtPmF1eC5kZXYgPSBkZXYtPmRldjsKPiAgCWlu dGVsX2RwLT5hdXgudHJhbnNmZXIgPSBpbnRlbF9kcF9hdXhfdHJhbnNmZXI7Cj4gIAo+IC0JRFJN X0RFQlVHX0tNUygicmVnaXN0ZXJpbmcgJXMgYnVzIGZvciAlc1xuIiwgbmFtZSwKPiArCURSTV9E RUJVR19LTVMoInJlZ2lzdGVyaW5nICVzIGJ1cyBmb3IgJXNcbiIsCj4gKwkJICAgICAgaW50ZWxf ZHAtPmF1eC5uYW1lLAo+ICAJCSAgICAgIGNvbm5lY3Rvci0+YmFzZS5rZGV2LT5rb2JqLm5hbWUp Owo+ICAKPiAgCXJldCA9IGRybV9kcF9hdXhfcmVnaXN0ZXIoJmludGVsX2RwLT5hdXgpOwo+ICAJ aWYgKHJldCA8IDApIHsKPiAgCQlEUk1fRVJST1IoImRybV9kcF9hdXhfcmVnaXN0ZXIoKSBmb3Ig JXMgZmFpbGVkICglZClcbiIsCj4gLQkJCSAgbmFtZSwgcmV0KTsKPiAtCQlyZXR1cm47Cj4gKwkJ CSAgaW50ZWxfZHAtPmF1eC5uYW1lLCByZXQpOwo+ICsJCWtmcmVlKGludGVsX2RwLT5hdXgubmFt ZSk7Cj4gKwkJcmV0dXJuIHJldDsKPiAgCX0KPiAgCj4gIAlyZXQgPSBzeXNmc19jcmVhdGVfbGlu aygmY29ubmVjdG9yLT5iYXNlLmtkZXYtPmtvYmosCj4gIAkJCQkmaW50ZWxfZHAtPmF1eC5kZGMu ZGV2LmtvYmosCj4gIAkJCQlpbnRlbF9kcC0+YXV4LmRkYy5kZXYua29iai5uYW1lKTsKPiAgCWlm IChyZXQgPCAwKSB7Cj4gLQkJRFJNX0VSUk9SKCJzeXNmc19jcmVhdGVfbGluaygpIGZvciAlcyBm YWlsZWQgKCVkKVxuIiwgbmFtZSwgcmV0KTsKPiAtCQlkcm1fZHBfYXV4X3VucmVnaXN0ZXIoJmlu dGVsX2RwLT5hdXgpOwo+ICsJCURSTV9FUlJPUigic3lzZnNfY3JlYXRlX2xpbmsoKSBmb3IgJXMg ZmFpbGVkICglZClcbiIsCj4gKwkJCSAgaW50ZWxfZHAtPmF1eC5uYW1lLCByZXQpOwo+ICsJCWlu dGVsX2RwX2F1eF9maW5pKGludGVsX2RwKTsKPiArCQlyZXR1cm4gcmV0Owo+ICAJfQo+ICsKPiAr CXJldHVybiAwOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZAo+IEBAIC00NzcxLDcgKzQ3ODEsNyBA QCB2b2lkIGludGVsX2RwX2VuY29kZXJfZGVzdHJveShzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29k ZXIpCj4gIAlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICppbnRlbF9kaWdfcG9ydCA9IGVuY190 b19kaWdfcG9ydChlbmNvZGVyKTsKPiAgCXN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAgPSAmaW50 ZWxfZGlnX3BvcnQtPmRwOwo+ICAKPiAtCWRybV9kcF9hdXhfdW5yZWdpc3RlcigmaW50ZWxfZHAt PmF1eCk7Cj4gKwlpbnRlbF9kcF9hdXhfZmluaShpbnRlbF9kcCk7Cj4gIAlpbnRlbF9kcF9tc3Rf ZW5jb2Rlcl9jbGVhbnVwKGludGVsX2RpZ19wb3J0KTsKPiAgCWlmIChpc19lZHAoaW50ZWxfZHAp KSB7Cj4gIAkJY2FuY2VsX2RlbGF5ZWRfd29ya19zeW5jKCZpbnRlbF9kcC0+cGFuZWxfdmRkX3dv cmspOwo+IEBAIC01NzUyLDcgKzU3NjIsNyBAQCBpbnRlbF9kcF9pbml0X2Nvbm5lY3RvcihzdHJ1 Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICppbnRlbF9kaWdfcG9ydCwKPiAgCXN0cnVjdCBkcm1fZGV2 aWNlICpkZXYgPSBpbnRlbF9lbmNvZGVyLT5iYXNlLmRldjsKPiAgCXN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gIAllbnVtIHBvcnQgcG9ydCA9 IGludGVsX2RpZ19wb3J0LT5wb3J0Owo+IC0JaW50IHR5cGU7Cj4gKwlpbnQgdHlwZSwgcmV0Owo+ ICAKPiAgCWludGVsX2RwLT5wcHNfcGlwZSA9IElOVkFMSURfUElQRTsKPiAgCj4gQEAgLTU4NTMs NyArNTg2Myw5IEBAIGludGVsX2RwX2luaXRfY29ubmVjdG9yKHN0cnVjdCBpbnRlbF9kaWdpdGFs X3BvcnQgKmludGVsX2RpZ19wb3J0LAo+ICAJCXBwc191bmxvY2soaW50ZWxfZHApOwo+ICAJfQo+ ICAKPiAtCWludGVsX2RwX2F1eF9pbml0KGludGVsX2RwLCBpbnRlbF9jb25uZWN0b3IpOwo+ICsJ cmV0ID0gaW50ZWxfZHBfYXV4X2luaXQoaW50ZWxfZHAsIGludGVsX2Nvbm5lY3Rvcik7Cj4gKwlp ZiAocmV0KQo+ICsJCWdvdG8gZmFpbDsKPiAgCj4gIAkvKiBpbml0IE1TVCBvbiBwb3J0cyB0aGF0 IGNhbiBzdXBwb3J0IGl0ICovCj4gIAlpZiAoSEFTX0RQX01TVChkZXYpICYmCj4gQEAgLTU4NjIs MjAgKzU4NzQsOSBAQCBpbnRlbF9kcF9pbml0X2Nvbm5lY3RvcihzdHJ1Y3QgaW50ZWxfZGlnaXRh bF9wb3J0ICppbnRlbF9kaWdfcG9ydCwKPiAgCQkJCQkgIGludGVsX2Nvbm5lY3Rvci0+YmFzZS5i YXNlLmlkKTsKPiAgCj4gIAlpZiAoIWludGVsX2VkcF9pbml0X2Nvbm5lY3RvcihpbnRlbF9kcCwg aW50ZWxfY29ubmVjdG9yKSkgewo+IC0JCWRybV9kcF9hdXhfdW5yZWdpc3RlcigmaW50ZWxfZHAt PmF1eCk7Cj4gLQkJaWYgKGlzX2VkcChpbnRlbF9kcCkpIHsKPiAtCQkJY2FuY2VsX2RlbGF5ZWRf d29ya19zeW5jKCZpbnRlbF9kcC0+cGFuZWxfdmRkX3dvcmspOwo+IC0JCQkvKgo+IC0JCQkgKiB2 ZGQgbWlnaHQgc3RpbGwgYmUgZW5hYmxlZCBkbyB0byB0aGUgZGVsYXllZCB2ZGQgb2ZmLgo+IC0J CQkgKiBNYWtlIHN1cmUgdmRkIGlzIGFjdHVhbGx5IHR1cm5lZCBvZmYgaGVyZS4KPiAtCQkJICov Cj4gLQkJCXBwc19sb2NrKGludGVsX2RwKTsKPiAtCQkJZWRwX3BhbmVsX3ZkZF9vZmZfc3luYyhp bnRlbF9kcCk7Cj4gLQkJCXBwc191bmxvY2soaW50ZWxfZHApOwo+IC0JCX0KPiAtCQlkcm1fY29u bmVjdG9yX3VucmVnaXN0ZXIoY29ubmVjdG9yKTsKPiAtCQlkcm1fY29ubmVjdG9yX2NsZWFudXAo Y29ubmVjdG9yKTsKPiAtCQlyZXR1cm4gZmFsc2U7Cj4gKwkJaW50ZWxfZHBfYXV4X2ZpbmkoaW50 ZWxfZHApOwo+ICsJCWludGVsX2RwX21zdF9lbmNvZGVyX2NsZWFudXAoaW50ZWxfZGlnX3BvcnQp Owo+ICsJCWdvdG8gZmFpbDsKPiAgCX0KPiAgCj4gIAlpbnRlbF9kcF9hZGRfcHJvcGVydGllcyhp bnRlbF9kcCwgY29ubmVjdG9yKTsKPiBAQCAtNTg5Miw2ICs1ODkzLDIyIEBAIGludGVsX2RwX2lu aXRfY29ubmVjdG9yKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0LAo+ ICAJaTkxNV9kZWJ1Z2ZzX2Nvbm5lY3Rvcl9hZGQoY29ubmVjdG9yKTsKPiAgCj4gIAlyZXR1cm4g dHJ1ZTsKPiArCj4gK2ZhaWw6Cj4gKwlpZiAoaXNfZWRwKGludGVsX2RwKSkgewo+ICsJCWNhbmNl bF9kZWxheWVkX3dvcmtfc3luYygmaW50ZWxfZHAtPnBhbmVsX3ZkZF93b3JrKTsKPiArCQkvKgo+ ICsJCSAqIHZkZCBtaWdodCBzdGlsbCBiZSBlbmFibGVkIGRvIHRvIHRoZSBkZWxheWVkIHZkZCBv ZmYuCj4gKwkJICogTWFrZSBzdXJlIHZkZCBpcyBhY3R1YWxseSB0dXJuZWQgb2ZmIGhlcmUuCj4g KwkJICovCj4gKwkJcHBzX2xvY2soaW50ZWxfZHApOwo+ICsJCWVkcF9wYW5lbF92ZGRfb2ZmX3N5 bmMoaW50ZWxfZHApOwo+ICsJCXBwc191bmxvY2soaW50ZWxfZHApOwo+ICsJfQoKQSBmb2xsb3ct dXAgbWlnaHQgYWJzdHJhY3QgdGhpcyBzZXF1ZW5jZSBhcyB0aGVyZSdzIHRocmVlIGNvcGllcyBu b3cuCgpSZXZpZXdlZC1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KCgo+ ICsJZHJtX2Nvbm5lY3Rvcl91bnJlZ2lzdGVyKGNvbm5lY3Rvcik7Cj4gKwlkcm1fY29ubmVjdG9y X2NsZWFudXAoY29ubmVjdG9yKTsKPiArCj4gKwlyZXR1cm4gZmFsc2U7Cj4gIH0KPiAgCj4gIHZv aWQKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK