From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHveR-0004QE-D3 for qemu-devel@nongnu.org; Tue, 19 Mar 2013 08:28:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHveM-0003sm-Ar for qemu-devel@nongnu.org; Tue, 19 Mar 2013 08:28:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHveM-0003s3-40 for qemu-devel@nongnu.org; Tue, 19 Mar 2013 08:28:18 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2JCSG0O027802 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Mar 2013 08:28:16 -0400 From: Markus Armbruster References: Date: Tue, 19 Mar 2013 13:28:14 +0100 In-Reply-To: (Michal Novotny's message of "Tue, 12 Mar 2013 17:02:16 +0100") Message-ID: <87k3p3bmld.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] Introduce query-cpu-max QMP command and cpu_max HMP counterpart List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Novotny Cc: qemu-devel@nongnu.org, Luiz Capitulino Please cc: Luiz and me on QMP work in the future. Michal Novotny writes: > This is the patch to introduce the query-cpu-max QMP command to get > the maximum number of CPUs supported by the currently running emulator > instance. This may differ machine from machine as defined by -machine > settings and max_cpus member of QEMUMachine structure. Humor me: don't start commit message bodies with "This patch" or variations thereof, and don't repeat the subject. Suggest: QMP command query-cpu-max returns the maximum number of CPUs supported by the currently running emulator instance, as defined in its QEMUMachine struct. > It's been tested both using QMP/qmp utility and telnet session on > the QEMU session. What's a QMP/qmp utility? Let's drop this sentence. In the future, feel free to put testing info below the "---" line. > The HMP counterpart called cpu_max has been introduced by this patch > too. Grammar nit: s/has been/is/. Even better, avoid passive voice. Hmm, I just rewrote most of your commit message, so why not rewrite all of it: New QMP command query-cpu-max and HMP command cpu_max These commands return the maximum number of CPUs supported by the currently running emulator instance, as defined in its QEMUMachine struct. Perhaps Luiz can fix up the commit message commit, if you don't mind. Patch looks good. Should query commands for machine properties multiply, we should consider creating a single command returning all of them. I'm not asking you to do that now. Reviewed-by: Markus Armbruster