From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753014Ab2KEDYW (ORCPT ); Sun, 4 Nov 2012 22:24:22 -0500 Received: from ozlabs.org ([203.10.76.45]:48565 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752423Ab2KEDYT convert rfc822-to-8bit (ORCPT ); Sun, 4 Nov 2012 22:24:19 -0500 From: Rusty Russell To: Lee Jones , linux-kernel@vger.kernel.org Cc: Lee Jones , virtualization@lists.linux-foundation.org Subject: Re: [PATCH 6/9] virtio_mmio: Cast &resources[1].start to =?utf-8?Q?=E2=80=98unsigned?= int =?utf-8?Q?*=E2=80=99?= to rid compiler warning In-Reply-To: <1351980150-24145-7-git-send-email-lee.jones@linaro.org> References: <1351980150-24145-1-git-send-email-lee.jones@linaro.org> <1351980150-24145-7-git-send-email-lee.jones@linaro.org> User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) Date: Mon, 05 Nov 2012 13:08:57 +1030 Message-ID: <87k3u0ydry.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lee Jones writes: > drivers/virtio/virtio_mmio.c: In function ‘vm_cmdline_set’: > drivers/virtio/virtio_mmio.c:535:4: warning: format ‘%u’ expects argument of type ‘unsigned int *’, but argument 4 has type ‘resource_size_t *’ [-Wformat] > > Cc: Rusty Russell > Cc: virtualization@lists.linux-foundation.org > Signed-off-by: Lee Jones > --- > drivers/virtio/virtio_mmio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c > index 6b1b7e1..077e9ca 100644 > --- a/drivers/virtio/virtio_mmio.c > +++ b/drivers/virtio/virtio_mmio.c > @@ -531,7 +531,7 @@ static int vm_cmdline_set(const char *device, > resources[0].end = memparse(device, &str) - 1; > > processed = sscanf(str, "@%lli:%u%n:%d%n", > - &base, &resources[1].start, &consumed, > + &base, (unsigned int *)&resources[1].start, &consumed, > &vm_cmdline_id, &consumed); This suppresses a valid warning, leaving our code no less wrong than before. But now it's silently wrong! Do you want to try again? Cheers, Rusty. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH 6/9] virtio_mmio: Cast &resources[1].start to =?utf-8?Q?=E2=80=98unsigned?= int =?utf-8?Q?*=E2=80=99?= to rid compiler warning Date: Mon, 05 Nov 2012 13:08:57 +1030 Message-ID: <87k3u0ydry.fsf@rustcorp.com.au> References: <1351980150-24145-1-git-send-email-lee.jones@linaro.org> <1351980150-24145-7-git-send-email-lee.jones@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1351980150-24145-7-git-send-email-lee.jones@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: linux-kernel@vger.kernel.org Cc: Lee Jones , virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org TGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4gd3JpdGVzOgo+IGRyaXZlcnMvdmlydGlv L3ZpcnRpb19tbWlvLmM6IEluIGZ1bmN0aW9uIOKAmHZtX2NtZGxpbmVfc2V04oCZOgo+IGRyaXZl cnMvdmlydGlvL3ZpcnRpb19tbWlvLmM6NTM1OjQ6IHdhcm5pbmc6IGZvcm1hdCDigJgldeKAmSBl eHBlY3RzIGFyZ3VtZW50IG9mIHR5cGUg4oCYdW5zaWduZWQgaW50ICrigJksIGJ1dCBhcmd1bWVu dCA0IGhhcyB0eXBlIOKAmHJlc291cmNlX3NpemVfdCAq4oCZIFstV2Zvcm1hdF0KPgo+IENjOiBS dXN0eSBSdXNzZWxsIDxydXN0eUBydXN0Y29ycC5jb20uYXU+Cj4gQ2M6IHZpcnR1YWxpemF0aW9u QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCj4gU2lnbmVkLW9mZi1ieTogTGVlIEpvbmVzIDxs ZWUuam9uZXNAbGluYXJvLm9yZz4KPiAtLS0KPiAgZHJpdmVycy92aXJ0aW8vdmlydGlvX21taW8u YyB8ICAgIDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9u KC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aXJ0aW8vdmlydGlvX21taW8uYyBiL2RyaXZl cnMvdmlydGlvL3ZpcnRpb19tbWlvLmMKPiBpbmRleCA2YjFiN2UxLi4wNzdlOWNhIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvdmlydGlvL3ZpcnRpb19tbWlvLmMKPiArKysgYi9kcml2ZXJzL3ZpcnRp by92aXJ0aW9fbW1pby5jCj4gQEAgLTUzMSw3ICs1MzEsNyBAQCBzdGF0aWMgaW50IHZtX2NtZGxp bmVfc2V0KGNvbnN0IGNoYXIgKmRldmljZSwKPiAgCXJlc291cmNlc1swXS5lbmQgPSBtZW1wYXJz ZShkZXZpY2UsICZzdHIpIC0gMTsKPiAgCj4gIAlwcm9jZXNzZWQgPSBzc2NhbmYoc3RyLCAiQCVs bGk6JXUlbjolZCVuIiwKPiAtCQkJJmJhc2UsICZyZXNvdXJjZXNbMV0uc3RhcnQsICZjb25zdW1l ZCwKPiArCQkJJmJhc2UsICh1bnNpZ25lZCBpbnQgKikmcmVzb3VyY2VzWzFdLnN0YXJ0LCAmY29u c3VtZWQsCj4gIAkJCSZ2bV9jbWRsaW5lX2lkLCAmY29uc3VtZWQpOwoKVGhpcyBzdXBwcmVzc2Vz IGEgdmFsaWQgd2FybmluZywgbGVhdmluZyBvdXIgY29kZSBubyBsZXNzIHdyb25nIHRoYW4KYmVm b3JlLiAgQnV0IG5vdyBpdCdzIHNpbGVudGx5IHdyb25nIQoKRG8geW91IHdhbnQgdG8gdHJ5IGFn YWluPwoKQ2hlZXJzLApSdXN0eS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxp c3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u