From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753679Ab1KCAGS (ORCPT ); Wed, 2 Nov 2011 20:06:18 -0400 Received: from ozlabs.org ([203.10.76.45]:52643 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752923Ab1KCAGP (ORCPT ); Wed, 2 Nov 2011 20:06:15 -0400 From: Rusty Russell To: Stephen Boyd , Joe Perches Cc: Miche Baker-Harvey , Konrad Rzeszutek Wilk , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, Amit Shah , Anton Blanchard , Benjamin Herrenschmidt , virtualization@lists.linux-foundation.org, Hendrik Brueckner , Christian Borntraeger Subject: Re: [PATCH] VirtioConsole support. In-Reply-To: <4EAAF23C.8050102@codeaurora.org> References: <20111027173527.GA23839@phenom.dumpdata.com> <1319751802-27013-1-git-send-email-miche@google.com> <1319770558.2529.20.camel@Joe-Laptop> <4EAAF23C.8050102@codeaurora.org> User-Agent: Notmuch/0.6.1-1 (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) Date: Thu, 03 Nov 2011 08:32:13 +1030 Message-ID: <87k47itc7u.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Oct 2011 11:19:40 -0700, Stephen Boyd wrote: > Even better would be kmemdup(). OK, this driver is horribly unloved, and ugly. Noone claims to really understand it, but people keep poking it. Ben, Christian, can you figure out what's going on? Is it time for a complete rewrite? Thanks, Rusty. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH] VirtioConsole support. Date: Thu, 03 Nov 2011 08:32:13 +1030 Message-ID: <87k47itc7u.fsf@rustcorp.com.au> References: <20111027173527.GA23839@phenom.dumpdata.com> <1319751802-27013-1-git-send-email-miche@google.com> <1319770558.2529.20.camel@Joe-Laptop> <4EAAF23C.8050102@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4EAAF23C.8050102@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Stephen Boyd , Joe Perches Cc: xen-devel@lists.xensource.com, Konrad Rzeszutek Wilk , Benjamin Herrenschmidt , Greg Kroah-Hartman , Miche Baker-Harvey , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Christian Borntraeger , Hendrik Brueckner , Anton Blanchard , Amit Shah List-Id: virtualization@lists.linuxfoundation.org On Fri, 28 Oct 2011 11:19:40 -0700, Stephen Boyd wrote: > Even better would be kmemdup(). OK, this driver is horribly unloved, and ugly. Noone claims to really understand it, but people keep poking it. Ben, Christian, can you figure out what's going on? Is it time for a complete rewrite? Thanks, Rusty.