Re: [pm_wip/voltdm_nm][PATCH v2 3/3] OMAP4: PM: VC: make omap_vc_i2c_init static

From: Kevin Hilman <khilman@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [pm_wip/voltdm_nm][PATCH v2 3/3] OMAP4: PM: VC: make omap_vc_i2c_init static
Date: Thu, 02 Jun 2011 16:47:21 -0700	[thread overview]
Message-ID: <87k4d3n6d2.fsf@ti.com> (raw)
In-Reply-To: <1306711180-8631-4-git-send-email-nm@ti.com> (Nishanth Menon's message of "Sun, 29 May 2011 16:19:40 -0700")

Nishanth Menon <nm@ti.com> writes:

> The only user of omap_vc_i2c_init is vc.c itself, makes
> no reason for us to expose it out.
>
> This also fixes the sparse warning:
> arch/arm/mach-omap2/vc.c:207:13: warning: symbol 'omap_vc_i2c_init' was not declared. Should it be static?
>
> Signed-off-by: Nishanth Menon <nm@ti.com>

Thanks, will fold into 'OMAP3+: VC: make I2C config programmable with
PMIC-specific settings'

Kevin

> ---
>  arch/arm/mach-omap2/vc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c
> index 42c77a8..d0b52cc 100644
> --- a/arch/arm/mach-omap2/vc.c
> +++ b/arch/arm/mach-omap2/vc.c
> @@ -204,7 +204,7 @@ static void __init omap4_vc_init_channel(struct voltagedomain *voltdm)
>   * channel registers.  All other VC channels will use the
>   * same configuration.
>   */
> -void __init omap_vc_i2c_init(struct voltagedomain *voltdm)
> +static void __init omap_vc_i2c_init(struct voltagedomain *voltdm)
>  {
>  	struct omap_vc_channel *vc = voltdm->vc;
>  	static bool initialized;