Re: [PATCH] format shell command as code block

[Jonathan Corbet <corbet@lwn.net>]

Weiji Wang <nebclllo0444@gmail.com> writes:

> This formats the last two shell commands in
> Documentation/admin-guide/mm/zswap.rst as code blocks.
>
> ---
>  Documentation/admin-guide/mm/zswap.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

The *idea* of the change is fine, but there are a couple of problems
here.  I can't take a patch without a signed-off-by line, so you'll need
to resubmit with that.

> diff --git a/Documentation/admin-guide/mm/zswap.rst b/Documentation/admin-guide/mm/zswap.rst
> index b42132969..85612d705 100644
> --- a/Documentation/admin-guide/mm/zswap.rst
> +++ b/Documentation/admin-guide/mm/zswap.rst
> @@ -155,7 +155,7 @@ Setting this parameter to 100 will disable the hysteresis.
>  
>  Some users cannot tolerate the swapping that comes with zswap store failures
>  and zswap writebacks. Swapping can be disabled entirely (without disabling
> -zswap itself) on a cgroup-basis as follows:
> +zswap itself) on a cgroup-basis as follows:::
>  
>  	echo 0 > /sys/fs/cgroup/<cgroup-name>/memory.zswap.writeback

Why three colons?  "as follows::" will do what you want.

Thanks,

jon