From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44E66C7EE23 for ; Sun, 4 Jun 2023 11:20:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E3A7A41B92; Sun, 4 Jun 2023 11:20:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org E3A7A41B92 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jS-artHO6Wzq; Sun, 4 Jun 2023 11:20:40 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id D635B41B87; Sun, 4 Jun 2023 11:20:38 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D635B41B87 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 3E28E1BF2B1 for ; Sun, 4 Jun 2023 11:20:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 15BF6832EA for ; Sun, 4 Jun 2023 11:20:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 15BF6832EA X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xTrbjY4Jp4QU for ; Sun, 4 Jun 2023 11:20:36 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 290708328E Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by smtp1.osuosl.org (Postfix) with ESMTPS id 290708328E for ; Sun, 4 Jun 2023 11:20:35 +0000 (UTC) X-GND-Sasl: peter@korsgaard.com X-GND-Sasl: peter@korsgaard.com X-GND-Sasl: peter@korsgaard.com X-GND-Sasl: peter@korsgaard.com X-GND-Sasl: peter@korsgaard.com X-GND-Sasl: peter@korsgaard.com X-GND-Sasl: peter@korsgaard.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 8FBBC1C0004; Sun, 4 Jun 2023 11:20:31 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1q5lmg-00Cv8G-I7; Sun, 04 Jun 2023 13:20:30 +0200 From: Peter Korsgaard To: Arnout Vandecappelle References: <20230510202434.13975-1-ps.report@gmx.net> <57ffa030-89c0-cb57-b7b2-cc8ffa452d01@mind.be> Date: Sun, 04 Jun 2023 13:20:30 +0200 In-Reply-To: <57ffa030-89c0-cb57-b7b2-cc8ffa452d01@mind.be> (Arnout Vandecappelle's message of "Sat, 3 Jun 2023 22:41:25 +0200") Message-ID: <87legza2yp.fsf@48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Subject: Re: [Buildroot] [RFC v1] package/coreutils: needs toolchain headers >= 5.6 (32-bit system with 64-bit time_t) X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julien Olivain , Peter Seiderer , Thomas Petazzoni , buildroot@buildroot.org, Romain Naour , "Yann E. MORIN" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Arnout" == Arnout Vandecappelle writes: Hi, > Because of all this complexity, I think it's better to introduce > something like BR2_TOOLCHAIN_HAS_TIME_T_64 that encodes those > conditions. It would be a blind symbol that defaults y for 64-bit > architectures and is selected by the respective arch or toolchain > symbols. It's a bit complicated that way, but gives us most > flexibility to get all the conditions right. For instance, in external > toolchains it would only be selected if glibc is sufficiently recent. > Therefore, I've marked this patch as Changes Requested. But I also > added the other matinainters in Cc because they may have different > opinions. No, I agree - Nice summary! -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot