From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 254F1C001B2 for ; Fri, 16 Dec 2022 11:53:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230413AbiLPLxJ (ORCPT ); Fri, 16 Dec 2022 06:53:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230245AbiLPLxI (ORCPT ); Fri, 16 Dec 2022 06:53:08 -0500 X-Greylist: delayed 519 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 16 Dec 2022 03:53:04 PST Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B42DB28E39; Fri, 16 Dec 2022 03:53:04 -0800 (PST) Received: from frontend03.mail.m-online.net (unknown [192.168.6.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4NYS1Z2q08z1sBpp; Fri, 16 Dec 2022 12:44:18 +0100 (CET) Received: from localhost (dynscan3.mnet-online.de [192.168.6.84]) by mail.m-online.net (Postfix) with ESMTP id 4NYS1Y75Y5z1qqlR; Fri, 16 Dec 2022 12:44:17 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new, port 10024) with ESMTP id 0b5ZjKHkwL_v; Fri, 16 Dec 2022 12:44:16 +0100 (CET) X-Auth-Info: f4ezSsfKVzN9CazZHPLG18zOuZzzKP8PLF09Joa2rcSALQhcCh1YnQT2Bkw3vKhq Received: from igel.home (aftr-62-216-205-197.dynamic.mnet-online.de [62.216.205.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 16 Dec 2022 12:44:16 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 1913F2C339A; Fri, 16 Dec 2022 12:44:16 +0100 (CET) From: Andreas Schwab To: Geert Uytterhoeven Cc: "Leizhen (ThunderTown)" , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Masahiro Yamada , Alexei Starovoitov , Jiri Olsa , Kees Cook , Andrew Morton , Luis Chamberlain , linux-modules@vger.kernel.org, Steven Rostedt , Ingo Molnar , David Laight , linux-m68k , "Jason A. Donenfeld" Subject: Re: [PATCH v9] kallsyms: Add self-test facility References: <20221115083349.1662-1-thunder.leizhen@huawei.com> X-Yow: What GOOD is a CARDBOARD suitcase ANYWAY? Date: Fri, 16 Dec 2022 12:44:16 +0100 In-Reply-To: (Geert Uytterhoeven's message of "Thu, 15 Dec 2022 14:24:51 +0100") Message-ID: <87len7k1yn.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: On Dez 15 2022, Geert Uytterhoeven wrote: > Changing: > > --- a/arch/m68k/include/asm/string.h > +++ b/arch/m68k/include/asm/string.h > @@ -42,7 +42,7 @@ static inline char *strncpy(char *dest, const > char *src, size_t n) > #define __HAVE_ARCH_STRCMP > static inline int strcmp(const char *cs, const char *ct) > { > - char res; > + signed char res; > > asm ("\n" > "1: move.b (%0)+,%2\n" /* get *cs */ Note that strcmp needs to compute the return value from the difference of the _unsigned_ characters. That does not explain the error, though, since symbol names don't have characters with the high bit set. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."