From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43BD1ECAAD3 for ; Wed, 14 Sep 2022 20:43:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C93010E9FD; Wed, 14 Sep 2022 20:43:13 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 266A510E9FD for ; Wed, 14 Sep 2022 20:43:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663188190; x=1694724190; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=dV8fPbEJd8MYO+g3kXjHcohfmBaogWkqkWQVpJI0Juk=; b=G1WVKuuVBT/FJl2IfVO553NfFmMhG1P5w3I8dP/F3ct7WPKziZIZ10zk 0Ys7ICDiAygy5lrF7wkhFFja/BILpr4PZn+DG31hwCkZAPAi6YZYyJMhE I7GVBB1vWyZjymaD778KIiPt30QqdAqWfHZoO1mkwTGOFCR53d0gPHTPc auPUVX1X6rKgf5n9YR0wyYDwuxPRzzWvL8V6ur+cTra6e0CpMPbkFjafu HitxNYoLMAEaNCaNUxZ8XulaWVACeF21MAygwv0thxM2wa3s0bggCY6+u 51du3FEPp8NHJJbWhmhFnO2tB2T9CBnWenz3/9/rhvpsKhGPPiAJ599Ex Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10470"; a="299350094" X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="299350094" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2022 13:43:09 -0700 X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="862075109" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.38.224]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2022 13:43:09 -0700 Date: Wed, 14 Sep 2022 13:43:08 -0700 Message-ID: <87leql4rhf.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa In-Reply-To: <20220823204155.8178-12-umesh.nerlige.ramappa@intel.com> References: <20220823204155.8178-1-umesh.nerlige.ramappa@intel.com> <20220823204155.8178-12-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 11/19] drm/i915/perf: Store a pointer to oa_format in oa_buffer X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 23 Aug 2022 13:41:47 -0700, Umesh Nerlige Ramappa wrote: > > @@ -3184,15 +3184,12 @@ static int i915_oa_stream_init(struct i915_perf_stream *stream, > stream->sample_flags = props->sample_flags; > stream->sample_size += format_size; > > - stream->oa_buffer.format_size = format_size; > - if (drm_WARN_ON(&i915->drm, stream->oa_buffer.format_size == 0)) > + stream->oa_buffer.format = &perf->oa_formats[props->oa_format]; > + if (drm_WARN_ON(&i915->drm, stream->oa_buffer.format->size == 0)) > return -EINVAL; I would also move these 3 lines before the two lines on the top, eliminate the format_size variable and assignment and just use stream->oa_buffer.format->size. Otherwise: Reviewed-by: Ashutosh Dixit > stream->hold_preemption = props->hold_preemption; > > - stream->oa_buffer.format = > - perf->oa_formats[props->oa_format].format; > - > stream->periodic = props->oa_periodic; > if (stream->periodic) > stream->period_exponent = props->oa_period_exponent; > diff --git a/drivers/gpu/drm/i915/i915_perf_types.h b/drivers/gpu/drm/i915/i915_perf_types.h > index dc9bfd8086cf..e0c96b44eda8 100644 > --- a/drivers/gpu/drm/i915/i915_perf_types.h > +++ b/drivers/gpu/drm/i915/i915_perf_types.h > @@ -250,11 +250,10 @@ struct i915_perf_stream { > * @oa_buffer: State of the OA buffer. > */ > struct { > + const struct i915_oa_format *format; > struct i915_vma *vma; > u8 *vaddr; > u32 last_ctx_id; > - int format; > - int format_size; > int size_exponent; >