From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D965ECCA480 for ; Thu, 14 Jul 2022 13:19:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239715AbiGNNTu (ORCPT ); Thu, 14 Jul 2022 09:19:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239609AbiGNNTo (ORCPT ); Thu, 14 Jul 2022 09:19:44 -0400 Received: from mail.tkos.co.il (golan.tkos.co.il [84.110.109.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9C615D0C6; Thu, 14 Jul 2022 06:19:43 -0700 (PDT) Received: from tarshish (unknown [10.0.8.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.tkos.co.il (Postfix) with ESMTPS id AB87F440F68; Thu, 14 Jul 2022 16:19:20 +0300 (IDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1657804761; bh=rC0OqKZ10lqLln3fBLyz//cFKspAfwxL4UXaVjVi8XU=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=MrTieGt7XR0JWNrlhEggY6RFpCNTkj4S/I29D/r7E9iLRoiiNEjgQw8yvijyGUY18 USwelBx/a/W0eH1BaP1mzhtFoM9EGuDIkyQdwKwH7qQFtHooAFVTAkQSU6Nc+jVVkM XTerN+TiDMSh98lyFqFChgc5phW+3acfas1dwnG8BDaaQsH0Y6dVmCULYnlDgSSUGF n70TM89gabXhe2/ccNloA4yxCXHBI7WYa/82TCDja8IbKO+p3UOwH50XvzjcbJeL1c xtOXwehx2xeSIwpMNT+0h9FfXyONjU4gbsY8wNl8dUO7GlHNyoaFZurmpxRm0YhQcW WuYOR6YQikoEQ== References: <20220714115515.5748-1-pali@kernel.org> User-agent: mu4e 1.8.2; emacs 27.1 From: Baruch Siach To: Pali =?utf-8?Q?Roh=C3=A1r?= Cc: Thierry Reding , Uwe =?utf-8?Q?Kleine-K?= =?utf-8?Q?=C3=B6nig?= , Lee Jones , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Marek =?utf-8?Q?Beh=C3=BAn?= , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/4] gpio: mvebu: Fix check for pwm support on non-A8K platforms Date: Thu, 14 Jul 2022 16:14:27 +0300 In-reply-to: <20220714115515.5748-1-pali@kernel.org> Message-ID: <87lesvde6s.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Pali, On Thu, Jul 14 2022, Pali Roh=C3=A1r wrote: > pwm support incompatible with Armada 80x0/70x0 API is not only in > Armada 370, but also in Armada XP, 38x and 39x. So basically every non-A8K > platform. Fix check for pwm support appropriately. > > Fixes: 85b7d8abfec7 ("gpio: mvebu: add pwm support for Armada 8K/7K") > Signed-off-by: Pali Roh=C3=A1r > --- > drivers/gpio/gpio-mvebu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c > index 2db19cd640a4..70a22b68c034 100644 > --- a/drivers/gpio/gpio-mvebu.c > +++ b/drivers/gpio/gpio-mvebu.c > @@ -793,8 +793,7 @@ static int mvebu_pwm_probe(struct platform_device *pd= ev, > u32 offset; > u32 set; >=20=20 > - if (of_device_is_compatible(mvchip->chip.of_node, > - "marvell,armada-370-gpio")) { > + if (mvchip->soc_variant !=3D MVEBU_GPIO_SOC_VARIANT_A8K) { The 'if' condition that follow the 'else' below become always true: } else if (mvchip->soc_variant =3D=3D MVEBU_GPIO_SOC_VARIANT_A8K) { I would suggest to keep the '=3D=3D MVEBU_GPIO_SOC_VARIANT_A8K' condition, and reverse the if/else order, because positive logic is more readable. There is also another 'else' below that is dead code with this patch. baruch > /* > * There are only two sets of PWM configuration registers for > * all the GPIO lines on those SoCs which this driver reserves --=20 ~. .~ Tk Open Systems =3D}------------------------------------------------ooO--U--Ooo------------= {=3D - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1D23C433EF for ; Thu, 14 Jul 2022 13:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5hh2Lg0EuUYDjDlp7mA65v8WpTZygBZvUYLuuJNguo0=; b=fuI2bNRVmxYup/ PFmfVrjuFd00H6CJ1zOaH3LOBGwIUyd9J7RL0xguw0sNgtEGbfAfBicLdkpvgbbHRnE7dy7mS0+b1 vfH2lLw17Ah+DlOIsQ1XphFxM3eg9NtCxdo52WgD56azBIg4fKTuD7zNjbt00zredFSbLB9Rt5K+x TwC7t0O3sz8K1ltB6kQG0B7t9up/WtWMdPYSr0StWGSziOYHPhDzuVynP+TKESDdtd3qAO7N27y3M GyKuqfbWUTICsJqLKzdoZeE2A7y7Ds70WYfH0jUXE6F02bGniyNNYTzAKoNNAzRT8jpe2/KDutT5L HU5VQ7DaBLHh/zk9pvYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oByl6-00Eegn-N0; Thu, 14 Jul 2022 13:20:00 +0000 Received: from wiki.tkos.co.il ([84.110.109.230] helo=mail.tkos.co.il) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oByku-00EeVj-AP for linux-arm-kernel@lists.infradead.org; Thu, 14 Jul 2022 13:19:50 +0000 Received: from tarshish (unknown [10.0.8.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.tkos.co.il (Postfix) with ESMTPS id AB87F440F68; Thu, 14 Jul 2022 16:19:20 +0300 (IDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1657804761; bh=rC0OqKZ10lqLln3fBLyz//cFKspAfwxL4UXaVjVi8XU=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=MrTieGt7XR0JWNrlhEggY6RFpCNTkj4S/I29D/r7E9iLRoiiNEjgQw8yvijyGUY18 USwelBx/a/W0eH1BaP1mzhtFoM9EGuDIkyQdwKwH7qQFtHooAFVTAkQSU6Nc+jVVkM XTerN+TiDMSh98lyFqFChgc5phW+3acfas1dwnG8BDaaQsH0Y6dVmCULYnlDgSSUGF n70TM89gabXhe2/ccNloA4yxCXHBI7WYa/82TCDja8IbKO+p3UOwH50XvzjcbJeL1c xtOXwehx2xeSIwpMNT+0h9FfXyONjU4gbsY8wNl8dUO7GlHNyoaFZurmpxRm0YhQcW WuYOR6YQikoEQ== References: <20220714115515.5748-1-pali@kernel.org> User-agent: mu4e 1.8.2; emacs 27.1 From: Baruch Siach To: Pali =?utf-8?Q?Roh=C3=A1r?= Cc: Thierry Reding , Uwe =?utf-8?Q?Kleine-K?= =?utf-8?Q?=C3=B6nig?= , Lee Jones , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Marek =?utf-8?Q?Beh=C3=BAn?= , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/4] gpio: mvebu: Fix check for pwm support on non-A8K platforms Date: Thu, 14 Jul 2022 16:14:27 +0300 In-reply-to: <20220714115515.5748-1-pali@kernel.org> Message-ID: <87lesvde6s.fsf@tarshish> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220714_061948_877412_D760FCDC X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUGFsaSwKCk9uIFRodSwgSnVsIDE0IDIwMjIsIFBhbGkgUm9ow6FyIHdyb3RlOgo+IHB3bSBz dXBwb3J0IGluY29tcGF0aWJsZSB3aXRoIEFybWFkYSA4MHgwLzcweDAgQVBJIGlzIG5vdCBvbmx5 IGluCj4gQXJtYWRhIDM3MCwgYnV0IGFsc28gaW4gQXJtYWRhIFhQLCAzOHggYW5kIDM5eC4gU28g YmFzaWNhbGx5IGV2ZXJ5IG5vbi1BOEsKPiBwbGF0Zm9ybS4gRml4IGNoZWNrIGZvciBwd20gc3Vw cG9ydCBhcHByb3ByaWF0ZWx5Lgo+Cj4gRml4ZXM6IDg1YjdkOGFiZmVjNyAoImdwaW86IG12ZWJ1 OiBhZGQgcHdtIHN1cHBvcnQgZm9yIEFybWFkYSA4Sy83SyIpCj4gU2lnbmVkLW9mZi1ieTogUGFs aSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4KPiAtLS0KPiAgZHJpdmVycy9ncGlvL2dwaW8tbXZl YnUuYyB8IDMgKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMiBkZWxldGlv bnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwaW8vZ3Bpby1tdmVidS5jIGIvZHJpdmVy cy9ncGlvL2dwaW8tbXZlYnUuYwo+IGluZGV4IDJkYjE5Y2Q2NDBhNC4uNzBhMjJiNjhjMDM0IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3Bpby9ncGlvLW12ZWJ1LmMKPiArKysgYi9kcml2ZXJzL2dw aW8vZ3Bpby1tdmVidS5jCj4gQEAgLTc5Myw4ICs3OTMsNyBAQCBzdGF0aWMgaW50IG12ZWJ1X3B3 bV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2LAo+ICAJdTMyIG9mZnNldDsKPiAg CXUzMiBzZXQ7Cj4gIAo+IC0JaWYgKG9mX2RldmljZV9pc19jb21wYXRpYmxlKG12Y2hpcC0+Y2hp cC5vZl9ub2RlLAo+IC0JCQkJICAgICJtYXJ2ZWxsLGFybWFkYS0zNzAtZ3BpbyIpKSB7Cj4gKwlp ZiAobXZjaGlwLT5zb2NfdmFyaWFudCAhPSBNVkVCVV9HUElPX1NPQ19WQVJJQU5UX0E4SykgewoK VGhlICdpZicgY29uZGl0aW9uIHRoYXQgZm9sbG93IHRoZSAnZWxzZScgYmVsb3cgYmVjb21lIGFs d2F5cyB0cnVlOgoKICAgICAgIH0gZWxzZSBpZiAobXZjaGlwLT5zb2NfdmFyaWFudCA9PSBNVkVC VV9HUElPX1NPQ19WQVJJQU5UX0E4SykgewoKSSB3b3VsZCBzdWdnZXN0IHRvIGtlZXAgdGhlICc9 PSBNVkVCVV9HUElPX1NPQ19WQVJJQU5UX0E4SycgY29uZGl0aW9uLAphbmQgcmV2ZXJzZSB0aGUg aWYvZWxzZSBvcmRlciwgYmVjYXVzZSBwb3NpdGl2ZSBsb2dpYyBpcyBtb3JlIHJlYWRhYmxlLgoK VGhlcmUgaXMgYWxzbyBhbm90aGVyICdlbHNlJyBiZWxvdyB0aGF0IGlzIGRlYWQgY29kZSB3aXRo IHRoaXMgcGF0Y2guCgpiYXJ1Y2gKCj4gIAkJLyoKPiAgCQkgKiBUaGVyZSBhcmUgb25seSB0d28g c2V0cyBvZiBQV00gY29uZmlndXJhdGlvbiByZWdpc3RlcnMgZm9yCj4gIAkJICogYWxsIHRoZSBH UElPIGxpbmVzIG9uIHRob3NlIFNvQ3Mgd2hpY2ggdGhpcyBkcml2ZXIgcmVzZXJ2ZXMKCgotLSAK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB+LiAu fiAgIFRrIE9wZW4gU3lzdGVtcwo9fS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLW9vTy0tVS0tT29vLS0tLS0tLS0tLS0tez0KICAgLSBiYXJ1Y2hAdGtvcy5j by5pbCAtIHRlbDogKzk3Mi41Mi4zNjguNDY1NiwgaHR0cDovL3d3dy50a29zLmNvLmlsIC0KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK