From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8665C43334 for ; Mon, 11 Jul 2022 08:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229745AbiGKItp (ORCPT ); Mon, 11 Jul 2022 04:49:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230213AbiGKIti (ORCPT ); Mon, 11 Jul 2022 04:49:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C76F2DE1 for ; Mon, 11 Jul 2022 01:49:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E2463610A3 for ; Mon, 11 Jul 2022 08:49:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C134C34115; Mon, 11 Jul 2022 08:49:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657529374; bh=TXz8Cull581sWQiCmhWmKyTwtHjdk8RBz2Euuu/m648=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=inZEd6xZhKJvEbFon0T2HgKVPJQMl/B7/CqkPPG/TtA31HjKJT9gJjss2iu2DvWIG p4942B+K/WkpsapYMTQ0PGtMcDwujVYjnWF6COmZ/BwFt7yhb4aH8sb9d+Yo/NsIag OAud4eftwxojHlHum+GRwDVwjjcJgdKDEGL98LKm2NJxH6Cy3GqGSbAQqgRdT41QQk NQwfjjurptLCRaEP1XM/FqeaBpEu0FfrhBNyuW57pw+geO0n3dNsrfbbB+tYuXLB6X lWJLTwXHltHsKFIJK0plBiN/vU+wz7ipAP7kkzPoTC9DBliQ5tFbYsnMNJ6WIRdr/y XpfqtXOY6H+4g== Received: from [213.208.244.172] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oAp6i-006b7M-6C; Mon, 11 Jul 2022 09:49:32 +0100 Date: Mon, 11 Jul 2022 09:49:31 +0100 Message-ID: <87let0kp9g.wl-maz@kernel.org> From: Marc Zyngier To: Claudiu Beznea Cc: , , , , Subject: Re: [PATCH 1/2] irqchip/atmel-aic: remove #ifdef CONFIG_PM In-Reply-To: <20220706074630.829607-1-claudiu.beznea@microchip.com> References: <20220706074630.829607-1-claudiu.beznea@microchip.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 213.208.244.172 X-SA-Exim-Rcpt-To: claudiu.beznea@microchip.com, tglx@linutronix.de, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Claudiu, If you send more than a single patch, please add a cover letter. On Wed, 06 Jul 2022 08:46:29 +0100, Claudiu Beznea wrote: > > Remove #ifdef CONFIG_PM around aic_suspend() function. Coding style > recommends (at chapter Conditional Compilation) to avoid using > preprocessor conditional in .c files. > gc->chip_types->chip.irq_suspend()/gc->chip_types->chip.irq_resume() is > called in irq_gc_suspend()/irq_gc_resume() which is NULL in case CONFIG_PM > is not defined. With this gc->chip_types->chip.irq_pm_shutdown is > populated all the time as it should be as irq_gc_shutdown() is not > conditioned by CONFIG_PM. By your very own investigations, aic_suspend() and co are utterly useless when !PM. And yet you want to *preserve* them, despite being dead code? What purpose does it serve (other than some blind compliance to a rule)? M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05F0AC433EF for ; Mon, 11 Jul 2022 08:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Cszj41STtV0Q2g/6/5kgOf7oL0eOe9PvoEsR8IoA96M=; b=hQqrgHjzkMYF3a UFmKTxi5CoE/dft+TJX79QWbB2FFLvqHUfHkkBRA9cG9YzN71lXWUZE8CAUjb/hisgDFnYVlDyuns RYAa1KTnEeSeCQxY48YN+Uyk2ZUrBprNy6k3vlQllpXOTxDk8W4O330hAfvOTzb3xZS/YkS5mztnG pdsCl/HeGU0bJ8PUloeBb77kECa4yXI5iEM+6gsJg446BTF+E0OXWw6Ct7kb47kBpEbJSeYc4w+a3 BW7+OZoOm8M/GG/uYAUYgRn8TVTGhtYLn5g6yznwSQHtm58Ha6e7Ofw7m4kAoFCko331FfozCUNTg u/wQGPK/YEcvN/V86vng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAp6q-00HKzj-6y; Mon, 11 Jul 2022 08:49:40 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAp6m-00HKyI-1Q for linux-arm-kernel@lists.infradead.org; Mon, 11 Jul 2022 08:49:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DE1E961093; Mon, 11 Jul 2022 08:49:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C134C34115; Mon, 11 Jul 2022 08:49:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657529374; bh=TXz8Cull581sWQiCmhWmKyTwtHjdk8RBz2Euuu/m648=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=inZEd6xZhKJvEbFon0T2HgKVPJQMl/B7/CqkPPG/TtA31HjKJT9gJjss2iu2DvWIG p4942B+K/WkpsapYMTQ0PGtMcDwujVYjnWF6COmZ/BwFt7yhb4aH8sb9d+Yo/NsIag OAud4eftwxojHlHum+GRwDVwjjcJgdKDEGL98LKm2NJxH6Cy3GqGSbAQqgRdT41QQk NQwfjjurptLCRaEP1XM/FqeaBpEu0FfrhBNyuW57pw+geO0n3dNsrfbbB+tYuXLB6X lWJLTwXHltHsKFIJK0plBiN/vU+wz7ipAP7kkzPoTC9DBliQ5tFbYsnMNJ6WIRdr/y XpfqtXOY6H+4g== Received: from [213.208.244.172] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oAp6i-006b7M-6C; Mon, 11 Jul 2022 09:49:32 +0100 Date: Mon, 11 Jul 2022 09:49:31 +0100 Message-ID: <87let0kp9g.wl-maz@kernel.org> From: Marc Zyngier To: Claudiu Beznea Subject: Re: [PATCH 1/2] irqchip/atmel-aic: remove #ifdef CONFIG_PM In-Reply-To: <20220706074630.829607-1-claudiu.beznea@microchip.com> References: <20220706074630.829607-1-claudiu.beznea@microchip.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 213.208.244.172 X-SA-Exim-Rcpt-To: claudiu.beznea@microchip.com, tglx@linutronix.de, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220711_014936_140688_7A31808B X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Claudiu, If you send more than a single patch, please add a cover letter. On Wed, 06 Jul 2022 08:46:29 +0100, Claudiu Beznea wrote: > > Remove #ifdef CONFIG_PM around aic_suspend() function. Coding style > recommends (at chapter Conditional Compilation) to avoid using > preprocessor conditional in .c files. > gc->chip_types->chip.irq_suspend()/gc->chip_types->chip.irq_resume() is > called in irq_gc_suspend()/irq_gc_resume() which is NULL in case CONFIG_PM > is not defined. With this gc->chip_types->chip.irq_pm_shutdown is > populated all the time as it should be as irq_gc_shutdown() is not > conditioned by CONFIG_PM. By your very own investigations, aic_suspend() and co are utterly useless when !PM. And yet you want to *preserve* them, despite being dead code? What purpose does it serve (other than some blind compliance to a rule)? M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel