From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1B01C43334 for ; Thu, 9 Jun 2022 14:09:49 +0000 (UTC) Received: from localhost ([::1]:36378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzIr6-0003k7-Kg for qemu-devel@archiver.kernel.org; Thu, 09 Jun 2022 10:09:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzGmk-0001PR-UH for qemu-devel@nongnu.org; Thu, 09 Jun 2022 07:57:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:30511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzGmi-0002h8-FZ for qemu-devel@nongnu.org; Thu, 09 Jun 2022 07:57:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654775827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1QueKO4NFw8r8GmCI6G4RX0gvrLteWnZ9zQiBJvNK0c=; b=GAJ45+/dfO8eSRbaKlhDLRGrccgkPAmwjPr6IQwW+ZuX3uBOD3hbbkH53ya/PxFltKl/P3 2n8t4hmPGhhAKWm34HJpnXA/D5C9njq2xMCk8UuX4XBAzKnQdv/Zm1uwIeymJD2vl+0mWZ 6hZyDreV6UpBeMh/uEq1qF3EgdOQBNk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-372-VEK19qc1PUKNBxK5Xvn4SQ-1; Thu, 09 Jun 2022 07:56:59 -0400 X-MC-Unique: VEK19qc1PUKNBxK5Xvn4SQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BF687811E7A for ; Thu, 9 Jun 2022 11:56:58 +0000 (UTC) Received: from localhost (unknown [10.39.192.115]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 79CC6404E4B5; Thu, 9 Jun 2022 11:56:58 +0000 (UTC) From: Cornelia Huck To: Paolo Bonzini , qemu-devel@nongnu.org Cc: mst@redhat.com, thuth@redhat.com Subject: Re: [PATCH 3/4] virtio: stop ioeventfd on reset In-Reply-To: <20220609091534.1416909-4-pbonzini@redhat.com> Organization: Red Hat GmbH References: <20220609091534.1416909-1-pbonzini@redhat.com> <20220609091534.1416909-4-pbonzini@redhat.com> User-Agent: Notmuch/0.36 (https://notmuchmail.org) Date: Thu, 09 Jun 2022 13:56:56 +0200 Message-ID: <87leu69hiv.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Received-SPF: pass client-ip=170.10.133.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jun 09 2022, Paolo Bonzini wrote: > All calls to virtio_bus_reset are preceded by virtio_bus_stop_ioeventfd, > move the call in virtio_bus_reset: that makes sense and clarifies > that the vdc->reset function is called with ioeventfd already stopped. > > Signed-off-by: Paolo Bonzini > --- > hw/s390x/virtio-ccw.c | 1 - > hw/virtio/virtio-bus.c | 1 + > hw/virtio/virtio-mmio.c | 4 +--- > hw/virtio/virtio-pci.c | 1 - > 4 files changed, 2 insertions(+), 5 deletions(-) > (...) > diff --git a/hw/virtio/virtio-bus.c b/hw/virtio/virtio-bus.c > index d7ec023adf..896feb37a1 100644 > --- a/hw/virtio/virtio-bus.c > +++ b/hw/virtio/virtio-bus.c > @@ -104,6 +104,7 @@ void virtio_bus_reset(VirtioBusState *bus) > VirtIODevice *vdev = virtio_bus_get_device(bus); > > DPRINTF("%s: reset device.\n", BUS(bus)->name); > + virtio_bus_stop_ioeventfd(bus); > if (vdev != NULL) { > virtio_reset(vdev); I looked at the code and I'm wondering under which conditions we could arrive here with vdev == NULL... virtio_bus_stop_ioeventfd() assumes that a vdev is there, at least if the ioeventfd has been started. The patch looks correct, though. Reviewed-by: Cornelia Huck