From: "Huang, Ying" <ying.huang@intel.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Abhishek Goel <huntbag@linux.vnet.ibm.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm: Only re-generate demotion targets when a numa node changes its N_CPU state
Date: Tue, 15 Mar 2022 17:19:28 +0800 [thread overview]
Message-ID: <87lexb1skf.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <YjBPKmIpPNoJU/67@localhost.localdomain> (Oscar Salvador's message of "Tue, 15 Mar 2022 09:32:42 +0100")
Oscar Salvador <osalvador@suse.de> writes:
> On Tue, Mar 15, 2022 at 02:40:53PM +0800, Huang, Ying wrote:
>> Oscar Salvador <osalvador@suse.de> writes:
>> CPUHP_MM_DEMOTION_DEAD and CPUHP_AP_MM_DEMOTION_ONLINE needs to be
>> deleted from include/linux/cpuhotplug.h too.
>
> Hi Huang Ying,
>
> Right.
>
> Andrew, can you apply this on top? Thanks
>
> diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h
> index 411a428ace4d..8a9a2d01b7c6 100644
> --- a/include/linux/cpuhotplug.h
> +++ b/include/linux/cpuhotplug.h
> @@ -72,8 +72,6 @@ enum cpuhp_state {
> CPUHP_SLUB_DEAD,
> CPUHP_DEBUG_OBJ_DEAD,
> CPUHP_MM_WRITEBACK_DEAD,
> - /* Must be after CPUHP_MM_VMSTAT_DEAD */
> - CPUHP_MM_DEMOTION_DEAD,
> CPUHP_MM_VMSTAT_DEAD,
> CPUHP_SOFTIRQ_DEAD,
> CPUHP_NET_MVNETA_DEAD,
> @@ -244,8 +242,6 @@ enum cpuhp_state {
> CPUHP_AP_BASE_CACHEINFO_ONLINE,
> CPUHP_AP_ONLINE_DYN,
> CPUHP_AP_ONLINE_DYN_END = CPUHP_AP_ONLINE_DYN + 30,
> - /* Must be after CPUHP_AP_ONLINE_DYN for node_states[N_CPU] update */
> - CPUHP_AP_MM_DEMOTION_ONLINE,
> CPUHP_AP_X86_HPET_ONLINE,
> CPUHP_AP_X86_KVM_CLK_ONLINE,
> CPUHP_AP_ACTIVE,
>
> Huang Ying, it would be great to have your Reviewed-by/Acked-by if you
> are ok with the outome.
Sure.
Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
Best Regards,
Huang, Ying
next prev parent reply other threads:[~2022-03-15 9:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 15:09 [PATCH v3] mm: Only re-generate demotion targets when a numa node changes its N_CPU state Oscar Salvador
2022-03-15 6:40 ` Huang, Ying
2022-03-15 8:32 ` Oscar Salvador
2022-03-15 9:19 ` Huang, Ying [this message]
2022-03-16 14:03 ` Abhishek Goel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lexb1skf.fsf@yhuang6-desk2.ccr.corp.intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dave.hansen@linux.intel.com \
--cc=huntbag@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.