From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTPS id B90DF897B4
 for <igt-dev@lists.freedesktop.org>; Mon, 21 Jun 2021 05:28:52 +0000 (UTC)
Date: Sun, 20 Jun 2021 22:28:49 -0700
Message-ID: <87lf73iy5q.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <CAOFGe95LdZ76dB-QzycbPLHqB2DMW5t8W_XWg=ekg8Kp_gO-4w@mail.gmail.com>
References: <20210617191256.577244-32-jason@jlekstrand.net>
 <20210618164714.629477-1-jason@jlekstrand.net>
 <87bl83dlq8.wl-ashutosh.dixit@intel.com>
 <CAOFGe95LdZ76dB-QzycbPLHqB2DMW5t8W_XWg=ekg8Kp_gO-4w@mail.gmail.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_ctx_switch: Convert to
 intel_ctx_t
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Jason Ekstrand <jason@jlekstrand.net>
Cc: IGT GPU Tools <igt-dev@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On Sun, 20 Jun 2021 20:48:32 -0700, Jason Ekstrand wrote:
>
> On Fri, Jun 18, 2021 at 2:19 PM Dixit, Ashutosh
> <ashutosh.dixit@intel.com> wrote:
> >
> > On Fri, 18 Jun 2021 09:47:14 -0700, Jason Ekstrand wrote:
> > >
> > > @@ -315,8 +326,8 @@ igt_main
> > >       } phases[] = {
> > >               { "", 0, NULL },
> > >               { "-interruptible", INTERRUPTIBLE, NULL },
> > > -             { "-queue", QUEUE, gem_has_queues },
> > > -             { "-queue-interruptible", QUEUE | INTERRUPTIBLE, gem_has_queues },
> > > +             { "-queue", QUEUE, gem_has_vm },
> > > +             { "-queue-interruptible", QUEUE | INTERRUPTIBLE, gem_has_vm },
> >
> > As I was saying ealier I think here we should replace gem_has_vm with
> > gem_has_queues() where:
> >
> > gem_has_queues == gem_has_vm && gem_context_has_single_timeline
>
> Oh, I see what you mean now!  I've added this locally:
>
> static bool
> has_queues(int fd)
> {
>     return gem_has_vm(fd) && gem_context_has_single_timeline(fd);
> }
>
> and used it instead of gem_has_vm.  How's that sound?

Thanks, though maybe add to the lib where we added
gem_context_has_single_timeline() (lib/i915/gem_context.c) since there are
other places too where this would be useful.

>
> --Jason
>
> > But even otherwise this is:
> >
> > Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev