From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 515B4C48BCD for ; Wed, 9 Jun 2021 15:59:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2542B6139A for ; Wed, 9 Jun 2021 15:59:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2542B6139A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e7SO0+sTrrFonVgNTTx/PfheE8Ia3PRCWXTtpOEPuTo=; b=PByPJr+S9ySHvU FsByBHIlNygrqqVNsArMbEi9IQkLhGq8aKlhmR4Bo7mWyuxUlaxigkIG40GCJKmdU3G6hy+Igeep2 b00MjSN25S3V79bpF1/69jbIfiM2cLaabm21pFoIzD48BRh17uCJK75vZvjBMFtVHEBtuFL1CVs/k xM/R2HX4OBYWKfDUzcUHd4z8y0eI3Y3sLru0cFfK9MR65HFCZInSw4GkgGW+UZrRRBTrjfzBANWOx pvXjWzjBpWQrQGdkrVgvE0UzxiUrqZKy5lH1ZevMrsmbU58q6h0oDC/t0r2jDwd+lXUAoFPtEIh3Q GYhDnxhMPXJt8ZTAmm8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lr0Zv-00EkBE-D2; Wed, 09 Jun 2021 15:57:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqzTy-00EOS1-7U for linux-arm-kernel@lists.infradead.org; Wed, 09 Jun 2021 14:47:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6CD30D6E; Wed, 9 Jun 2021 07:46:59 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3512A3F73D; Wed, 9 Jun 2021 07:46:58 -0700 (PDT) From: Valentin Schneider To: Marc Zyngier , linux-arm-kernel@lists.infradead.org Cc: Lorenzo Pieralisi , Will Deacon , Catalin Marinas , Mark Rutland , Alexandru Elisei , Russell King , kernel-team@android.com Subject: Re: [PATCH 0/3] arm64: Fix cpuidle with pseudo-NMI enabled In-Reply-To: <20210608172715.2396787-1-maz@kernel.org> References: <20210608172715.2396787-1-maz@kernel.org> Date: Wed, 09 Jun 2021 15:46:43 +0100 Message-ID: <87lf7jccz0.mognet@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210609_074702_361518_DCF0971E X-CRM114-Status: GOOD ( 15.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, On 08/06/21 18:27, Marc Zyngier wrote: > It appears that although cpu_do_idle() is correctly dealing with the > PMR/DAIF duality, the PSCI cpu-suspend code has been left unaware of > it. > > On a system that uses PSCI for idle (such as the Ampere Altra I have > access to), the kernel dies as soon as it enters idle (interrupts are > off at the GIC CPU interface level). Boo. > > Instead of spreading more magic code around, I've elected to provide a > pair of helpers (arm_cpuidle_{save,restore}_context()) which do the > heavy lifting. > > With that in place, I can finally boot the above system with > irqchip.gicv3_pseudo_nmi=1. I'd welcome feedback from people who may > have experienced similar issues in the past (and on different > machines). > With pNMIs my Ampere eMAG would always hang at boot, and your patches make it actually survive. I briefly kicked perf to get some PMU IRQs and that also seems to be going just fine. Thanks for digging into this mess! Tested-by: Valentin Schneider > Marc Zyngier (3): > arm64: Add cpuidle context save/restore helpers > arm64: Convert cpu_do_idle() to using cpuidle context helpers > PSCI: Use cpuidle context helpers in psci_cpu_suspend_enter() > > arch/arm/include/asm/cpuidle.h | 5 ++++ > arch/arm64/include/asm/cpuidle.h | 35 +++++++++++++++++++++++++++ > arch/arm64/kernel/process.c | 41 +++++++------------------------- > drivers/firmware/psci/psci.c | 5 ++++ > 4 files changed, 54 insertions(+), 32 deletions(-) > > -- > 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel