From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 559EEC433ED for ; Wed, 5 May 2021 06:40:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6093613CD for ; Wed, 5 May 2021 06:40:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6093613CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E3A26E428; Wed, 5 May 2021 06:40:54 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id D54A66E428 for ; Wed, 5 May 2021 06:40:52 +0000 (UTC) IronPort-SDR: lxEOksnss1OZLF7NEbU4Zk4nSoACZ+vkza7+jGtB5ib9bVYAGGq0fuhvAOSq7dtgyhNeUFrr2Q 3d9/7LlMAW1w== X-IronPort-AV: E=McAfee;i="6200,9189,9974"; a="262092188" X-IronPort-AV: E=Sophos;i="5.82,274,1613462400"; d="scan'208";a="262092188" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2021 23:40:52 -0700 IronPort-SDR: INjUgzAzFrKMVeGzji1k+PDHeR806z1KZBT1X3ti6qGE+YFaBwt23JX0jHmqlyYXUh8wTzFnZk eqpdAzBtkqxA== X-IronPort-AV: E=Sophos;i="5.82,274,1613462400"; d="scan'208";a="433664510" Received: from weberral-mobl2.ger.corp.intel.com (HELO localhost) ([10.249.45.238]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2021 23:40:49 -0700 From: Jani Nikula To: Anusha Srivatsa , intel-gfx@lists.freedesktop.org In-Reply-To: <87fsz3znxm.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210428211249.11037-1-anusha.srivatsa@intel.com> <87fsz3znxm.fsf@intel.com> Date: Wed, 05 May 2021 09:40:46 +0300 Message-ID: <87lf8ty975.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 0/3] Pipe DMC Prep patches X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 03 May 2021, Jani Nikula wrote: > On Wed, 28 Apr 2021, Anusha Srivatsa wrote: >> This series adds the prep work needed before the >> actual Pipe DMC implementation. > > When should we rename csr to dmc all over the place? To elaborate, I think it's pretty confusing that we use both CSR and DMC acronyms in code. There may be a distinction, but we don't respect that in the usage. Sure, the spec mentions both, but I don't think we follow the naming there either. I think we should just rename all CSR references to DMC, including the file name and the function and struct names. I wonder if it would be better to do the renames first before starting to build a lot of changes on top. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx