From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B8A0C433ED for ; Tue, 13 Apr 2021 14:55:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F211613AB for ; Tue, 13 Apr 2021 14:55:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231858AbhDMOzn (ORCPT ); Tue, 13 Apr 2021 10:55:43 -0400 Received: from foss.arm.com ([217.140.110.172]:43588 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231378AbhDMOzl (ORCPT ); Tue, 13 Apr 2021 10:55:41 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6360D106F; Tue, 13 Apr 2021 07:55:21 -0700 (PDT) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 99ACC3F694; Tue, 13 Apr 2021 07:55:19 -0700 (PDT) From: Valentin Schneider To: Peter Zijlstra , mingo@kernel.org, mgorman@suse.de, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, joshdon@google.com Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, greg@kroah.com, linux@rasmusvillemoes.dk Subject: Re: [PATCH v2 7/9] sched,debug: Convert sysctl sched_domains to debugfs In-Reply-To: <20210412102001.485107586@infradead.org> References: <20210412101421.609526370@infradead.org> <20210412102001.485107586@infradead.org> Date: Tue, 13 Apr 2021 15:55:15 +0100 Message-ID: <87lf9mmdyk.mognet@arm.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/04/21 12:14, Peter Zijlstra wrote: > Stop polluting sysctl, move to debugfs for SCHED_DEBUG stuff. > > Signed-off-by: Peter Zijlstra (Intel) > Reviewed-by: Dietmar Eggemann On my Juno (2+4 big.LITTLE), sys/kernel/debug/sched/domains/ is now empty. I think that's because of unregister_sched_domain_sysctl() - debugfs_remove() is recursive, and I do get a case where we rebuild the domains but no CPU has been added or removed (we rebuild the domains when cpufreq kicks in, it's part of the big.LITTLE ponies). Do we actually still need that unregister? From a brief glance it looks like we could throw it out.