From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F9E4C433E6 for ; Mon, 11 Jan 2021 17:49:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F27E8225AB for ; Mon, 11 Jan 2021 17:49:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389867AbhAKRte (ORCPT ); Mon, 11 Jan 2021 12:49:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389852AbhAKRte (ORCPT ); Mon, 11 Jan 2021 12:49:34 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9406C061786 for ; Mon, 11 Jan 2021 09:48:53 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id 3so42345wmg.4 for ; Mon, 11 Jan 2021 09:48:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=HjFjB02VUOcj2JDmR/K56mtMUPw1JqKruxO3gsfgtG0=; b=Z1BLHnk/IllfoIqIlxKJ0XD2wgjI2evX/5XsMH9aGtoY/foB5Zp0OZr8+O18Z54N3P vFsoIVlUr7x9Y30UZt1g+VOvY8vJ0NhhFFf2vN/wzVP3Kpz1pVqYsTLQ3muqdwj0v8Y5 F9VbBO51j75TEHi3Hsgg7/C+0sYNIOp0sLXBtkDC9Q/35JGz6cyiqvyi3+ptkFR33Rvf 3RBT2H7VMu8ETRySwN8DK70ixgS2jWeoVWpQS1Wylo7thAyY7nH2Kq28D8Zatl3+Bobs TdnNFPVrst4l7kXfPxCLsQ62wZ5e8A8OpP+u3d7lU4jKfBn2zsMJ+iKqTpkuPX5Vqm2S db4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=HjFjB02VUOcj2JDmR/K56mtMUPw1JqKruxO3gsfgtG0=; b=iNwVsC3FV9EK7D0rrxzEkoSg4LT7jHJSpUtb0ue0/OxTtrJiOY/iyVzbuBGvOlGWGH G8+LggWIIeNRJTQ/GmsC348qFxpgiBw16Tt7x5b4SM9tnUxnBtKh1lnpH4G3Lmr147+9 FB7hbvN7dHXmwkngH2MHZHmxVXh58txGVUD4qRWhgqfp03ZrxImBu6Znbu0E8Mmfi0Is KfGr4H1NzRpSCyOggJ5IHPLYprx7MT3Bvo7xZvziLL3rn/i5N+x0PtLu4GTAIX6Tqmeg +O4/I3YkqXkdc/tE0kMB9ySW5imfU/ILu6MsBDUpo0m8+LZtc0Mg6uOxKdBaWWX60MOR LDmw== X-Gm-Message-State: AOAM531WcRYOyFCAYzy/crlcWso2UeXFNLz8OlCwsMLp2Q9Wx4soGYhq fv3VJJVkmIcbP1JAzlE4hVVaDQ== X-Google-Smtp-Source: ABdhPJxFl0pGJIm5UheooE53gyVfAACVfyEjNoEnS7yM3rBuAokl0gYAMKI4jSlEoOleDrcPABVpeg== X-Received: by 2002:a1c:7213:: with SMTP id n19mr15554wmc.14.1610387332427; Mon, 11 Jan 2021 09:48:52 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id o3sm396503wrc.93.2021.01.11.09.48.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 09:48:51 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id B2CE01FF7E; Mon, 11 Jan 2021 17:48:50 +0000 (GMT) References: <20210111152020.1422021-1-philmd@redhat.com> <20210111152020.1422021-3-philmd@redhat.com> User-agent: mu4e 1.5.7; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Huacai Chen , Greg Kurz , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, Amit Shah , Dmitry Fleytman , qemu-arm@nongnu.org, John Snow , qemu-s390x@nongnu.org, Paul Durrant , Anthony Perard , Eduardo Habkost , Gerd Hoffmann , Kevin Wolf , Marcelo Tosatti , Max Reitz , Alex Williamson , Aurelien Jarno , Aleksandar Rikalo , Marcel Apfelbaum , Jason Wang , Peter Maydell , =?utf-8?Q?C=C3=A9dric?= Le Goater , Halil Pasic , Fam Zheng , qemu-ppc@nongnu.org, Paolo Bonzini , kvm@vger.kernel.org, Stefano Stabellini , xen-devel@lists.xenproject.org, Cornelia Huck , David Hildenbrand , qemu-block@nongnu.org, Christian Borntraeger , Sunil Muthuswamy , David Gibson , Richard Henderson , Laurent Vivier , Thomas Huth , Stefan Hajnoczi , Jiaxun Yang Subject: Re: [PATCH 2/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument Date: Mon, 11 Jan 2021 17:48:41 +0000 In-reply-to: <20210111152020.1422021-3-philmd@redhat.com> Message-ID: <87lfcznz3x.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Philippe Mathieu-Daud=C3=A9 writes: > The 'running' argument from VMChangeStateHandler does not require > other value than 0 / 1. Make it a plain boolean. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Seems reasonable Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 198F1C433E0 for ; Mon, 11 Jan 2021 17:56:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E59D223C8 for ; Mon, 11 Jan 2021 17:56:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E59D223C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kz1QH-0005xf-Da for qemu-devel@archiver.kernel.org; Mon, 11 Jan 2021 12:56:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kz1JI-00019B-I4 for qemu-devel@nongnu.org; Mon, 11 Jan 2021 12:48:56 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:34832) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kz1JF-000549-R4 for qemu-devel@nongnu.org; Mon, 11 Jan 2021 12:48:56 -0500 Received: by mail-wm1-x32b.google.com with SMTP id e25so66986wme.0 for ; Mon, 11 Jan 2021 09:48:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=HjFjB02VUOcj2JDmR/K56mtMUPw1JqKruxO3gsfgtG0=; b=Z1BLHnk/IllfoIqIlxKJ0XD2wgjI2evX/5XsMH9aGtoY/foB5Zp0OZr8+O18Z54N3P vFsoIVlUr7x9Y30UZt1g+VOvY8vJ0NhhFFf2vN/wzVP3Kpz1pVqYsTLQ3muqdwj0v8Y5 F9VbBO51j75TEHi3Hsgg7/C+0sYNIOp0sLXBtkDC9Q/35JGz6cyiqvyi3+ptkFR33Rvf 3RBT2H7VMu8ETRySwN8DK70ixgS2jWeoVWpQS1Wylo7thAyY7nH2Kq28D8Zatl3+Bobs TdnNFPVrst4l7kXfPxCLsQ62wZ5e8A8OpP+u3d7lU4jKfBn2zsMJ+iKqTpkuPX5Vqm2S db4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=HjFjB02VUOcj2JDmR/K56mtMUPw1JqKruxO3gsfgtG0=; b=TLF0RKjIBfBeN5Zq48Ibi3ML2t/CGJ3fYcI9ZqLBIfiq38Rkat0Yiv0EsxKmJHlJNZ p0AwD7oW3J1HS+1i9ap+GBgxi3tNrkKvis6/a3KScjX8sJi8yXufZOdCXlu/fIwWdcXe j69/XPneVSh2zpMWfYRmecNBs8Brlq8G5TETCIiLr3Jg4dygCpRr57Zd/Ds4tKxXV4n4 MhknoZmntSTJz23ORa2sA9tGmkCaHTPCTZJ0Hmklc7pc0K38wWsnTt6Nv0XljLDy7DtR jmL5dmt9HdfZgvlYSs4Nk5cAVT3EfCLdbUVT1msXizIl+h0BNjLjUOPVlwPkY8rUCTuA p2ng== X-Gm-Message-State: AOAM531TQp1dCE8Dnc1f17LQLvtZhubXvFxY7Xx06/FVf9evnJFRpfCe qmz1gmpt0/eD5FKIkoAEYwaG8A== X-Google-Smtp-Source: ABdhPJxFl0pGJIm5UheooE53gyVfAACVfyEjNoEnS7yM3rBuAokl0gYAMKI4jSlEoOleDrcPABVpeg== X-Received: by 2002:a1c:7213:: with SMTP id n19mr15554wmc.14.1610387332427; Mon, 11 Jan 2021 09:48:52 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id o3sm396503wrc.93.2021.01.11.09.48.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 09:48:51 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id B2CE01FF7E; Mon, 11 Jan 2021 17:48:50 +0000 (GMT) References: <20210111152020.1422021-1-philmd@redhat.com> <20210111152020.1422021-3-philmd@redhat.com> User-agent: mu4e 1.5.7; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 2/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument Date: Mon, 11 Jan 2021 17:48:41 +0000 In-reply-to: <20210111152020.1422021-3-philmd@redhat.com> Message-ID: <87lfcznz3x.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Dmitry Fleytman , kvm@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , David Hildenbrand , qemu-devel@nongnu.org, Laurent Vivier , Thomas Huth , Gerd Hoffmann , Stefano Stabellini , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Huacai Chen , Halil Pasic , Christian Borntraeger , Anthony Perard , xen-devel@lists.xenproject.org, Aleksandar Rikalo , Eduardo Habkost , Amit Shah , Richard Henderson , Greg Kurz , Paul Durrant , Alex Williamson , qemu-arm@nongnu.org, =?utf-8?Q?C=C3=A9dric?= Le Goater , Stefan Hajnoczi , Sunil Muthuswamy , John Snow , David Gibson , Kevin Wolf , Marcelo Tosatti , qemu-s390x@nongnu.org, Max Reitz , qemu-ppc@nongnu.org, Cornelia Huck , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Philippe Mathieu-Daud=C3=A9 writes: > The 'running' argument from VMChangeStateHandler does not require > other value than 0 / 1. Make it a plain boolean. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Seems reasonable Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e