From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10E4DC33CAD for ; Mon, 13 Jan 2020 12:08:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0A04207FD for ; Mon, 13 Jan 2020 12:08:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728777AbgAMMI3 (ORCPT ); Mon, 13 Jan 2020 07:08:29 -0500 Received: from mga01.intel.com ([192.55.52.88]:53741 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726934AbgAMMI2 (ORCPT ); Mon, 13 Jan 2020 07:08:28 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 04:08:28 -0800 X-IronPort-AV: E=Sophos;i="5.69,428,1571727600"; d="scan'208";a="217387846" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 04:08:25 -0800 From: Jani Nikula To: Chris Wilson , Wambui Karuga , airlied@linux.ie, daniel@ffwll.ch, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com Cc: sean@poorly.run, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/i915: convert to new logging macros based on struct intel_engine_cs. In-Reply-To: <157891427231.27314.12398974277241668021@skylake-alporthouse-com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200113111025.2048-1-wambui.karugax@gmail.com> <157891427231.27314.12398974277241668021@skylake-alporthouse-com> Date: Mon, 13 Jan 2020 14:08:22 +0200 Message-ID: <87lfqbmudl.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Jan 2020, Chris Wilson wrote: > Quoting Wambui Karuga (2020-01-13 11:10:25) >> fn(...) { >> ... >> struct intel_engine_cs *E = ...; >> +struct drm_i915_private *dev_priv = E->i915; > > No new dev_priv. Wambui, we're gradually converting all dev_priv variable and parameter names to i915. > There should be no reason for drm_dbg here, as the rest of the debug is > behind ENGINE_TRACE and so the vestigial debug should be moved over, or > deleted as not being useful. > > The error messages look unhelpful. I don't think you can expect any meaninful improvements on the debug message contents from Wambui without detailed help at this point. > >> if ((batch_end - cmd) < length) { >> - DRM_DEBUG("CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n", >> - *cmd, >> - length, >> - batch_end - cmd); >> + drm_dbg(&dev_priv->drm, >> + "CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n", > > No. This is not driver debug. If anything this should be pr_debug, or > some over user centric channel. I'm sorry, I still don't understand your reasoning here. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13944C33CAF for ; Mon, 13 Jan 2020 12:08:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4EB52084D for ; Mon, 13 Jan 2020 12:08:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4EB52084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 69C586E082; Mon, 13 Jan 2020 12:08:29 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 70A216E082; Mon, 13 Jan 2020 12:08:28 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 04:08:27 -0800 X-IronPort-AV: E=Sophos;i="5.69,428,1571727600"; d="scan'208";a="217387846" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 04:08:25 -0800 From: Jani Nikula To: Chris Wilson , Wambui Karuga , airlied@linux.ie, daniel@ffwll.ch, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com Subject: Re: [PATCH] drm/i915: convert to new logging macros based on struct intel_engine_cs. In-Reply-To: <157891427231.27314.12398974277241668021@skylake-alporthouse-com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200113111025.2048-1-wambui.karugax@gmail.com> <157891427231.27314.12398974277241668021@skylake-alporthouse-com> Date: Mon, 13 Jan 2020 14:08:22 +0200 Message-ID: <87lfqbmudl.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, sean@poorly.run, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 13 Jan 2020, Chris Wilson wrote: > Quoting Wambui Karuga (2020-01-13 11:10:25) >> fn(...) { >> ... >> struct intel_engine_cs *E = ...; >> +struct drm_i915_private *dev_priv = E->i915; > > No new dev_priv. Wambui, we're gradually converting all dev_priv variable and parameter names to i915. > There should be no reason for drm_dbg here, as the rest of the debug is > behind ENGINE_TRACE and so the vestigial debug should be moved over, or > deleted as not being useful. > > The error messages look unhelpful. I don't think you can expect any meaninful improvements on the debug message contents from Wambui without detailed help at this point. > >> if ((batch_end - cmd) < length) { >> - DRM_DEBUG("CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n", >> - *cmd, >> - length, >> - batch_end - cmd); >> + drm_dbg(&dev_priv->drm, >> + "CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n", > > No. This is not driver debug. If anything this should be pr_debug, or > some over user centric channel. I'm sorry, I still don't understand your reasoning here. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4BD3C33CAD for ; Mon, 13 Jan 2020 12:08:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C58E0207FD for ; Mon, 13 Jan 2020 12:08:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C58E0207FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 025836E088; Mon, 13 Jan 2020 12:08:30 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 70A216E082; Mon, 13 Jan 2020 12:08:28 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 04:08:27 -0800 X-IronPort-AV: E=Sophos;i="5.69,428,1571727600"; d="scan'208";a="217387846" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 04:08:25 -0800 From: Jani Nikula To: Chris Wilson , Wambui Karuga , airlied@linux.ie, daniel@ffwll.ch, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com In-Reply-To: <157891427231.27314.12398974277241668021@skylake-alporthouse-com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200113111025.2048-1-wambui.karugax@gmail.com> <157891427231.27314.12398974277241668021@skylake-alporthouse-com> Date: Mon, 13 Jan 2020 14:08:22 +0200 Message-ID: <87lfqbmudl.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915: convert to new logging macros based on struct intel_engine_cs. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 13 Jan 2020, Chris Wilson wrote: > Quoting Wambui Karuga (2020-01-13 11:10:25) >> fn(...) { >> ... >> struct intel_engine_cs *E = ...; >> +struct drm_i915_private *dev_priv = E->i915; > > No new dev_priv. Wambui, we're gradually converting all dev_priv variable and parameter names to i915. > There should be no reason for drm_dbg here, as the rest of the debug is > behind ENGINE_TRACE and so the vestigial debug should be moved over, or > deleted as not being useful. > > The error messages look unhelpful. I don't think you can expect any meaninful improvements on the debug message contents from Wambui without detailed help at this point. > >> if ((batch_end - cmd) < length) { >> - DRM_DEBUG("CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n", >> - *cmd, >> - length, >> - batch_end - cmd); >> + drm_dbg(&dev_priv->drm, >> + "CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n", > > No. This is not driver debug. If anything this should be pr_debug, or > some over user centric channel. I'm sorry, I still don't understand your reasoning here. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx