From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E64EC43603 for ; Tue, 17 Dec 2019 14:35:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7077E21D7D for ; Tue, 17 Dec 2019 14:35:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="nDH/Fk87" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727720AbfLQOfN (ORCPT ); Tue, 17 Dec 2019 09:35:13 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:57375 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbfLQOfN (ORCPT ); Tue, 17 Dec 2019 09:35:13 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1576593312; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=21aBxipy8p7uk0rKdijJDM9b/aNaNo4M823NpVdIVDU=; b=nDH/Fk87N3uqlrjFaIgjSwRL6vfudcod/OrI/NNmdUUzNSt3C6TPm2GxQOo6D0NifkXNd4ZZ YiyuUZaJFcZvhBn9Ai9M/uIDK7/M5qP4qzH7hE/vv6xhznZd3bOE5hzrzQYLfjpOqpRFwU7p YDkAaZ2W3A7MyouzwUFeke9dvJw= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5df8e79f.7f9759a6a880-smtp-out-n01; Tue, 17 Dec 2019 14:35:11 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B324EC433A2; Tue, 17 Dec 2019 14:35:10 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6A0EEC43383; Tue, 17 Dec 2019 14:35:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6A0EEC43383 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Arnd Bergmann Cc: Felix Fietkau , Lorenzo Bianconi , "David S. Miller" , Matthias Brugger , Ryder Lee , Roy Luo , Stanislaw Gruszka , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mt76: fix LED link time failure References: <20191216131902.3251040-1-arnd@arndb.de> Date: Tue, 17 Dec 2019 16:35:02 +0200 In-Reply-To: <20191216131902.3251040-1-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 16 Dec 2019 14:18:42 +0100") Message-ID: <87lfrbaull.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Arnd Bergmann writes: > The mt76_led_cleanup() function is called unconditionally, which > leads to a link error when CONFIG_LEDS is a loadable module or > disabled but mt76 is built-in: > > drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device': > mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister' > > Use the same trick that is guarding the registration, using an > IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates > whether LEDs can be used or not. > > Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev") > Signed-off-by: Arnd Bergmann Felix, as this is a regression in v5.5-rc1 can I take this directly to wireless-drivers? -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F18B1C2D0D1 for ; Tue, 17 Dec 2019 14:35:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C492B24655 for ; Tue, 17 Dec 2019 14:35:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h8gWW7rA"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="UXcywob3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C492B24655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vtd3Ur5vWfM+48tJ5F2DJQzB6xcvBCU/hcd50+FA0ek=; b=h8gWW7rAejzLiM Mwt15gZZnCbf9ryCfYHIhjXn1YGsIR6ZDYI7DhBGm5WSml6OguImuPanLoRKtsfwtZm0Ulds9PtZp 6JFMW3QqiirM7GmP6LfGMLga9UvGutnezVMPiewa8eGFCyqJ6P5mAGxVGtI42TNWAGO2hVORICqtz jvumBL9glU3ZRUI06ELsD455U6rAa5aM9lKeA8GjQYUyqJe7S+dBH9ReUWyEXEBM2JvBEDA+XRs3v omg+1TbeNgbdH54G9iKrmPCUaEpRP319DqcpmtkU6vf1BxmTOxxdyImyIzCD7bUdouGE1brNSUJPa T4fmNjCf67Jt50MtShow==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihDwV-0002gX-N8; Tue, 17 Dec 2019 14:35:19 +0000 Received: from mail25.static.mailgun.info ([104.130.122.25]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihDwQ-0002d8-SS for linux-mediatek@lists.infradead.org; Tue, 17 Dec 2019 14:35:16 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1576593314; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=21aBxipy8p7uk0rKdijJDM9b/aNaNo4M823NpVdIVDU=; b=UXcywob3w3WHof0J0qPgk0jTMxjv2Tunxr1gJbJ0KcbsjZEgGzxvYMaXM/JTlGap1YisduzI M1A/RgA8afeFu0fw0QIthwc6GIcCb2Und0mrJbQ34bvISuNKlkYy5boKaV+ej1+0DSH+epm+ EIalLQrBXPQcIFRDMq3U43q2H0g= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyI0ZDIyMyIsICJsaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5df8e79e.7fa12ff73ca8-smtp-out-n03; Tue, 17 Dec 2019 14:35:10 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 3CC1CC4479C; Tue, 17 Dec 2019 14:35:09 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6A0EEC43383; Tue, 17 Dec 2019 14:35:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6A0EEC43383 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Arnd Bergmann Subject: Re: [PATCH] mt76: fix LED link time failure References: <20191216131902.3251040-1-arnd@arndb.de> Date: Tue, 17 Dec 2019 16:35:02 +0200 In-Reply-To: <20191216131902.3251040-1-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 16 Dec 2019 14:18:42 +0100") Message-ID: <87lfrbaull.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191217_063514_983095_C09CA2E4 X-CRM114-Status: GOOD ( 14.15 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ryder Lee , Stanislaw Gruszka , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Brugger , linux-mediatek@lists.infradead.org, Roy Luo , Lorenzo Bianconi , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Felix Fietkau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Arnd Bergmann writes: > The mt76_led_cleanup() function is called unconditionally, which > leads to a link error when CONFIG_LEDS is a loadable module or > disabled but mt76 is built-in: > > drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device': > mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister' > > Use the same trick that is guarding the registration, using an > IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates > whether LEDs can be used or not. > > Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev") > Signed-off-by: Arnd Bergmann Felix, as this is a regression in v5.5-rc1 can I take this directly to wireless-drivers? -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C8B9C2D0C8 for ; Tue, 17 Dec 2019 14:35:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E1B424655 for ; Tue, 17 Dec 2019 14:35:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WhkAEgV+"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="UxxaXhO0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E1B424655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PE5Iup1XXi5Gj22aB0c36yznYgXMrkWL1qDHBz0u3jY=; b=WhkAEgV+6X49Qa l92uzCMDSMio22BeY8LO+0mtfd0m4lzeh4Yx88nbUiy2MHW7jhfIWycud170JbbsBsh1aPr0Nf25I EHjNhs/yk07kizrgjw35YMO3omzx1OQt7jIJdNe8l+bwiJGzUML2jtmZXxmwsPuguptIXhspZs0pN 6f/Ro0BykCQs6BOZOl+50k4yVSDTP9XgD5ZWJu4jbcSGqxJEfimAgAvXZAxt7s+3ZNV4YitDJvd+D Q1RI74P/kwYbxDJ+X+bLK4tSK8cqcyLK269x4bMuolgLtd8IA2ZNLRU0NwI/aInR+01F3DlMsxUJv mlLexVt6fcnoZFloSBkA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihDwY-0002jC-KF; Tue, 17 Dec 2019 14:35:22 +0000 Received: from mail25.static.mailgun.info ([104.130.122.25]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihDwQ-0002d6-4r for linux-arm-kernel@lists.infradead.org; Tue, 17 Dec 2019 14:35:18 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1576593316; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=21aBxipy8p7uk0rKdijJDM9b/aNaNo4M823NpVdIVDU=; b=UxxaXhO0rRqWyCaL+ELlaepVtjljLCWsuhrMv+TegaQk3yLVkWHYpN3uXZ4leytkWD70MNig 2NBbF7SHAV9dCDfFENupPG6i8mYUGy+J5DWZv7CoDpHgB3/vxctu1NP1+HgSIe1DPwsG+9W7 TADAPcN9fdqDOKaET0ptNQVhlQA= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5df8e79e.7fa12ff73ca8-smtp-out-n03; Tue, 17 Dec 2019 14:35:10 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 3CC1CC4479C; Tue, 17 Dec 2019 14:35:09 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6A0EEC43383; Tue, 17 Dec 2019 14:35:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6A0EEC43383 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Arnd Bergmann Subject: Re: [PATCH] mt76: fix LED link time failure References: <20191216131902.3251040-1-arnd@arndb.de> Date: Tue, 17 Dec 2019 16:35:02 +0200 In-Reply-To: <20191216131902.3251040-1-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 16 Dec 2019 14:18:42 +0100") Message-ID: <87lfrbaull.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191217_063516_828266_C6BCCFC5 X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ryder Lee , Stanislaw Gruszka , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Brugger , linux-mediatek@lists.infradead.org, Roy Luo , Lorenzo Bianconi , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Felix Fietkau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Arnd Bergmann writes: > The mt76_led_cleanup() function is called unconditionally, which > leads to a link error when CONFIG_LEDS is a loadable module or > disabled but mt76 is built-in: > > drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device': > mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister' > > Use the same trick that is guarding the registration, using an > IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates > whether LEDs can be used or not. > > Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev") > Signed-off-by: Arnd Bergmann Felix, as this is a regression in v5.5-rc1 can I take this directly to wireless-drivers? -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel