From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDBA2C43603 for ; Tue, 17 Dec 2019 03:55:07 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9CF82072B for ; Tue, 17 Dec 2019 03:55:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="OSJxdnIX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9CF82072B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D695815F9; Tue, 17 Dec 2019 04:54:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D695815F9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1576554905; bh=NmeNUhDQTYvrBeHBud8Q9oqsLKy3675wUWdUoNnaf2s=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=OSJxdnIXYvTbdV+K69RnbTED29PufaMAkHdg0x/uiVQNaTsgs6q4qqxe1UvUAf2ZA aRr43s0+nNGWWypoIthEFnVd6+331yjFq6JM+jniDcU6XlxHHbwV1Jr72F7PxWEYq0 D12vxBJOLG/X0FzgflfaySZdEOcBopzgColeQqZE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5B229F80218; Tue, 17 Dec 2019 04:54:14 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A2308F80234; Tue, 17 Dec 2019 04:54:11 +0100 (CET) Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by alsa1.perex.cz (Postfix) with ESMTP id E915EF80088 for ; Tue, 17 Dec 2019 04:54:04 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E915EF80088 Date: 17 Dec 2019 12:54:02 +0900 X-IronPort-AV: E=Sophos;i="5.69,324,1571670000"; d="scan'208";a="34610521" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie5.idc.renesas.com with ESMTP; 17 Dec 2019 12:54:02 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 56A334181DF1; Tue, 17 Dec 2019 12:54:02 +0900 (JST) Message-ID: <87lfrbhajp.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Pierre-Louis Bossart In-Reply-To: <01e4157a-d4b7-8bb2-d3bf-957d47e3e5f9@linux.intel.com> References: <87woavhhfi.wl-kuninori.morimoto.gx@renesas.com> <87o8w7hhds.wl-kuninori.morimoto.gx@renesas.com> <01e4157a-d4b7-8bb2-d3bf-957d47e3e5f9@linux.intel.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Cc: Linux-ALSA , Mark Brown Subject: Re: [alsa-devel] [PATCH 6/6] ASoC: soc-core: add snd_soc_stream_stop() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Pierre-Louis Thank you for your review > > +void snd_soc_stream_stop(struct snd_soc_pcm_runtime *rtd, int stream) > > +{ > > + if (stream == SNDRV_PCM_STREAM_PLAYBACK) { > > + if (snd_soc_runtime_ignore_pmdown_time(rtd)) { > > + /* powered down playback stream now */ > > + snd_soc_dapm_stream_event(rtd, > > + SNDRV_PCM_STREAM_PLAYBACK, > > + SND_SOC_DAPM_STREAM_STOP); > > + } else { > > + /* start delayed pop wq here for playback streams */ > > + rtd->pop_wait = 1; > > + queue_delayed_work(system_power_efficient_wq, > > + &rtd->delayed_work, > > + msecs_to_jiffies(rtd->pmdown_time)); > > + } > > + } else { > > + /* capture streams can be powered down now */ > > + snd_soc_dapm_stream_event(rtd, SNDRV_PCM_STREAM_CAPTURE, > > + SND_SOC_DAPM_STREAM_STOP); > > + } > > +} > > +EXPORT_SYMBOL_GPL(snd_soc_stream_stop); > > I am not a big fan of naming conventions for the new helper. We don't > have any other snd_soc_stream function, but we have a concept of > stream for SoundWire. we also have snd_soc_dapm_stream_ functions.. > > snd_soc_dapm_stream_stop() maybe? Ahh, make sense ! I will post v2 tomorrow Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel