From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5FE5CA9EB6 for ; Wed, 23 Oct 2019 09:52:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B859A2064B for ; Wed, 23 Oct 2019 09:52:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YkCfPhtK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390246AbfJWJwL (ORCPT ); Wed, 23 Oct 2019 05:52:11 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:34672 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2390079AbfJWJwK (ORCPT ); Wed, 23 Oct 2019 05:52:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571824329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/5Gd+sGRTLO/YyPTwPaFlOWjYLG6/P4AaU01cq86LiI=; b=YkCfPhtK65HdFTThn4pUhr48kpBIXpSp/fQw8GjnhPdYo9mBdf6WgGvC+k1PFHn9K7tHY6 uhldKkVRNyNULWI0WIUiEqdHeLFgSSeHAi5iq2YxS0UWuBNpg/+UXb7m+qSkUneq7tGbJR oY+/9dsJuJyEIji/CTlBGT9BZS8P/Kc= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-353-3N2xuw_eMzGTuH6hOdXGRw-1; Wed, 23 Oct 2019 05:52:06 -0400 Received: by mail-lf1-f69.google.com with SMTP id v204so2208778lfa.0 for ; Wed, 23 Oct 2019 02:52:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=hFVDZODcV1pnEtDDIb8UrMv3iIHS2UTtEmv96KMbc7k=; b=UDzZjFxZRRXvtVDw3bvZQiu9n6LvMHk3XPYKS24b6j9htu7aj2/Kbg5URT+yLXEQ+U 7GFxNXL6g9IHvbMnImJA8gdDcD9XujEA+m8QNlcknDFVCH0LSTSIA+jkYAZu16zTVD0y K/yWfUoFhQz9GSvAMg/2W1UKiZ56f9s9ZS6TaQ859qE8C4AU4lkkrkmyMrhLhA3GJV7l 2IwJZhO3SusZeYwjImzVmzN+Owk0Ld/5n39KvfgiLtUYg6x8rPmXg1+nEFk83Ipm48gs i6E4CxAUg02EdGE65uywKLMEgzyKbLEkQJ880pVBW06zYDl5UJNJ3SmVaR51n0XVCToY cRGw== X-Gm-Message-State: APjAAAUHrY2VuKbXUIXllgGbc4MsRq+ynr0P5pcVIEpcLHoOIYSIOcX8 qexXbjlPBfcrZKQPhaIka6srqMSLREeBlnwnLD+/sMaB9MEvSiBpE1s22X9aCmkeWYb3vuwpvCm MHE9yGd7u4Xr84/OvwNsbSj1MMQQ= X-Received: by 2002:a2e:9107:: with SMTP id m7mr6003963ljg.113.1571824324909; Wed, 23 Oct 2019 02:52:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqwfTq6OyuPRjrUqdJ+q6pELeZDh85Gk4HQhTKpMvjbXzGrJtsr2TVw1Ipp+RRdcPFqc3KuU/w== X-Received: by 2002:a2e:9107:: with SMTP id m7mr6003952ljg.113.1571824324735; Wed, 23 Oct 2019 02:52:04 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id u24sm5939167ljl.64.2019.10.23.02.52.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2019 02:52:03 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id C05CD1804B1; Wed, 23 Oct 2019 11:52:02 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kan Yan Cc: Johannes Berg , linux-wireless@vger.kernel.org, Make-Wifi-fast , ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Rajkumar Manoharan , Kevin Hayes Subject: Re: [PATCH v4 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue In-Reply-To: <87tv7znact.fsf@toke.dk> References: <157148503415.2989444.7391437309981941226.stgit@toke.dk> <157148503865.2989444.7118792679603045723.stgit@toke.dk> <871rv5ovwr.fsf@toke.dk> <87tv7znact.fsf@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 23 Oct 2019 11:52:02 +0200 Message-ID: <87lftbn60t.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: 3N2xuw_eMzGTuH6hOdXGRw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Toke H=C3=B8iland-J=C3=B8rgensen writes: > Kan Yan writes: > >>> >> + if (ieee80211_is_data_qos(hdr->frame_control)) { >>> >> + qc =3D ieee80211_get_qos_ctl(hdr); >>> >> + tid =3D qc[0] & 0xf; >>> >> + ac =3D ieee80211_ac_from_tid(tid); >>> >> + } else { >>> >> + ac =3D IEEE80211_AC_BE; >>> >> + } >>> > >>> > The tid/ac is incorrect either here or in __ieee80211_tx_status() whe= n >>> > tested with ath10k. The ac is set to AC_BE with test done using BK >>> > class traffic, hence the pending airtime get updated for the wrong >>> > txq. >>> >>> Huh, well that won't do, obviously :) >>> >>> Any idea why it might be wrong? >> >> somehow ieee80211_is_data_qos() returns false. Besides, qos_control >> field doesn't seems to be set in ieee80211_build_hdr(). >> >>> Hmm, I guess we could just get the ac using skb_get_queue_mapping(). >>> I'll send an update with this fixed for you to try :) >> Thanks for the quick update. It is getting much better, but >> unfortunately the pending airtime accounting sometimes is still not >> correct and cause txq stuck occasionally. > > OK, so that has to mean that there are packets getting dropped somewhere > without going through ieee80211_report_used_skb(). Assuming you're not > hitting the underflow warnings, just seeing the counter not get back > down to zero? > > Could you see if you can find out if ath10k does that anywhere? I'll go > hunting in mac80211. > > Looking for calls to kfree_skb() or kfree_skb_list() should hopefully > turn up something... Aha! Turns out I was doing the sta lookup completely wrong in ieee80211_report_used_skb(); so anything frames that were dropped and went through there would not get its airtime subtracted correctly. Will send a v6 with a fix :) -Toke From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from us-smtp-1.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNDJM-0007lC-GU for ath10k@lists.infradead.org; Wed, 23 Oct 2019 09:52:18 +0000 Received: by mail-lf1-f71.google.com with SMTP id c13so4000682lfk.23 for ; Wed, 23 Oct 2019 02:52:06 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH v4 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue In-Reply-To: <87tv7znact.fsf@toke.dk> References: <157148503415.2989444.7391437309981941226.stgit@toke.dk> <157148503865.2989444.7118792679603045723.stgit@toke.dk> <871rv5ovwr.fsf@toke.dk> <87tv7znact.fsf@toke.dk> Date: Wed, 23 Oct 2019 11:52:02 +0200 Message-ID: <87lftbn60t.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kan Yan Cc: Rajkumar Manoharan , Kevin Hayes , Make-Wifi-fast , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, John Crispin , Johannes Berg , Lorenzo Bianconi , Felix Fietkau VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJlZGhhdC5jb20+IHdyaXRlczoKCj4gS2Fu IFlhbiA8a3lhbkBnb29nbGUuY29tPiB3cml0ZXM6Cj4KPj4+ID4+ICsgICAgICAgICAgICAgICBp ZiAoaWVlZTgwMjExX2lzX2RhdGFfcW9zKGhkci0+ZnJhbWVfY29udHJvbCkpIHsKPj4+ID4+ICsg ICAgICAgICAgICAgICAgICAgICAgIHFjID0gaWVlZTgwMjExX2dldF9xb3NfY3RsKGhkcik7Cj4+ PiA+PiArICAgICAgICAgICAgICAgICAgICAgICB0aWQgPSBxY1swXSAmIDB4ZjsKPj4+ID4+ICsg ICAgICAgICAgICAgICAgICAgICAgIGFjID0gaWVlZTgwMjExX2FjX2Zyb21fdGlkKHRpZCk7Cj4+ PiA+PiArICAgICAgICAgICAgICAgfSBlbHNlIHsKPj4+ID4+ICsgICAgICAgICAgICAgICAgICAg ICAgIGFjID0gSUVFRTgwMjExX0FDX0JFOwo+Pj4gPj4gKyAgICAgICAgICAgICAgIH0KPj4+ID4K Pj4+ID4gVGhlIHRpZC9hYyBpcyBpbmNvcnJlY3QgZWl0aGVyIGhlcmUgb3IgaW4gX19pZWVlODAy MTFfdHhfc3RhdHVzKCkgd2hlbgo+Pj4gPiB0ZXN0ZWQgd2l0aCBhdGgxMGsuIFRoZSBhYyBpcyBz ZXQgdG8gQUNfQkUgd2l0aCB0ZXN0IGRvbmUgdXNpbmcgQksKPj4+ID4gY2xhc3MgdHJhZmZpYywg aGVuY2UgdGhlIHBlbmRpbmcgYWlydGltZSBnZXQgdXBkYXRlZCBmb3IgdGhlIHdyb25nCj4+PiA+ IHR4cS4KPj4+Cj4+PiBIdWgsIHdlbGwgdGhhdCB3b24ndCBkbywgb2J2aW91c2x5IDopCj4+Pgo+ Pj4gQW55IGlkZWEgd2h5IGl0IG1pZ2h0IGJlIHdyb25nPwo+Pgo+PiBzb21laG93ICBpZWVlODAy MTFfaXNfZGF0YV9xb3MoKSByZXR1cm5zIGZhbHNlLiBCZXNpZGVzLCAgcW9zX2NvbnRyb2wKPj4g ZmllbGQgZG9lc24ndCBzZWVtcyB0byBiZSBzZXQgaW4gaWVlZTgwMjExX2J1aWxkX2hkcigpLgo+ Pgo+Pj4gSG1tLCBJIGd1ZXNzIHdlIGNvdWxkIGp1c3QgZ2V0IHRoZSBhYyB1c2luZyBza2JfZ2V0 X3F1ZXVlX21hcHBpbmcoKS4KPj4+IEknbGwgc2VuZCBhbiB1cGRhdGUgd2l0aCB0aGlzIGZpeGVk IGZvciB5b3UgdG8gdHJ5IDopCj4+IFRoYW5rcyBmb3IgdGhlIHF1aWNrIHVwZGF0ZS4gSXQgaXMg Z2V0dGluZyBtdWNoIGJldHRlciwgYnV0Cj4+IHVuZm9ydHVuYXRlbHkgdGhlIHBlbmRpbmcgYWly dGltZSBhY2NvdW50aW5nIHNvbWV0aW1lcyBpcyBzdGlsbCBub3QKPj4gY29ycmVjdCBhbmQgY2F1 c2UgdHhxIHN0dWNrIG9jY2FzaW9uYWxseS4KPgo+IE9LLCBzbyB0aGF0IGhhcyB0byBtZWFuIHRo YXQgdGhlcmUgYXJlIHBhY2tldHMgZ2V0dGluZyBkcm9wcGVkIHNvbWV3aGVyZQo+IHdpdGhvdXQg Z29pbmcgdGhyb3VnaCBpZWVlODAyMTFfcmVwb3J0X3VzZWRfc2tiKCkuIEFzc3VtaW5nIHlvdSdy ZSBub3QKPiBoaXR0aW5nIHRoZSB1bmRlcmZsb3cgd2FybmluZ3MsIGp1c3Qgc2VlaW5nIHRoZSBj b3VudGVyIG5vdCBnZXQgYmFjawo+IGRvd24gdG8gemVybz8KPgo+IENvdWxkIHlvdSBzZWUgaWYg eW91IGNhbiBmaW5kIG91dCBpZiBhdGgxMGsgZG9lcyB0aGF0IGFueXdoZXJlPyBJJ2xsIGdvCj4g aHVudGluZyBpbiBtYWM4MDIxMS4KPgo+IExvb2tpbmcgZm9yIGNhbGxzIHRvIGtmcmVlX3NrYigp IG9yIGtmcmVlX3NrYl9saXN0KCkgc2hvdWxkIGhvcGVmdWxseQo+IHR1cm4gdXAgc29tZXRoaW5n Li4uCgpBaGEhIFR1cm5zIG91dCBJIHdhcyBkb2luZyB0aGUgc3RhIGxvb2t1cCBjb21wbGV0ZWx5 IHdyb25nIGluCmllZWU4MDIxMV9yZXBvcnRfdXNlZF9za2IoKTsgc28gYW55dGhpbmcgZnJhbWVz IHRoYXQgd2VyZSBkcm9wcGVkIGFuZAp3ZW50IHRocm91Z2ggdGhlcmUgd291bGQgbm90IGdldCBp dHMgYWlydGltZSBzdWJ0cmFjdGVkIGNvcnJlY3RseS4gV2lsbApzZW5kIGEgdjYgd2l0aCBhIGZp eCA6KQoKLVRva2UKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRoMTBrCg==