From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Weimer Subject: Re: [PATCH] Linux: Define struct termios2 in under _GNU_SOURCE [BZ #10339] Date: Mon, 15 Apr 2019 14:28:48 +0200 Message-ID: <87lg0b311b.fsf@oldenburg2.str.redhat.com> References: <875zrnlakd.fsf@oldenburg2.str.redhat.com> <284e9c76-2411-b8f4-c4bc-c25c60c04cf7@linaro.org> <87imvker6t.fsf@oldenburg2.str.redhat.com> <87lg0fbr1q.fsf@oldenburg2.str.redhat.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org In-Reply-To: <87lg0fbr1q.fsf@oldenburg2.str.redhat.com> (Florian Weimer's message of "Fri, 12 Apr 2019 09:50:41 +0200") To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, hpa@zytor.com, linux-api@vger.kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: linux-api@vger.kernel.org * Florian Weimer: > My gut feeling is that it's safer to add new interfaces, based on the > actual kernel/userspace interface, rather than trying to fix up existing > interfaces with symbol versioning. The main reason is that code > involving serial interfaces is difficult to test, so it will take years > until we find the last application broken by the glibc interface bump. > > I don't feel strongly about this. This came out of a request for > enabling TCGETS2 support downstream. If I can't fix this upstream, I > will just reject that request. Any further comments on this matter? Thanks, Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4E7EC10F0E for ; Mon, 15 Apr 2019 12:31:02 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50CDF2073F for ; Mon, 15 Apr 2019 12:31:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50CDF2073F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44jSXM564HzDqHG for ; Mon, 15 Apr 2019 22:30:59 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=redhat.com (client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=fweimer@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44jSV661bZzDqDx for ; Mon, 15 Apr 2019 22:29:01 +1000 (AEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2904A4627A; Mon, 15 Apr 2019 12:28:57 +0000 (UTC) Received: from oldenburg2.str.redhat.com (unknown [10.36.118.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE7AB19C79; Mon, 15 Apr 2019 12:28:55 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Subject: Re: [PATCH] Linux: Define struct termios2 in under _GNU_SOURCE [BZ #10339] References: <875zrnlakd.fsf@oldenburg2.str.redhat.com> <284e9c76-2411-b8f4-c4bc-c25c60c04cf7@linaro.org> <87imvker6t.fsf@oldenburg2.str.redhat.com> <87lg0fbr1q.fsf@oldenburg2.str.redhat.com> Date: Mon, 15 Apr 2019 14:28:48 +0200 In-Reply-To: <87lg0fbr1q.fsf@oldenburg2.str.redhat.com> (Florian Weimer's message of "Fri, 12 Apr 2019 09:50:41 +0200") Message-ID: <87lg0b311b.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 15 Apr 2019 12:28:57 +0000 (UTC) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-api@vger.kernel.org, libc-alpha@sourceware.org, linuxppc-dev@lists.ozlabs.org, hpa@zytor.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" * Florian Weimer: > My gut feeling is that it's safer to add new interfaces, based on the > actual kernel/userspace interface, rather than trying to fix up existing > interfaces with symbol versioning. The main reason is that code > involving serial interfaces is difficult to test, so it will take years > until we find the last application broken by the glibc interface bump. > > I don't feel strongly about this. This came out of a request for > enabling TCGETS2 support downstream. If I can't fix this upstream, I > will just reject that request. Any further comments on this matter? Thanks, Florian